From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btdyz-0001hT-Qt for qemu-devel@nongnu.org; Mon, 10 Oct 2016 13:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btdyy-0001GK-Rz for qemu-devel@nongnu.org; Mon, 10 Oct 2016 13:03:21 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> From: Max Reitz Message-ID: <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> Date: Mon, 10 Oct 2016 19:03:09 +0200 MIME-Version: 1.0 In-Reply-To: <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QvU01GRxeRdf6aRwIerTpphV1tHWdcbOH" Subject: Re: [Qemu-devel] [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QvU01GRxeRdf6aRwIerTpphV1tHWdcbOH From: Max Reitz To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: <90502d55-4edf-73e7-18c2-306d3ebc3822@redhat.com> Subject: Re: [PATCH 18/22] qapi: add md5 checksum of last dirty bitmap level to query-block References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-19-git-send-email-vsementsov@virtuozzo.com> <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> In-Reply-To: <344ea26a-b476-965a-920e-19a4ff94be7c@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 10.10.2016 18:44, Max Reitz wrote: > On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >> Reviewed-by: John Snow >> Reviewed-by: Eric Blake >> Signed-off-by: Vladimir Sementsov-Ogievskiy = >> --- >> block/dirty-bitmap.c | 1 + >> include/qemu/hbitmap.h | 8 ++++++++ >> qapi/block-core.json | 5 ++++- >> util/hbitmap.c | 8 ++++++++ >> 4 files changed, 21 insertions(+), 1 deletion(-) >=20 > Having read John's and Eric's comments, I won't block this patch, but I= > won't give an R-b either. >=20 > It's probably true that this will not significantly slow down the > query-block call, but doing this only for debugging does not seem right= > to me. >=20 > I'm not sure what the right way would be to get this information out > (...maybe make it optional and set it only if qtest_enabled() is true?)= , > but in my opinion this is not the right way. By the way, the cleanest way I can come up with (which I didn't write about in my first reply because it's not so trivial) would be some kind of debugging QMP command convention. For instance, we could say that all debugging commands have an x-debug- prefix, and then you could add an x-debug-get-bitmap-md5 to read the MD5 hash of a named bitmap. That would appear to be the cleanest way to do this to me. Max > Since I'm not the maintainer of the bitmap code (Fam and John are, even= > though their MAINTAINERS patch is not in master still...), I can't and > won't block this, though. >=20 > Max >=20 --QvU01GRxeRdf6aRwIerTpphV1tHWdcbOH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJX+8nNEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQNCE B/476i9phjjcIpkDpL7l3mUQi3yT3X737HFPhlCdaUmVBNq2I7HRIthWR5DViYef oyOnm2BiYnzAwiKWYfrygbtuqAjO4BCNut2tfSS4gU424+vmIPqZ6OX3VhD0lUv8 u+XL/On33rsak1a01syHQ3b1HDRlxP5Zg/Gwc0N7etAT1LyLbiNJpcHlnXIgfqBy 8z4BMbYl/qPSVr8nwKTUO3qH4iHWF7JXIIgp8VjD0dA10lat+xs0OVMtwql7zShe AYbPKxNMEcfCIOSkNHVi4JVw11NHd5mxVkZRoOINybkeiHlnNeybSv7tGza+o353 hp5KJBpLvTS2P5fyBZdlBFqw =evmY -----END PGP SIGNATURE----- --QvU01GRxeRdf6aRwIerTpphV1tHWdcbOH--