From: Marek Vasut <marex@denx.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tristram Ha <Tristram.Ha@microchip.com>,
Woojung Huh <Woojung.Huh@microchip.com>
Subject: Re: [PATCH] net: dsa: microchip: Use gpiod_set_value_cansleep()
Date: Sun, 23 Jun 2019 17:12:19 +0200 [thread overview]
Message-ID: <9058f731-7b51-05ee-0cae-ad5c3850477e@denx.de> (raw)
In-Reply-To: <20190623150959.GC28942@lunn.ch>
On 6/23/19 5:09 PM, Andrew Lunn wrote:
> On Sun, Jun 23, 2019 at 02:10:36PM +0200, Marek Vasut wrote:
>> Replace gpiod_set_value() with gpiod_set_value_cansleep(), as the switch
>> reset GPIO can be connected to e.g. I2C GPIO expander and it is perfectly
>> fine for the kernel to sleep for a bit in ksz_switch_register().
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Actually, no, I missed a change in .remove , so I'll send a V2 with this
RB if you don't mind.
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2019-06-23 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:10 [PATCH] net: dsa: microchip: Use gpiod_set_value_cansleep() Marek Vasut
2019-06-23 15:09 ` Andrew Lunn
2019-06-23 15:12 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9058f731-7b51-05ee-0cae-ad5c3850477e@denx.de \
--to=marex@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.