Re: [PATCH 0/8 v1] Remove FMR support from RDMA drivers

From: Aron Silverton <aron.silverton@oracle.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: bvanassche@acm.org, Jason Gunthorpe <jgg@mellanox.com>,
	linux-rdma@vger.kernel.org, dledford@redhat.com, leon@kernel.org,
	sagi@grimberg.me, israelr@mellanox.com, shlomin@mellanox.com,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Subject: Re: [PATCH 0/8 v1] Remove FMR support from RDMA drivers
Date: Thu, 14 May 2020 10:13:15 -0500	[thread overview]
Message-ID: <905E7E0C-1F87-4552-A7E3-5C49EDBED138@oracle.com> (raw)
In-Reply-To: <20200514120305.189738-1-maxg@mellanox.com>

+Santosh

You probably meant to copy the RDS maintainer? Not sure if this should have
also been sent to netdev@vger.kernel.org.

Aron

> On May 14, 2020, at 7:02 AM, Max Gurtovoy <maxg@mellanox.com> wrote:
> 
> This series removes the support for FMR mode to register memory. This ancient
> mode is unsafe and not maintained/tested in the last few years. It also doesn't
> have any reasonable advantage over other memory registration methods such as
> FRWR (that is implemented in all the recent RDMA adapters). This series should
> be reviewed and approved by the maintainer of the effected drivers and I
> suggest to test it as well.
> 
> The tests that I made for this series (fio benchmarks and fio verify data):
> 1. iSER initiator on ConnectX-4
> 2. iSER initiator on ConnectX-3
> 3. SRP initiator on ConnectX-4 (loopback to SRP target)
> 4. SRP initiator on ConnectX-3
> 
> Not tested:
> 1. RDS
> 2. mthca
> 3. rdmavt
> 
> Israel Rukshin (1):
>  RDMA/iser: Remove support for FMR memory registration
> 
> Max Gurtovoy (7):
>  RDMA/mlx4: remove FMR support for memory registration
>  RDMA/rds: remove FMR support for memory registration
>  RDMA/mthca: remove FMR support for memory registration
>  RDMA/rdmavt: remove FMR memory registration
>  RDMA/srp: remove support for FMR memory registration
>  RDMA/core: remove FMR pool API
>  RDMA/core: remove FMR device ops
> 
> Documentation/driver-api/infiniband.rst      |   3 -
> Documentation/infiniband/core_locking.rst    |   2 -
> drivers/infiniband/core/Makefile             |   2 +-
> drivers/infiniband/core/device.c             |   4 -
> drivers/infiniband/core/fmr_pool.c           | 494 ---------------------------
> drivers/infiniband/core/verbs.c              |  48 ---
> drivers/infiniband/hw/mlx4/main.c            |  10 -
> drivers/infiniband/hw/mlx4/mlx4_ib.h         |  16 -
> drivers/infiniband/hw/mlx4/mr.c              |  93 -----
> drivers/infiniband/hw/mthca/mthca_dev.h      |  10 -
> drivers/infiniband/hw/mthca/mthca_mr.c       | 262 +-------------
> drivers/infiniband/hw/mthca/mthca_provider.c |  86 -----
> drivers/infiniband/sw/rdmavt/mr.c            | 154 ---------
> drivers/infiniband/sw/rdmavt/mr.h            |  15 -
> drivers/infiniband/sw/rdmavt/vt.c            |   4 -
> drivers/infiniband/ulp/iser/iscsi_iser.h     |  79 +----
> drivers/infiniband/ulp/iser/iser_initiator.c |  19 +-
> drivers/infiniband/ulp/iser/iser_memory.c    | 188 +---------
> drivers/infiniband/ulp/iser/iser_verbs.c     | 126 +------
> drivers/infiniband/ulp/srp/ib_srp.c          | 222 +-----------
> drivers/infiniband/ulp/srp/ib_srp.h          |  27 +-
> drivers/net/ethernet/mellanox/mlx4/mr.c      | 183 ----------
> include/linux/mlx4/device.h                  |  21 +-
> include/rdma/ib_fmr_pool.h                   |  93 -----
> include/rdma/ib_verbs.h                      |  45 ---
> net/rds/Makefile                             |   2 +-
> net/rds/ib.c                                 |  14 +-
> net/rds/ib.h                                 |   1 -
> net/rds/ib_cm.c                              |   4 +-
> net/rds/ib_fmr.c                             | 269 ---------------
> net/rds/ib_mr.h                              |  12 -
> net/rds/ib_rdma.c                            |  16 +-
> 32 files changed, 77 insertions(+), 2447 deletions(-)
> delete mode 100644 drivers/infiniband/core/fmr_pool.c
> delete mode 100644 include/rdma/ib_fmr_pool.h
> delete mode 100644 net/rds/ib_fmr.c
> 
> -- 
> 1.8.3.1
> 