From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/12] Misc, mostly meson patches for 2021-06-23
Date: Fri, 25 Jun 2021 10:48:15 +0200 [thread overview]
Message-ID: <905d5cdc-da96-7c84-4ea7-27cf78fa164d@redhat.com> (raw)
In-Reply-To: <CAFEAcA_TAZ-CgzM4pQxr71jaC2Vr0kenF2WXsqcR13YLaddDDQ@mail.gmail.com>
On 25/06/21 10:09, Peter Maydell wrote:
> Looks like a missing #include <stddef.h> in the test code, rather
> than anything specifically libpam related.
Yes, indeed.
> More generally, I think if meson probes for some library
> and can't find it, the correct response is that it should
> just print "Library libpam found: NO", not a "WARNING".
> "You don't have an optional library, we'll skip that optional
> feature" is a normal situation.
The "NO" is present in the final summary; having the library but then
failing to compile something is a relatively common case when you cannot
filter by version using pkg-config. But indeed we can downgrade those
warnings to message().
Paolo
prev parent reply other threads:[~2021-06-25 8:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 12:14 [PULL 00/12] Misc, mostly meson patches for 2021-06-23 Paolo Bonzini
2021-06-23 12:14 ` [PULL 01/12] target/i386: kvm: add support for TSC scaling Paolo Bonzini
2021-06-23 12:14 ` [PULL 02/12] meson: drop unused CONFIG_GCRYPT_HMAC Paolo Bonzini
2021-06-23 12:14 ` [PULL 03/12] configure: drop unused variables for xts Paolo Bonzini
2021-06-23 12:14 ` [PULL 04/12] meson: remove preadv from summary Paolo Bonzini
2021-06-23 12:14 ` [PULL 05/12] tests: remove QCRYPTO_HAVE_TLS_TEST_SUPPORT Paolo Bonzini
2021-06-23 12:14 ` [PULL 06/12] configure, meson: convert crypto detection to meson Paolo Bonzini
2021-06-23 12:14 ` [PULL 07/12] configure, meson: convert libtasn1 " Paolo Bonzini
2021-06-23 12:14 ` [PULL 08/12] configure, meson: convert pam " Paolo Bonzini
2021-06-23 12:14 ` [PULL 09/12] configure, meson: convert libusb " Paolo Bonzini
2021-06-25 2:09 ` 罗勇刚(Yonggang Luo)
2021-06-25 8:50 ` Paolo Bonzini
2021-06-23 12:14 ` [PULL 10/12] configure, meson: convert libcacard " Paolo Bonzini
2021-06-23 12:14 ` [PULL 11/12] configure, meson: convert libusbredir " Paolo Bonzini
2021-06-23 12:14 ` [PULL 12/12] KVM: Fix dirty ring mmap incorrect size due to renaming accident Paolo Bonzini
2021-06-24 19:09 ` [PULL 00/12] Misc, mostly meson patches for 2021-06-23 Peter Maydell
2021-06-24 21:04 ` Paolo Bonzini
2021-06-25 8:09 ` Peter Maydell
2021-06-25 8:48 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905d5cdc-da96-7c84-4ea7-27cf78fa164d@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.