From: Laszlo Ersek <lersek@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, mst@redhat.com, marcel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge
Date: Sat, 23 Sep 2017 00:18:51 +0200 [thread overview]
Message-ID: <905d94b3-291b-0e55-e234-97fc2c85b6a6@redhat.com> (raw)
In-Reply-To: <1506082711-16004-1-git-send-email-mark.cave-ayland@ilande.co.uk>
On 09/22/17 14:18, Mark Cave-Ayland wrote:
> Whilst the underlying PCI bridge implementation supports 32-bit PCI IO
> accesses, unfortunately they are truncated at the legacy 64K limit.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/pci/pci_bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
> index 17feae5..a47d257 100644
> --- a/hw/pci/pci_bridge.c
> +++ b/hw/pci/pci_bridge.c
> @@ -379,7 +379,8 @@ void pci_bridge_initfn(PCIDevice *dev, const char *typename)
> sec_bus->address_space_mem = &br->address_space_mem;
> memory_region_init(&br->address_space_mem, OBJECT(br), "pci_bridge_pci", UINT64_MAX);
> sec_bus->address_space_io = &br->address_space_io;
> - memory_region_init(&br->address_space_io, OBJECT(br), "pci_bridge_io", 65536);
> + memory_region_init(&br->address_space_io, OBJECT(br), "pci_bridge_io",
> + UINT32_MAX);
> br->windows = pci_bridge_region_init(br);
> QLIST_INIT(&sec_bus->child);
> QLIST_INSERT_HEAD(&parent->child, sec_bus, sibling);
>
Based on the commit message, I assume this change is guest-visible. If
so, should it be made dependent on a compat property, so that it doesn't
cause problems with migration?
Thanks,
Laszlo
next prev parent reply other threads:[~2017-09-22 22:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 12:18 [Qemu-devel] [PATCH] pci: allow 32-bit PCI IO accesses to pass through the PCI bridge Mark Cave-Ayland
2017-09-22 21:21 ` Richard Henderson
2017-09-22 22:18 ` Laszlo Ersek [this message]
2017-09-23 8:23 ` Mark Cave-Ayland
2017-09-24 15:43 ` Marcel Apfelbaum
2017-09-24 16:56 ` Mark Cave-Ayland
2017-09-25 8:11 ` Dr. David Alan Gilbert
2017-09-28 7:31 ` Mark Cave-Ayland
2017-09-28 7:56 ` Laszlo Ersek
2017-10-01 21:44 ` Mark Cave-Ayland
2017-10-11 6:35 ` Mark Cave-Ayland
2017-10-19 9:38 ` Marcel Apfelbaum
2017-09-28 9:19 ` Marcel Apfelbaum
2017-10-01 21:49 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905d94b3-291b-0e55-e234-97fc2c85b6a6@redhat.com \
--to=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.