From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/mm: Drop MEM_LOG() and correct some printed information Date: Wed, 29 Mar 2017 14:50:51 +0100 Message-ID: <90638528-667c-9dc7-f373-6780a670063a@citrix.com> References: <1490790572-19840-1-git-send-email-andrew.cooper3@citrix.com> <58DBCD7E020000780014A093@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <58DBCD7E020000780014A093@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMjkvMDMvMTcgMTQ6MDYsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDI5LjAzLjE3IGF0 IDE0OjI5LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+ICAqIFVzZSAweCBw cmVmaXggZm9yIG90aGVyd2lzZSB1bnF1YWxpZmllZCBoZXggbnVtYmVycy4KPiBJJ20gZ2xhZCB0 aGlzIGluIGZhY3QgcmVmZXJzIHRvIGp1c3QgYSBzaW5nbGUgcGxhY2UuCj4KPj4gQEAgLTEwNTcs MTAgKzEwNjIsMTAgQEAgZ2V0X3BhZ2VfZnJvbV9sMWUoCj4+ICAgICAgICAgICAgICAgICAgcHV0 X3BhZ2VfdHlwZShwYWdlKTsKPj4gICAgICAgICAgICAgIHB1dF9wYWdlKHBhZ2UpOwo+PiAgCj4+ IC0gICAgICAgICAgICBNRU1fTE9HKCJFcnJvciB1cGRhdGluZyBtYXBwaW5ncyBmb3IgbWZuICVs eCAocGZuICVseCwiCj4+IC0gICAgICAgICAgICAgICAgICAgICIgZnJvbSBMMSBlbnRyeSAlIiBQ UklwdGUgIikgZm9yICVkIiwKPj4gLSAgICAgICAgICAgICAgICAgICAgbWZuLCBnZXRfZ3Bmbl9m cm9tX21mbihtZm4pLAo+PiAtICAgICAgICAgICAgICAgICAgICBsMWVfZ2V0X2ludHB0ZShsMWUp LCBsMWVfb3duZXItPmRvbWFpbl9pZCk7Cj4+ICsgICAgICAgICAgICBnZHByaW50ayhYRU5MT0df V0FSTklORywgIkVycm9yIHVwZGF0aW5nIG1hcHBpbmdzIGZvciBtZm4gJSIgUFJJX21mbgo+PiAr ICAgICAgICAgICAgICAgICAgICAgIiAocGZuICUiIFBSSV9wZm4gIiwgZnJvbSBMMSBlbnRyeSAl IiBQUklwdGUgIikgZm9yIGQlZFxuIiwKPj4gKyAgICAgICAgICAgICAgICAgICAgIG1mbiwgZ2V0 X2dwZm5fZnJvbV9tZm4obWZuKSwKPj4gKyAgICAgICAgICAgICAgICAgICAgIGwxZV9nZXRfaW50 cHRlKGwxZSksIGwxZV9vd25lci0+ZG9tYWluX2lkKTsKPj4gICAgICAgICAgICAgIHJldHVybiBl cnI7Cj4+ICAgICAgICAgIH0KPj4gICAgICB9Cj4+IEBAIC0xMDY4LDEwICsxMDczLDEwIEBAIGdl dF9wYWdlX2Zyb21fbDFlKAo+PiAgICAgIHJldHVybiAwOwo+PiAgCj4+ICAgY291bGRfbm90X3Bp bjoKPj4gLSAgICBNRU1fTE9HKCJFcnJvciBnZXR0aW5nIG1mbiAlbHggKHBmbiAlbHgpIGZyb20g TDEgZW50cnkgJSIgUFJJcHRlCj4+IC0gICAgICAgICAgICAiIGZvciBsMWVfb3duZXI9JWQsIHBn X293bmVyPSVkIiwKPj4gLSAgICAgICAgICAgIG1mbiwgZ2V0X2dwZm5fZnJvbV9tZm4obWZuKSwK Pj4gLSAgICAgICAgICAgIGwxZV9nZXRfaW50cHRlKGwxZSksIGwxZV9vd25lci0+ZG9tYWluX2lk LCBwZ19vd25lci0+ZG9tYWluX2lkKTsKPj4gKyAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywg IkVycm9yIGdldHRpbmcgbWZuICUiIFBSSV9tZm4gIiAocGZuICUiIFBSSV9wZm4KPj4gKyAgICAg ICAgICAgICAiKSBmcm9tIEwxIGVudHJ5ICUiIFBSSXB0ZSAiIGZvciBsMWVfb3duZXIgZCVkLCBw Z19vd25lciBkJWQiLAo+PiArICAgICAgICAgICAgIG1mbiwgZ2V0X2dwZm5fZnJvbV9tZm4obWZu KSwKPj4gKyAgICAgICAgICAgICBsMWVfZ2V0X2ludHB0ZShsMWUpLCBsMWVfb3duZXItPmRvbWFp bl9pZCwgcGdfb3duZXItPmRvbWFpbl9pZCk7Cj4gRXNwZWNpYWxseSBoZXJlIHRoZSB3cmFwcGlu ZyBvZiB0aGUgZm9ybWF0IHN0cmluZyBpcyByYXRoZXIKPiB1bmZvcnR1bmF0ZS4gRGlkbid0IHdl IGFncmVlIHRvIGFsbG93IGZvcm1hdCBzdHJpbmdzIHRvIGV4Y2VlZAo+IHRoZSA4MCBjb2x1bW4g cmVzdHJpY3Rpb24gYW55d2F5PwoKSXQgaXMgc3BsaXQgYXQgYSBmb3JtYXR0aW5nIGJvdW5kYXJ5 LCB3aGljaCBkb2Vzbid0IGFmZmVjdCBncmVwLWFiaWxpdHkuCgpQdXR0aW5nIHRoaXMgYWxsIG9u IG9uZSBsaW5lIGlzIDEyMyBjaGFyYWN0ZXJzLCB3aGljaCBJTU8gaXMgdG9vIGxvbmcuCgo+Cj4+ IEBAIC0xMzg4LDcgKzEzOTgsNyBAQCBzdGF0aWMgaW50IGFsbG9jX2wxX3RhYmxlKHN0cnVjdCBw YWdlX2luZm8gKnBhZ2UpCj4+ICAgICAgcmV0dXJuIDA7Cj4+ICAKPj4gICBmYWlsOgo+PiAtICAg IE1FTV9MT0coIkZhaWx1cmUgaW4gYWxsb2NfbDFfdGFibGU6IGVudHJ5ICVkIiwgaSk7Cj4+ICsg ICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJGYWlsdXJlIGluIGFsbG9jX2wxX3RhYmxlOiBl bnRyeSAlZFxuIiwgaSk7Cj4gJXUgKG9yIGV2ZW4gJTAzeDsgc2FtZSBpbiBhbGxvY19sWzIzNF1f dGFibGUoKSkKCkFjdHVhbGx5LCAic2xvdCAlI3giIHdvdWxkIGJlIGNsZWFyZXIgaGVyZS4gIEkg dGhvdWdoIEkgZml4ZWQgdGhlIDB4CnByZWZpeCBpbiBhbGxvY19sW11fdGFibGUoKSwgYW5kIEkg YW0gbm90IHN1cmUgdGhlIGxlYWRpbmcgemVyb2VzIGFyZQpoZWxwZnVsLgoKPgo+PiBAQCAtMTk3 OSw3ICsxOTkxLDggQEAgc3RhdGljIGludCBtb2RfbDJfZW50cnkobDJfcGdlbnRyeV90ICpwbDJl LAo+PiAgCj4+ICAgICAgaWYgKCB1bmxpa2VseSghaXNfZ3Vlc3RfbDJfc2xvdChkLCB0eXBlLCBw Z2VudHJ5X3B0cl90b19zbG90KHBsMmUpKSkgKQo+PiAgICAgIHsKPj4gLSAgICAgICAgTUVNX0xP RygiSWxsZWdhbCBMMiB1cGRhdGUgYXR0ZW1wdCBpbiBYZW4tcHJpdmF0ZSBhcmVhICVwIiwgcGwy ZSk7Cj4+ICsgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLAo+PiArICAgICAgICAgICAg ICAgICAiSWxsZWdhbCBMMiB1cGRhdGUgYXR0ZW1wdCBpbiBYZW4tcHJpdmF0ZSBhcmVhICVwXG4i LCBwbDJlKTsKPiBDb3VsZCB5b3UgbWFrZSB0aGlzIG1lc3NhZ2UgdXNlZnVsIGF0IG9uY2U/IFRo ZSBwb2ludGVyIGlzCj4gbm90IHJlYWxseSBoZWxwZnVsIHRvIGRpYWdub3NlIGFueXRoaW5nLCBJ IHRoaW5rLiBTYW1lIGZvcgo+IG1vZF9sWzM0XV9lbnRyeSgpIHRoZW4uCgpZZXMgLSBjYW4gc3dp dGNoIHRoZW0gdG8gc2xvdCBpbmZvcm1hdGlvbi4KCj4KPj4gQEAgLTMxNzksNyArMzIwOCw3IEBA IGxvbmcgZG9fbW11ZXh0X29wKAo+PiAgCj4+ICAgICAgICAgIGlmICggdW5saWtlbHkoX19jb3B5 X2Zyb21fZ3Vlc3QoJm9wLCB1b3BzLCAxKSAhPSAwKSApCj4+ICAgICAgICAgIHsKPj4gLSAgICAg ICAgICAgIE1FTV9MT0coIkJhZCBfX2NvcHlfZnJvbV9ndWVzdCIpOwo+PiArICAgICAgICAgICAg Z2RwcmludGsoWEVOTE9HX1dBUk5JTkcsICJCYWQgX19jb3B5X2Zyb21fZ3Vlc3RcbiIpOwo+IEkn ZCBzdWdnZXN0IHRvIGRyb3AgdGhpcyBvbmUgYWx0b2dldGhlci4KClllYWggLSBJIGhhZCBjb25z aWRlcmVkIHRoYXQuICBXaWxsIGRyb3AuCgo+Cj4+IEBAIC0zMTk1LDcgKzMyMjQsOCBAQCBsb25n IGRvX21tdWV4dF9vcCgKPj4gICAgICAgICAgICAgIGNhc2UgTU1VRVhUX1VOUElOX1RBQkxFOgo+ PiAgICAgICAgICAgICAgICAgIGJyZWFrOwo+PiAgICAgICAgICAgICAgZGVmYXVsdDoKPj4gLSAg ICAgICAgICAgICAgICBNRU1fTE9HKCJJbnZhbGlkIGV4dGVuZGVkIHB0IGNvbW1hbmQgJSN4Iiwg b3AuY21kKTsKPj4gKyAgICAgICAgICAgICAgICBnZHByaW50ayhYRU5MT0dfV0FSTklORywKPj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAiSW52YWxpZCBleHRlbmRlZCBwdCBjb21tYW5kICUj eFxuIiwgb3AuY21kKTsKPiBBbmQgdGhpcyBvbmUgdG9vLgoKT2suCgo+Cj4+IEBAIC0zMjk3LDcg KzMzMjksOCBAQCBsb25nIGRvX21tdWV4dF9vcCgKPj4gICAgICAgICAgICAgIHBhZ2UgPSBnZXRf cGFnZV9mcm9tX2dmbihwZ19vd25lciwgb3AuYXJnMS5tZm4sIE5VTEwsIFAyTV9BTExPQyk7Cj4+ ICAgICAgICAgICAgICBpZiAoIHVubGlrZWx5KCFwYWdlKSApCj4+ICAgICAgICAgICAgICB7Cj4+ IC0gICAgICAgICAgICAgICAgTUVNX0xPRygiTWZuICVseCBiYWQgZG9tYWluIiwgb3AuYXJnMS5t Zm4pOwo+PiArICAgICAgICAgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLAo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICJtZm4gJSIgUFJJX21mbiAiIGJhZCBkb21haW5cbiIsIG9w LmFyZzEubWZuKTsKPiBQZXJoYXBzIGFsc28gaW5jbHVkZSB0aGUgZG9tYWluIHdoaWNoIHdhcyBz dXBwb3NlZGx5IGJhZD8KCkl0IGlzIG5vdCB0aGF0IHNpbXBsZS4gIFRoaXMgZXJyb3IgbWVzc2Fn ZSBjb3ZlcnMgYm90aCB0aGUgbWZuIGJlaW5nCmJhZCwgYW5kIGEgZ29vZCBtZm4gbm90IGJlbG9u Z2luZyB0byB0aGUgcmVxdWVzdGVkIGRvbWFpbi4gIEkgd2lsbCBzZWUKaWYgSSBjYW4gd29yZCBz b21ldGhpbmcgYXBwcm9wcmlhdGVseS4KCj4KPj4gQEAgLTM0NTgsNyArMzQ5Myw4IEBAIGxvbmcg ZG9fbW11ZXh0X29wKAo+PiAgICAgICAgICAgICAgICAgIHJjID0gLUVQRVJNOwo+PiAgICAgICAg ICAgICAgZWxzZSBpZiAoIHVubGlrZWx5KCFjYWNoZV9mbHVzaF9wZXJtaXR0ZWQoZCkpICkKPj4g ICAgICAgICAgICAgIHsKPj4gLSAgICAgICAgICAgICAgICBNRU1fTE9HKCJOb24tcGh5c2RldiBk b21haW4gdHJpZWQgdG8gRkxVU0hfQ0FDSEUuIik7Cj4+ICsgICAgICAgICAgICAgICAgZ2Rwcmlu dGsoWEVOTE9HX1dBUk5JTkcsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIk5vbi1waHlz ZGV2IGRvbWFpbiB0cmllZCB0byBGTFVTSF9DQUNIRVxuIik7Cj4+ICAgICAgICAgICAgICAgICAg cmMgPSAtRUFDQ0VTOwo+PiAgICAgICAgICAgICAgfQo+PiAgICAgICAgICAgICAgZWxzZQo+PiBA QCAtMzQ4NCw3ICszNTIwLDggQEAgbG9uZyBkb19tbXVleHRfb3AoCj4+ICAgICAgICAgICAgICB9 Cj4+ICAgICAgICAgICAgICBlbHNlCj4+ICAgICAgICAgICAgICB7Cj4+IC0gICAgICAgICAgICAg ICAgTUVNX0xPRygiTm9uLXBoeXNkZXYgZG9tYWluIHRyaWVkIHRvIEZMVVNIX0NBQ0hFX0dMT0JB TCIpOwo+PiArICAgICAgICAgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLAo+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICJOb24tcGh5c2RldiBkb21haW4gdHJpZWQgdG8gRkxVU0hf Q0FDSEVfR0xPQkFMXG4iKTsKPj4gICAgICAgICAgICAgICAgICByYyA9IC1FSU5WQUw7Cj4+ICAg ICAgICAgICAgICB9Cj4+ICAgICAgICAgICAgICBicmVhazsKPiBJIHRoaW5rIHRoZXNlIGNvdWxk IGFsc28gYmUgZHJvcHBlZCAoYW5kIHBlcmhhcHMgYSBmZXcgbW9yZSByaWdodAo+IGJlbG93IGhl cmUpLgoKWW91IHByZXN1bWFibHkgbWVhbiBhbGwgdGhlIHRyaXZpYWwgb25lcyByZXR1cm5pbmcg LUVJTlZBTC4gIEkgd2lsbCBkcm9wCnRob3NlIGFzIHdlbGwuCgo+Cj4+IEBAIC0zNzM0LDcgKzM3 NzksNyBAQCBsb25nIGRvX21tdV91cGRhdGUoCj4+ICAKPj4gICAgICAgICAgaWYgKCB1bmxpa2Vs eShfX2NvcHlfZnJvbV9ndWVzdCgmcmVxLCB1cmVxcywgMSkgIT0gMCkgKQo+PiAgICAgICAgICB7 Cj4+IC0gICAgICAgICAgICBNRU1fTE9HKCJCYWQgX19jb3B5X2Zyb21fZ3Vlc3QiKTsKPj4gKyAg ICAgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLCAiQmFkIF9fY29weV9mcm9tX2d1ZXN0 XG4iKTsKPiBBbmQgdGhpcyBvbmUuCgpPay4KCj4KPj4gQEAgLTQyMDEsNyArNDI1MCw4IEBAIHN0 YXRpYyBpbnQgcmVwbGFjZV9ncmFudF92YV9tYXBwaW5nKAo+PiAgICAgIC8qIERlbGV0ZSBwYWdl dGFibGUgZW50cnkuICovCj4+ICAgICAgaWYgKCB1bmxpa2VseSghVVBEQVRFX0VOVFJZKGwxLCBw bDFlLCBvbDFlLCBubDFlLCBnbDFtZm4sIHYsIDApKSApCj4+ICAgICAgewo+PiAtICAgICAgICBN RU1fTE9HKCJDYW5ub3QgZGVsZXRlIFBURSBlbnRyeSBhdCAlcCIsICh1bnNpZ25lZCBsb25nICop cGwxZSk7Cj4+ICsgICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLAo+PiArICAgICAgICAg ICAgICAgICAiQ2Fubm90IGRlbGV0ZSBQVEUgZW50cnkgYXQgJXBcbiIsICh1bnNpZ25lZCBsb25n ICopcGwxZSk7Cj4gUGxlYXNlIGRyb3AgdGhlIHN0cmF5IGNhc3QuCgpPb3BzIC0gdGhvdWdodCBJ IGhhZCBjb3JyZWN0ZWQgdGhpcyBvbmUuCgo+Cj4+IEBAIC00MzE2LDcgKzQzNjcsNyBAQCBpbnQg cmVwbGFjZV9ncmFudF9ob3N0X21hcHBpbmcoCj4+ICAgICAgICAgIGlmICggIW5ld19hZGRyICkK Pj4gICAgICAgICAgICAgIHJldHVybiBkZXN0cm95X2dyYW50X3B0ZV9tYXBwaW5nKGFkZHIsIGZy YW1lLCBjdXJyLT5kb21haW4pOwo+PiAgICAgICAgICAKPj4gLSAgICAgICAgTUVNX0xPRygiVW5z dXBwb3J0ZWQgZ3JhbnQgdGFibGUgb3BlcmF0aW9uIik7Cj4+ICsgICAgICAgIGdkcHJpbnRrKFhF TkxPR19XQVJOSU5HLCAiVW5zdXBwb3J0ZWQgZ3JhbnQgdGFibGUgb3BlcmF0aW9uXG4iKTsKPj4g ICAgICAgICAgcmV0dXJuIEdOVFNUX2dlbmVyYWxfZXJyb3I7Cj4+ICAgICAgfQo+IERyb3AgYWdh aW4/CgpPay4KCj4KPj4gQEAgLTQ0MDgsMTAgKzQ0NjAsMTEgQEAgaW50IGRvbmF0ZV9wYWdlKAo+ PiAgCj4+ICAgZmFpbDoKPj4gICAgICBzcGluX3VubG9jaygmZC0+cGFnZV9hbGxvY19sb2NrKTsK Pj4gLSAgICBNRU1fTE9HKCJCYWQgZG9uYXRlICVseDogZWQ9JWQgc2Q9JWQgY2FmPSUwOGx4IHRh Zj0lIiBQUnR5cGVfaW5mbywKPj4gLSAgICAgICAgICAgIHBhZ2VfdG9fbWZuKHBhZ2UpLCBkLT5k b21haW5faWQsCj4+IC0gICAgICAgICAgICBvd25lciA/IG93bmVyLT5kb21haW5faWQgOiBET01J RF9JTlZBTElELAo+PiAtICAgICAgICAgICAgcGFnZS0+Y291bnRfaW5mbywgcGFnZS0+dS5pbnVz ZS50eXBlX2luZm8pOwo+PiArICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLCAiQmFkIGRvbmF0 ZSBtZm4gJSIgUFJJX21mbgo+PiArICAgICAgICAgICAgICI6IGVkPSVkIHNkPSVkIGNhZj0lMDhs eCB0YWY9JSIgUFJ0eXBlX2luZm8gIlxuIiwKPj4gKyAgICAgICAgICAgICBwYWdlX3RvX21mbihw YWdlKSwgZC0+ZG9tYWluX2lkLAo+PiArICAgICAgICAgICAgIG93bmVyID8gb3duZXItPmRvbWFp bl9pZCA6IERPTUlEX0lOVkFMSUQsCj4+ICsgICAgICAgICAgICAgcGFnZS0+Y291bnRfaW5mbywg cGFnZS0+dS5pbnVzZS50eXBlX2luZm8pOwo+IFdoeSBkaWQgeW91IG5vdCB1c2UgZCVkIGZvcm1h dHRpbmcgaGVyZT8KCkFuIG92ZXJzaWdodC4KCj4KPj4gQEAgLTQ0NTksMTAgKzQ1MTIsMTEgQEAg aW50IHN0ZWFsX3BhZ2UoCj4+ICAKPj4gICBmYWlsOgo+PiAgICAgIHNwaW5fdW5sb2NrKCZkLT5w YWdlX2FsbG9jX2xvY2spOwo+PiAtICAgIE1FTV9MT0coIkJhZCBwYWdlICVseDogZWQ9JWQgc2Q9 JWQgY2FmPSUwOGx4IHRhZj0lIiBQUnR5cGVfaW5mbywKPj4gLSAgICAgICAgICAgIHBhZ2VfdG9f bWZuKHBhZ2UpLCBkLT5kb21haW5faWQsCj4+IC0gICAgICAgICAgICBvd25lciA/IG93bmVyLT5k b21haW5faWQgOiBET01JRF9JTlZBTElELAo+PiAtICAgICAgICAgICAgcGFnZS0+Y291bnRfaW5m bywgcGFnZS0+dS5pbnVzZS50eXBlX2luZm8pOwo+PiArICAgIGdkcHJpbnRrKFhFTkxPR19XQVJO SU5HLCAiQmFkIG1mbiAlIiBQUklfbWZuCj4+ICsgICAgICAgICAgICAgIjogZWQ9JWQgc2Q9JWQg Y2FmPSUwOGx4IHRhZj0lIiBQUnR5cGVfaW5mbyAiXG4iLAo+PiArICAgICAgICAgICAgIHBhZ2Vf dG9fbWZuKHBhZ2UpLCBkLT5kb21haW5faWQsCj4+ICsgICAgICAgICAgICAgb3duZXIgPyBvd25l ci0+ZG9tYWluX2lkIDogRE9NSURfSU5WQUxJRCwKPj4gKyAgICAgICAgICAgICBwYWdlLT5jb3Vu dF9pbmZvLCBwYWdlLT51LmludXNlLnR5cGVfaW5mbyk7Cj4gU2FtZSBoZXJlLgo+Cj4gSXMgdGhp cyBpbnRlbmRlZCBmb3IgNC45PwoKQXQgdGhpcyBwb2ludCwgeWVzLgoKfkFuZHJldwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==