From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtprelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E805D259E for ; Sat, 3 Apr 2021 02:53:09 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id C4630184952FE for ; Fri, 2 Apr 2021 18:37:28 +0000 (UTC) Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 18B551848AB32; Fri, 2 Apr 2021 18:37:22 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id E522F1E04D5; Fri, 2 Apr 2021 18:37:20 +0000 (UTC) Message-ID: <906c8d899a3840afab1e624736b44292eacc6c97.camel@perches.com> Subject: Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c From: Joe Perches To: Fabio Aiuto Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Fri, 02 Apr 2021 11:37:17 -0700 In-Reply-To: <20210402174003.GA1399@agape.jhs> References: <34bf6cdc7bdf5c64d47cb3525897970644de7052.1617356821.git.fabioaiuto83@gmail.com> <2014e0fc141d73d907c781ca31c822c96d3a7c47.camel@perches.com> <20210402125127.GB1420@agape.jhs> <20210402174003.GA1399@agape.jhs> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: E522F1E04D5 X-Spam-Status: No, score=0.10 X-Stat-Signature: naiaqt4b5fn5f7fstamd8n9znom8idsy X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/uc4cr6ntvwUF+AwVVlcVSiEqG4XhPtCI= X-HE-Tag: 1617388640-394859 On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote: > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote: > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote: > > > On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > > > > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > > > > > remove all RT_TRACE logs > > > > > > > > > > fix patch-related checkpatch issues [] > > > > Lastly, another suggestion would be to just submit a single patch > > > > removing _ALL_ the RT_TRACE uses not intermixing various other cleanups > > > > with the series and then do those other cleanups. > > > > > > > > Using a coccinelle script like: > > > > > > > > $ cat RT_TRACE.cocci > > > > @@ > > > > expression a, b, c; > > > > @@ > > > > > > > > - RT_TRACE(a, b, (c)); > > > > > > > > $ spatch -sp-file RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > > > > > > And then clean up the various bits you think are inappropriately done. [] > > > thank you Joe, I tried with (RT_TRACE.cocci in parent folder) > > > > > > user@host:~/src/git/kernels/staging$ spatch -sp-file ../RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h > > > 0 files match > > > > Likely you are running the script on the tree after you have > > applied all your patches. > > > > Try running the cocci script on a fresh copy of -next. > > > > Using the script and adding the script in the commit message helps > > others to verify that the changes you make do not have any other effect. > > > > $ cat RT_TRACE.cocci > > @@ > > expression a, b, c; > > @@ > > > > - RT_TRACE(a, b, (c)); > > > > $ git checkout next-20210401 > > $ spatch -sp-file RT_TRACE.cocci --in-place --no-show-diff --very-quiet drivers/staging/rtl8723bs/ > > 31 files match > > $ git diff --stat -p > >  drivers/staging/rtl8723bs/core/rtw_cmd.c | 34 +------ [] > >  28 files changed, 19 insertions(+), 935 deletions(-) [] > thank you Joe, this mail is so precious ;) I'm not quite sure what you mean by that but you quoted nearly 200k of the previous email. Please remember to trim your replies. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F6EC433B4 for ; Fri, 2 Apr 2021 18:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA22661165 for ; Fri, 2 Apr 2021 18:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234996AbhDBSh1 (ORCPT ); Fri, 2 Apr 2021 14:37:27 -0400 Received: from smtprelay0035.hostedemail.com ([216.40.44.35]:48604 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229647AbhDBShY (ORCPT ); Fri, 2 Apr 2021 14:37:24 -0400 Received: from omf09.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 18B551848AB32; Fri, 2 Apr 2021 18:37:22 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA id E522F1E04D5; Fri, 2 Apr 2021 18:37:20 +0000 (UTC) Message-ID: <906c8d899a3840afab1e624736b44292eacc6c97.camel@perches.com> Subject: Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c From: Joe Perches To: Fabio Aiuto Cc: gregkh@linuxfoundation.org, dan.carpenter@oracle.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Date: Fri, 02 Apr 2021 11:37:17 -0700 In-Reply-To: <20210402174003.GA1399@agape.jhs> References: <34bf6cdc7bdf5c64d47cb3525897970644de7052.1617356821.git.fabioaiuto83@gmail.com> <2014e0fc141d73d907c781ca31c822c96d3a7c47.camel@perches.com> <20210402125127.GB1420@agape.jhs> <20210402174003.GA1399@agape.jhs> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: E522F1E04D5 X-Stat-Signature: naiaqt4b5fn5f7fstamd8n9znom8idsy X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/uc4cr6ntvwUF+AwVVlcVSiEqG4XhPtCI= X-HE-Tag: 1617388640-394859 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote: > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote: > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote: > > > On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > > > > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > > > > > remove all RT_TRACE logs > > > > > > > > > > fix patch-related checkpatch issues [] > > > > Lastly, another suggestion would be to just submit a single patch > > > > removing _ALL_ the RT_TRACE uses not intermixing various other cleanups > > > > with the series and then do those other cleanups. > > > > > > > > Using a coccinelle script like: > > > > > > > > $ cat RT_TRACE.cocci > > > > @@ > > > > expression a, b, c; > > > > @@ > > > > > > > > - RT_TRACE(a, b, (c)); > > > > > > > > $ spatch -sp-file RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > > > > > > And then clean up the various bits you think are inappropriately done. [] > > > thank you Joe, I tried with (RT_TRACE.cocci in parent folder) > > > > > > user@host:~/src/git/kernels/staging$ spatch -sp-file ../RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h > > > 0 files match > > > > Likely you are running the script on the tree after you have > > applied all your patches. > > > > Try running the cocci script on a fresh copy of -next. > > > > Using the script and adding the script in the commit message helps > > others to verify that the changes you make do not have any other effect. > > > > $ cat RT_TRACE.cocci > > @@ > > expression a, b, c; > > @@ > > > > - RT_TRACE(a, b, (c)); > > > > $ git checkout next-20210401 > > $ spatch -sp-file RT_TRACE.cocci --in-place --no-show-diff --very-quiet drivers/staging/rtl8723bs/ > > 31 files match > > $ git diff --stat -p > >  drivers/staging/rtl8723bs/core/rtw_cmd.c | 34 +------ [] > >  28 files changed, 19 insertions(+), 935 deletions(-) [] > thank you Joe, this mail is so precious ;) I'm not quite sure what you mean by that but you quoted nearly 200k of the previous email. Please remember to trim your replies.