From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D914C2BB55 for ; Tue, 7 Apr 2020 10:19:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2E9720731 for ; Tue, 7 Apr 2020 10:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgDGKT5 (ORCPT ); Tue, 7 Apr 2020 06:19:57 -0400 Received: from foss.arm.com ([217.140.110.172]:54460 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbgDGKT5 (ORCPT ); Tue, 7 Apr 2020 06:19:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC2CC1FB; Tue, 7 Apr 2020 03:19:56 -0700 (PDT) Received: from [10.37.12.154] (unknown [10.37.12.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10FA63F73D; Tue, 7 Apr 2020 03:19:54 -0700 (PDT) Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections To: saiprakash.ranjan@codeaurora.org, mike.leach@linaro.org Cc: mathieu.poirier@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, swboyd@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20200405102819.28460-1-saiprakash.ranjan@codeaurora.org> <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> From: Suzuki K Poulose Message-ID: <906d374d-a4d6-f2f2-6845-88b97a5ff7d9@arm.com> Date: Tue, 7 Apr 2020 11:24:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04/07/2020 10:46 AM, Sai Prakash Ranjan wrote: > Hi Mike, > > Thanks for taking a look. > > On 2020-04-06 16:25, Mike Leach wrote: >> Hi, >> >> The programmable replicator hardware by design enables trace through >> both ports on reset. (see 1, section 4.4, 9.11)  The replicator driver >> overrides this functionality to disable output, until the Coresight >> infrastructure chooses a path from source to sink. >> Now given that the hardware design is such that we must be able to >> allow trace to be sent to both ports, a generic patch to prevent this >> does not seem appropriate here. >> >> I think this needs further investigation - to determine why this >> appears to be failing in this particular instance. >> > > Yes, this probably needs further investigation, but CPU hardlock stack > trace doesnt help much. I could always trigger this hard lockup without > this patch on SC7180 SoC and this is only seen when ETR is used as the > sink. > > The only difference I could see between non working case (on SC7180 [1]) > and > the working case (on SDM845 [2]) is the path from source to sink. > > SC7180 source to sink path(Not working): > ---------------------------------------- > >       etm0_out >      | >   apss_funnel_in0 >          | >  apss_merge_funnel_in >          | >      funnel1_in4 >      | >   merge_funnel_in1 >      | >    swao_funnel_in >          | >        etf_in >      | >  swao_replicator_in >          | >   replicator_in >      | >        etr_in There seems to be two replicators back to back here. What is connected to the other output of both of them ? Are there any TPIUs ? What happens if you choose a sink on the other end of "swao_replicator" (ETB ?) After boot, what do the idfilter registers read for both the replicators ? I believe we need to properly assign the TRACE_IDs for tracing sessions, (rather than static ids) in a way such that we could filter them and use the multiple sinks in parallel for separate trace sessions and this is not simple (involves kernel driver changes and the perf tool to be able to decode the trace id changes too). So for the moment, we need to : 1) Disallow turning the replicator ON, when it is already turned ON 2) Do what your patch does. i.e, disable the other end while one end is turned on. Thoughts ? Kind regards Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0E4C2BB54 for ; Tue, 7 Apr 2020 10:20:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2ABA20644 for ; Tue, 7 Apr 2020 10:20:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LBr4bGMS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2ABA20644 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EbPb9cLZYVnsO3YAkoCLbXkBVeDXSddfCngKsCpabKI=; b=LBr4bGMSexcjWhhRl6rdhEjLm RnYosctUA8qbDSU8aC0IvckK0Tu/0FeeGSwVIxzFNe1ln8YDfjeBw8m3XWzvANsn7dxT3QAFbv5z7 dL62dfYpda4wO9ZWbyZFv+gLrxjyyhs017sKvJmDdopHKzaUaiLVTSA86AAmN7+nAhhekeZK0a2pc xJogZviRG+ztkrX0SY2MJpSQlzVU+sUeJgeUgvg17XsnjGlV0YKUkPO4LQyik+iV4QRKvhdf41UHJ HevZdNGZyaJDBkxxczg3k/OJU2E0jUPCZ2hglqL4spJUEKnIsAEUKiI+CaORHHdFdIy9+z7Bspztq eXu0P4y6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLlKt-00024k-87; Tue, 07 Apr 2020 10:20:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLlKq-0001wu-1A for linux-arm-kernel@lists.infradead.org; Tue, 07 Apr 2020 10:20:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CC2CC1FB; Tue, 7 Apr 2020 03:19:56 -0700 (PDT) Received: from [10.37.12.154] (unknown [10.37.12.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 10FA63F73D; Tue, 7 Apr 2020 03:19:54 -0700 (PDT) Subject: Re: [RFC PATCH] coresight: dynamic-replicator: Fix handling of multiple connections To: saiprakash.ranjan@codeaurora.org, mike.leach@linaro.org References: <20200405102819.28460-1-saiprakash.ranjan@codeaurora.org> <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> From: Suzuki K Poulose Message-ID: <906d374d-a4d6-f2f2-6845-88b97a5ff7d9@arm.com> Date: Tue, 7 Apr 2020 11:24:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6c0f45488f8a44bf860759e00fcabd09@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_032000_117045_AEFCB5F2 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDQvMDcvMjAyMCAxMDo0NiBBTSwgU2FpIFByYWthc2ggUmFuamFuIHdyb3RlOgo+IEhpIE1p a2UsCj4gCj4gVGhhbmtzIGZvciB0YWtpbmcgYSBsb29rLgo+IAo+IE9uIDIwMjAtMDQtMDYgMTY6 MjUsIE1pa2UgTGVhY2ggd3JvdGU6Cj4+IEhpLAo+Pgo+PiBUaGUgcHJvZ3JhbW1hYmxlIHJlcGxp Y2F0b3IgaGFyZHdhcmUgYnkgZGVzaWduIGVuYWJsZXMgdHJhY2UgdGhyb3VnaAo+PiBib3RoIHBv cnRzIG9uIHJlc2V0LiAoc2VlIDEsIHNlY3Rpb24gNC40LCA5LjExKcKgIFRoZSByZXBsaWNhdG9y IGRyaXZlcgo+PiBvdmVycmlkZXMgdGhpcyBmdW5jdGlvbmFsaXR5IHRvIGRpc2FibGUgb3V0cHV0 LCB1bnRpbCB0aGUgQ29yZXNpZ2h0Cj4+IGluZnJhc3RydWN0dXJlIGNob29zZXMgYSBwYXRoIGZy b20gc291cmNlIHRvIHNpbmsuCj4+IE5vdyBnaXZlbiB0aGF0IHRoZSBoYXJkd2FyZSBkZXNpZ24g aXMgc3VjaCB0aGF0IHdlIG11c3QgYmUgYWJsZSB0bwo+PiBhbGxvdyB0cmFjZSB0byBiZSBzZW50 IHRvIGJvdGggcG9ydHMsIGEgZ2VuZXJpYyBwYXRjaCB0byBwcmV2ZW50IHRoaXMKPj4gZG9lcyBu b3Qgc2VlbSBhcHByb3ByaWF0ZSBoZXJlLgo+Pgo+PiBJIHRoaW5rIHRoaXMgbmVlZHMgZnVydGhl ciBpbnZlc3RpZ2F0aW9uIC0gdG8gZGV0ZXJtaW5lIHdoeSB0aGlzCj4+IGFwcGVhcnMgdG8gYmUg ZmFpbGluZyBpbiB0aGlzIHBhcnRpY3VsYXIgaW5zdGFuY2UuCj4+Cj4gCj4gWWVzLCB0aGlzIHBy b2JhYmx5IG5lZWRzIGZ1cnRoZXIgaW52ZXN0aWdhdGlvbiwgYnV0IENQVSBoYXJkbG9jayBzdGFj awo+IHRyYWNlIGRvZXNudCBoZWxwIG11Y2guIEkgY291bGQgYWx3YXlzIHRyaWdnZXIgdGhpcyBo YXJkIGxvY2t1cCB3aXRob3V0Cj4gdGhpcyBwYXRjaCBvbiBTQzcxODAgU29DIGFuZCB0aGlzIGlz IG9ubHkgc2VlbiB3aGVuIEVUUiBpcyB1c2VkIGFzIHRoZSAKPiBzaW5rLgo+IAo+IFRoZSBvbmx5 IGRpZmZlcmVuY2UgSSBjb3VsZCBzZWUgYmV0d2VlbiBub24gd29ya2luZyBjYXNlIChvbiBTQzcx ODAgWzFdKSAKPiBhbmQKPiB0aGUgd29ya2luZyBjYXNlIChvbiBTRE04NDUgWzJdKSBpcyB0aGUg cGF0aCBmcm9tIHNvdXJjZSB0byBzaW5rLgoKCj4gCj4gU0M3MTgwIHNvdXJjZSB0byBzaW5rIHBh dGgoTm90IHdvcmtpbmcpOgo+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAKPiAgwqDCoMKgwqDCoCBldG0wX291dAo+ICDCoMKgwqDCoCB8Cj4gIMKgIGFwc3NfZnVu bmVsX2luMAo+ICDCoMKgwqDCoMKgwqDCoMKgIHwKPiAgwqBhcHNzX21lcmdlX2Z1bm5lbF9pbgo+ ICDCoMKgwqDCoMKgwqDCoMKgIHwKPiAgwqDCoMKgwqAgZnVubmVsMV9pbjQKPiAgwqDCoMKgwqAg fAo+ICDCoCBtZXJnZV9mdW5uZWxfaW4xCj4gIMKgwqDCoMKgIHwKPiAgwqDCoCBzd2FvX2Z1bm5l bF9pbgo+ICDCoMKgwqDCoMKgwqDCoMKgIHwKPiAgwqDCoMKgwqDCoMKgIGV0Zl9pbgo+ICDCoMKg wqDCoCB8Cj4gIMKgc3dhb19yZXBsaWNhdG9yX2luCj4gIMKgwqDCoMKgwqDCoMKgwqAgfAo+ICDC oCByZXBsaWNhdG9yX2luCj4gIMKgwqDCoMKgIHwKPiAgwqDCoMKgwqDCoMKgIGV0cl9pbgoKClRo ZXJlIHNlZW1zIHRvIGJlIHR3byByZXBsaWNhdG9ycyBiYWNrIHRvIGJhY2sgaGVyZS4gV2hhdCBp cyBjb25uZWN0ZWQKdG8gdGhlIG90aGVyIG91dHB1dCBvZiBib3RoIG9mIHRoZW0gPyBBcmUgdGhl cmUgYW55IFRQSVVzID8gV2hhdCBoYXBwZW5zCmlmIHlvdSBjaG9vc2UgYSBzaW5rIG9uIHRoZSBv dGhlciBlbmQgb2YgInN3YW9fcmVwbGljYXRvciIgKEVUQiA/KQoKQWZ0ZXIgYm9vdCwgd2hhdCBk byB0aGUgaWRmaWx0ZXIgcmVnaXN0ZXJzIHJlYWQgZm9yIGJvdGggdGhlIHJlcGxpY2F0b3JzID8K CgpJIGJlbGlldmUgd2UgbmVlZCB0byBwcm9wZXJseSBhc3NpZ24gdGhlIFRSQUNFX0lEcyBmb3Ig dHJhY2luZyBzZXNzaW9ucywKKHJhdGhlciB0aGFuIHN0YXRpYyBpZHMpIGluIGEgd2F5IHN1Y2gg dGhhdCB3ZSBjb3VsZCBmaWx0ZXIgdGhlbSBhbmQgdXNlCnRoZSBtdWx0aXBsZSBzaW5rcyBpbiBw YXJhbGxlbCBmb3Igc2VwYXJhdGUgdHJhY2Ugc2Vzc2lvbnMgYW5kIHRoaXMgaXMKbm90IHNpbXBs ZSAoaW52b2x2ZXMga2VybmVsIGRyaXZlciBjaGFuZ2VzIGFuZCB0aGUgcGVyZiB0b29sIHRvIGJl IGFibGUKdG8gZGVjb2RlIHRoZSB0cmFjZSBpZCBjaGFuZ2VzIHRvbykuCgoKU28gZm9yIHRoZSBt b21lbnQsIHdlIG5lZWQgdG8gOgoKMSkgRGlzYWxsb3cgdHVybmluZyB0aGUgcmVwbGljYXRvciBP Tiwgd2hlbiBpdCBpcyBhbHJlYWR5IHR1cm5lZCBPTgoyKSBEbyB3aGF0IHlvdXIgcGF0Y2ggZG9l cy4gaS5lLCBkaXNhYmxlIHRoZSBvdGhlciBlbmQgd2hpbGUgb25lIGVuZAogICAgaXMgdHVybmVk IG9uLgoKVGhvdWdodHMgPwoKS2luZCByZWdhcmRzClN1enVraQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=