All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naoki Hayama <naoki.hayama@lineo.co.jp>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] cosmetic: image: Fix comments and the order of definitions
Date: Wed, 7 Oct 2020 11:22:24 +0900	[thread overview]
Message-ID: <906da5f1-2fc0-de1c-253e-8d4db9f2dd4f@lineo.co.jp> (raw)

Fix some comments about functions.
Move genimg_get_comp_name() above genimg_get_short_name() because
genimg_get_comp_name() is related to get_table_entry_name().

Signed-off-by: Naoki Hayama <naoki.hayama@lineo.co.jp>
---

 common/image.c  | 20 ++++++++++----------
 include/image.h |  1 +
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/common/image.c b/common/image.c
index 4fc4a0f1c4..451fc689a8 100644
--- a/common/image.c
+++ b/common/image.c
@@ -801,14 +801,14 @@ static const char *unknown_msg(enum ih_category category)
 }
 
 /**
- * get_cat_table_entry_name - translate entry id to long name
+ * genimg_get_cat_name - translate entry id to long name
  * @category: category to look up (enum ih_category)
  * @id: entry id to be translated
  *
  * This will scan the translation table trying to find the entry that matches
  * the given id.
  *
- * @retur long entry name if translation succeeds; error string on failure
+ * @return long entry name if translation succeeds; error string on failure
  */
 const char *genimg_get_cat_name(enum ih_category category, uint id)
 {
@@ -825,14 +825,14 @@ const char *genimg_get_cat_name(enum ih_category category, uint id)
 }
 
 /**
- * get_cat_table_entry_short_name - translate entry id to short name
+ * genimg_get_cat_short_name - translate entry id to short name
  * @category: category to look up (enum ih_category)
  * @id: entry id to be translated
  *
  * This will scan the translation table trying to find the entry that matches
  * the given id.
  *
- * @retur short entry name if translation succeeds; error string on failure
+ * @return short entry name if translation succeeds; error string on failure
  */
 const char *genimg_get_cat_short_name(enum ih_category category, uint id)
 {
@@ -918,6 +918,12 @@ const char *genimg_get_type_name(uint8_t type)
 	return (get_table_entry_name(uimage_type, "Unknown Image", type));
 }
 
+const char *genimg_get_comp_name(uint8_t comp)
+{
+	return (get_table_entry_name(uimage_comp, "Unknown Compression",
+					comp));
+}
+
 static const char *genimg_get_short_name(const table_entry_t *table, int val)
 {
 	table = get_table_entry(table, val);
@@ -935,12 +941,6 @@ const char *genimg_get_type_short_name(uint8_t type)
 	return genimg_get_short_name(uimage_type, type);
 }
 
-const char *genimg_get_comp_name(uint8_t comp)
-{
-	return (get_table_entry_name(uimage_comp, "Unknown Compression",
-					comp));
-}
-
 const char *genimg_get_comp_short_name(uint8_t comp)
 {
 	return genimg_get_short_name(uimage_comp, comp);
diff --git a/include/image.h b/include/image.h
index 6222057f27..c91f0512f3 100644
--- a/include/image.h
+++ b/include/image.h
@@ -563,6 +563,7 @@ int genimg_get_cat_count(enum ih_category category);
 /**
  * genimg_get_cat_desc() - Get the description of a category
  *
+ * @category:	Category to check
  * @return the description of a category, e.g. "architecture". This
  * effectively converts the enum to a string.
  */
-- 
2.17.1

             reply	other threads:[~2020-10-07  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  2:22 Naoki Hayama [this message]
2020-10-12  3:34 ` [PATCH 3/3] cosmetic: image: Fix comments and the order of definitions Simon Glass
2020-10-23  0:27 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=906da5f1-2fc0-de1c-253e-8d4db9f2dd4f@lineo.co.jp \
    --to=naoki.hayama@lineo.co.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.