From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDwG6-0002et-OM for qemu-devel@nongnu.org; Wed, 02 May 2018 14:13:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDwG5-00061c-LU for qemu-devel@nongnu.org; Wed, 02 May 2018 14:13:42 -0400 References: <20180421165423.30759-1-mreitz@redhat.com> <20180421165423.30759-8-mreitz@redhat.com> <53a4f279-49cc-7bf3-824a-4cb98fd9590c@redhat.com> From: Max Reitz Message-ID: <906eccc3-dba6-5674-45cd-fa11b4ea25b8@redhat.com> Date: Wed, 2 May 2018 20:13:32 +0200 MIME-Version: 1.0 In-Reply-To: <53a4f279-49cc-7bf3-824a-4cb98fd9590c@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SNrlmnBp8CXQVHCYHtz8aNnIDteUSvjGu" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 7/7] iotests: Rework 113 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SNrlmnBp8CXQVHCYHtz8aNnIDteUSvjGu From: Max Reitz To: John Snow , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org Message-ID: <906eccc3-dba6-5674-45cd-fa11b4ea25b8@redhat.com> Subject: Re: [Qemu-block] [PATCH 7/7] iotests: Rework 113 References: <20180421165423.30759-1-mreitz@redhat.com> <20180421165423.30759-8-mreitz@redhat.com> <53a4f279-49cc-7bf3-824a-4cb98fd9590c@redhat.com> In-Reply-To: <53a4f279-49cc-7bf3-824a-4cb98fd9590c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2018-05-02 20:03, John Snow wrote: >=20 >=20 > On 04/21/2018 12:54 PM, Max Reitz wrote: >> This test case has been broken since 398e6ad014df261d (roughly half a >> year). qemu-img amend requires its output image to be R/W, so it open= s >> it as such; the node is then turned into an read-only node automatical= ly >> which is now accompanied by a warning, however. This warning has not >> been part of the reference output. >> >> For one thing, this warning shows that we cannot keep the test case as= >> it is. We would need a format that has no create_opts but that does >> have write support -- we do not have such a format, though. >> >> Another thing is that qemu now actually checks whether an image format= >> supports amendment instead of whether it has create_opts (since the >> former always implies the latter). So we can now use any format that >> does not support amendment (even if it supports creation) and thus tes= t >> the same code path. >> >> The reason nobody has noticed the breakage until now of course is the >> fact that nobody runs the iotests for nbd+bochs. There actually was >> never any reason to set the protocol to "nbd" but because that was >> technically correct; functionally it made no difference. So that is t= he >> first thing we are going to change: Make the protocol "file" instead s= o >> that people might actually notice breakage here. >> >> Secondly, now that bochs no longer works for the amend test case, we >> have to change the format there anyway. Set let us just bend the trut= h I suppose s/Set/So/ >> a bit, declare this test a raw test. In fact, that does not even >> concern the bochs test cases, other than the output now reading 'bochs= ' >> instead of 'IMGFMT'. >> >> So with this test now being a raw test, we can rework the amend test >> case to use raw instead. >> >> Signed-off-by: Max Reitz >=20 > Well, it passes... Not sure if I'm wild about the format change, it > sounds like a failure of our CI more than something that needed to > change in the test, but... shrug. I think it's not really an issue in the CI. Testing all possible combinations of protocols and formats seems too much to me. I think it really is an issue in our test suite. There are many tests that work only with a single combination (numerous file+qcow2 tests, for instance), so having our great test matrix capability is completely useless for them. Maybe tests should be able to offer a preferred format+protocol (+options) combination? Then, when you run check without any such arguments, it would just run each test in its preferred mode. Max --SNrlmnBp8CXQVHCYHtz8aNnIDteUSvjGu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlrp/8wACgkQ9AfbAGHV z0AktAf/W2GAbmTY+XR33dXHSR8Lj4ddwL9XkNwbotiOAZbAlvMrQiXaJuQ3jQfB CcbkAj0zDYvfWHWwYTWDKyukjENhh3J23IJWTA0DdQdGbcNAn4rGBB4Fftv+V5OQ Q7q5xpGmTA0HDVTxW+MKhQA1RhwWkoURHjO0NG+a1YV4o2U4vQYuobNyrFYmR1Iw dfhgnov+6K4irDGOHUrMXyyETtcISg35hA3HGUJdXsXfXeyDE3KUSmadvupdHGU+ XJBsjuMv2kOKunI9lJcpaEwc2DWqyuJN41DhAqhI+is7jnbfXvlnHGnUOM5QPGhv V1AVye067Ye8ii3R+b0KPByahU3hlA== =9w41 -----END PGP SIGNATURE----- --SNrlmnBp8CXQVHCYHtz8aNnIDteUSvjGu--