From: Bean Huo <huobean@gmail.com>
To: Can Guo <cang@codeaurora.org>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, ziqichen@codeaurora.org,
rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, saravanak@google.com,
salyzyn@google.com
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bart Van Assche <bvanassche@acm.org>,
Satya Tangirala <satyat@google.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref_clk
Date: Tue, 24 Nov 2020 22:09:18 +0100 [thread overview]
Message-ID: <9070660d115dd96c70bc3cc90d5c7dab833f36a8.camel@gmail.com> (raw)
In-Reply-To: <1606202906-14485-2-git-send-email-cang@codeaurora.org>
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -229,6 +229,8 @@ struct ufs_dev_cmd {
> * @max_freq: maximum frequency supported by the clock
> * @min_freq: min frequency that can be used for clock scaling
> * @curr_freq: indicates the current frequency that it is set to
> + * @always_on_while_link_active: indicate that the clk should not be
> disabled if
> + link is still active
> * @enabled: variable to check against multiple enable/disable
> */
> struct ufs_clk_info {
> @@ -238,6 +240,7 @@ struct ufs_clk_info {
> u32 max_freq;
> u32 min_freq;
> u32 curr_freq;
> + bool always_on_while_link_active;
Can,
using a sentence as a parameter name looks a little bit clumsy to me.
The meaning has been explained in the comments section. How about
simplify it and in line with other parameters in the structure?
Thanks,
Bean
> bool enabled;
> };
>
next prev parent reply other threads:[~2020-11-24 21:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 7:28 [PATCH v2 0/2] Refector ufshcd_setup_clocks() to remove param skip_ref_clk Can Guo
2020-11-24 7:28 ` [PATCH v2 1/2] scsi: ufs: Refector ufshcd_setup_clocks() to remove skip_ref_clk Can Guo
2020-11-24 21:09 ` Bean Huo [this message]
2020-11-25 0:53 ` Can Guo
2020-11-25 2:01 ` hongwus
2020-11-25 11:54 ` Bean Huo
2020-11-25 12:28 ` Can Guo
2020-11-25 19:02 ` Bean Huo
2020-11-26 1:45 ` Can Guo
2020-11-26 0:58 ` Stanley Chu
2020-11-26 1:25 ` Can Guo
2020-11-24 7:28 ` [PATCH v2 2/2] scsi: ufs-qcom: Keep core_clk_unipro ON while link is active Can Guo
2020-11-25 2:02 ` hongwus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9070660d115dd96c70bc3cc90d5c7dab833f36a8.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=satyat@google.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
--cc=ziqichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.