From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Petersson, Mats" <Mats.Petersson@amd.com>
Subject: RE: hvm_init_ap_contexts
Date: Thu, 1 Mar 2007 17:49:41 +0100
Message-ID: <907625E08839C4409CE5768403633E0B018E1A00@sefsexmb1.amd.com>
References: <45E70280.8090208@cea.fr>
Mime-Version: 1.0
Content-Type: text/plain;
 charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-class: urn:content-classes:message
In-Reply-To: <45E70280.8090208@cea.fr>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: PUCCETTI Armand <armand.puccetti@cea.fr>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

=20

> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com=20
> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of=20
> PUCCETTI Armand
> Sent: 01 March 2007 16:43
> To: xen-devel@lists.xensource.com
> Subject: [Xen-devel] hvm_init_ap_contexts
>=20
> Why is there an argument returned in the function below (of hvm.h),=20
> knowing that there is void?
>=20
> static inline void
> hvm_init_ap_context(struct vcpu_guest_context *ctxt,
>                    int vcpuid, int trampoline_vector)
> {
>    return hvm_funcs.init_ap_context(ctxt, vcpuid, trampoline_vector);
> }

Seems broken (or rather "unnecessar and confusing" to me - fancy
submitting a fix?

>>From what I can tell, this has been "broken" for quite some time, and as
of about 2000 changesets, the return-type of that function hasn't
changed.=20

--
Mats
>=20
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>=20
>=20
>=20