From: "Petersson, Mats" <Mats.Petersson@amd.com>
To: Keir Fraser <keir@xensource.com>,
PUCCETTI Armand <armand.puccetti@cea.fr>,
xen-devel@lists.xensource.com
Subject: RE: hvm_init_ap_contexts
Date: Thu, 1 Mar 2007 18:25:41 +0100 [thread overview]
Message-ID: <907625E08839C4409CE5768403633E0B018E1A01@sefsexmb1.amd.com> (raw)
In-Reply-To: <C20CB70C.A6F4%keir@xensource.com>
> -----Original Message-----
> From: xen-devel-bounces@lists.xensource.com
> [mailto:xen-devel-bounces@lists.xensource.com] On Behalf Of
> Keir Fraser
> Sent: 01 March 2007 17:00
> To: PUCCETTI Armand; xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] hvm_init_ap_contexts
>
> The return keyword is pointless here, but allowed.
Agreed - but removing the return keyword would make sure that someone
looking at the code doesn't try to figure out what is being returned by
the original function - and since there's nothing being returned, not
using a return keyword makes the code "clearer".
My personal opinion, of course.
--
Mats
>
> -- Keir
>
> On 1/3/07 16:42, "PUCCETTI Armand" <armand.puccetti@cea.fr> wrote:
>
> > Why is there an argument returned in the function below (of hvm.h),
> > knowing that there is void?
> >
> > static inline void
> > hvm_init_ap_context(struct vcpu_guest_context *ctxt,
> > int vcpuid, int trampoline_vector)
> > {
> > return hvm_funcs.init_ap_context(ctxt, vcpuid,
> trampoline_vector);
> > }
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
>
next prev parent reply other threads:[~2007-03-01 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 16:42 hvm_init_ap_contexts PUCCETTI Armand
2007-03-01 16:49 ` hvm_init_ap_contexts Petersson, Mats
2007-03-01 16:59 ` hvm_init_ap_contexts Keir Fraser
2007-03-01 17:25 ` Petersson, Mats [this message]
2007-03-12 6:56 ` question about the poll_timer tgh
2007-03-12 7:08 ` Atsushi SAKAI
2007-03-12 7:29 ` tgh
2007-03-13 17:00 ` Mark Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907625E08839C4409CE5768403633E0B018E1A01@sefsexmb1.amd.com \
--to=mats.petersson@amd.com \
--cc=armand.puccetti@cea.fr \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.