From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eugene Syromiatnikov <esyr@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Ursula Braun <ubraun@linux.ibm.com>,
Karsten Graul <kgraul@linux.ibm.com>,
Hans Wippel <hwippel@linux.ibm.com>
Subject: Re: [PATCH net 2/2] net/smc: retain old name for diag_mode field
Date: Sun, 7 Oct 2018 11:34:20 +0300 [thread overview]
Message-ID: <9081dc32-8d5e-df78-7570-93862ac1f9f1@cogentembedded.com> (raw)
In-Reply-To: <20181006203226.GA11438@asgard.redhat.com>
On 10/6/2018 11:32 PM, Eugene Syromiatnikov wrote:
> Commit v4.19-rc1~140^2~285^2~4 changed the name of diag_fallback field
The commit citing style should be the same as in the "Fixes:" tag.
> of struct smc_diag_msg structure to diag_mode. However, this structure
> is a part of UAPI, and this change breaks user space applications that
> use it ([1], for example). Since the new name is more suitable, convert
> the field to a union that provides access to the data via both the new
> and the old name.
>
> [1] https://gitlab.com/strace/strace/blob/v4.24/netlink_smc_diag.c#L165
>
> Fixes: c601171d7a60 ("net/smc: provide smc mode in smc_diag.c")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2018-10-07 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 20:32 [PATCH net 2/2] net/smc: retain old name for diag_mode field Eugene Syromiatnikov
2018-10-07 8:34 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9081dc32-8d5e-df78-7570-93862ac1f9f1@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=esyr@redhat.com \
--cc=hwippel@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.