From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757256AbcIPCKe (ORCPT ); Thu, 15 Sep 2016 22:10:34 -0400 Received: from mail-yw0-f180.google.com ([209.85.161.180]:33661 "EHLO mail-yw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755175AbcIPCKZ (ORCPT ); Thu, 15 Sep 2016 22:10:25 -0400 Subject: Re: [PATCH -next] staging: android: ion: Fix return value check in hi6220_ion_probe() To: Wei Yongjun , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, bhaktipriya96@gmail.com, yudongbin@hisilicon.com, puck.chen@hisilicon.com References: <1473906043-28683-1-git-send-email-weiyj.lk@gmail.com> Cc: Wei Yongjun , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: <9086e07b-ba40-545f-fbc2-8950d973929f@redhat.com> Date: Thu, 15 Sep 2016 19:10:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473906043-28683-1-git-send-email-weiyj.lk@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 07:20 PM, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function ion_device_create() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > Acked-by: Laura Abbott > Signed-off-by: Wei Yongjun > --- > drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > index f392db2..659aa71 100644 > --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c > +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c > @@ -49,8 +49,8 @@ static int hi6220_ion_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, ipdev); > > ipdev->idev = ion_device_create(NULL); > - if (!ipdev->idev) > - return -ENOMEM; > + if (IS_ERR(ipdev->idev)) > + return PTR_ERR(ipdev->idev); > > ipdev->data = ion_parse_dt(pdev, hisi_heaps); > if (IS_ERR(ipdev->data)) > > >