From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CF9C07E96 for ; Thu, 8 Jul 2021 17:33:34 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45CC061876 for ; Thu, 8 Jul 2021 17:33:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45CC061876 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.153246.283126 (Exim 4.92) (envelope-from ) id 1m1Xtu-0006EP-E3; Thu, 08 Jul 2021 17:33:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 153246.283126; Thu, 08 Jul 2021 17:33:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m1Xtu-0006EI-BE; Thu, 08 Jul 2021 17:33:26 +0000 Received: by outflank-mailman (input) for mailman id 153246; Thu, 08 Jul 2021 17:33:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m1Xtt-0006E9-Hp for xen-devel@lists.xenproject.org; Thu, 08 Jul 2021 17:33:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m1Xtr-0003KO-Pm; Thu, 08 Jul 2021 17:33:23 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m1Xtr-0000Q6-KL; Thu, 08 Jul 2021 17:33:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=51iGEuNXJe1hlr2Lc2A1XK7pk3Aj8iC55h1SiwtAQfw=; b=GE+McHv2IKBydAZ4hJteZ7pxk2 1F4QK5598zVwxFiEwG5eS37y2a3RTkrbrL14Vyqz0v/9++KZT6HsxKZGVNxAyncE6hGnC73KSXXiK XEZ3Gd6emFB1NYmRxXdmd8g2DyuGEjjCe/cKumeFYX0ONMgeF0Qr4H9vFwfbXdCAGhjI=; Subject: Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error To: Costin Lupu , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu References: <84d03c4595428e4ff857dcacc72f6b9c04476849.1623155575.git.costin.lupu@cs.pub.ro> From: Julien Grall Message-ID: <90974b14-4a8d-d9dd-f8e9-65eef692d28a@xen.org> Date: Thu, 8 Jul 2021 18:33:22 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <84d03c4595428e4ff857dcacc72f6b9c04476849.1623155575.git.costin.lupu@cs.pub.ro> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: > If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h > header) then gcc will trigger a redefinition error because of -Werror. This > patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid > confusion between control domain page granularity (PAGE_* definitions) and > guest domain page granularity. > > The exception is in osdep_xenforeignmemory_map() where we need the system page Did you mean osdep_gnttab_grant_map? > size to check whether the PFN array should be allocated with mmap() or with > dynamic allocation. > > Signed-off-by: Costin Lupu Other than the question above: Reviewed-by: Julien Grall Cheers, -- Julien Grall