From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Sachi King <nakato@nakato.io>,
hdegoede@redhat.com, mgross@linux.intel.com, rafael@kernel.org,
lenb@kernel.org, Sanket.Goswami@amd.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for PMC controller
Date: Thu, 7 Oct 2021 15:00:23 -0500 [thread overview]
Message-ID: <909f28e9-245a-df90-52f1-98b0f63a2b3a@amd.com> (raw)
In-Reply-To: <3ecd9046-ad0c-9c9a-9b09-bbab2f94b9f2@amd.com>
+Sanket Goswami
On 10/5/2021 00:16, Shyam Sundar S K wrote:
>
>
> On 10/2/2021 9:48 AM, Sachi King wrote:
>> The Surface Laptop 4 AMD has used the AMD0005 to identify this
>> controller instead of using the appropriate ACPI ID AMDI0005. Include
>> AMD0005 in the acpi id list.
>
> Can you provide an ACPI dump and output of 'cat /sys/power/mem_sleep'
>
> Thanks,
> Shyam
>
I had a look through the acpidump listed there and it seems like the PEP
device is filled with a lot of NO-OP type of code. This means the LPS0
patch really isn't "needed", but still may be a good idea to include for
completeness in case there ends up being a design based upon this that
does need it.
As for this one (the amd-pmc patch) how are things working with it?
Have you checked power consumption and verified that the amd_pmc debugfs
statistics are increasing? Is the system able to resume from s2idle?
Does pinctrl-amd load on this system? It seems to me that the power
button GPIO doesn't get used like normally on "regular" UEFI based AMD
systems. I do see MSHW0040 so this is probably supported by
surfacepro3-button and that will probably service all the important events.
next prev parent reply other threads:[~2021-10-07 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 4:18 [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for PMC controller Sachi King
2021-10-02 4:18 ` [PATCH 2/2] ACPI: PM: Include alternate AMDI0005 id in special behaviour Sachi King
2021-10-08 18:57 ` Limonciello, Mario
2021-10-11 13:47 ` Hans de Goede
2021-10-12 14:01 ` Rafael J. Wysocki
2021-10-05 5:16 ` [PATCH 1/2] platform/x86: amd-pmc: Add alternative acpi id for PMC controller Shyam Sundar S K
2021-10-05 7:09 ` Sachi King
2021-10-07 20:00 ` Limonciello, Mario [this message]
2021-10-08 10:27 ` Shyam Sundar S K
2021-10-08 12:19 ` Sachi King
2021-10-08 15:57 ` Limonciello, Mario
2021-10-08 19:01 ` Limonciello, Mario
2021-10-09 2:05 ` Sachi King
2021-10-11 13:48 ` Hans de Goede
2021-10-11 13:46 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=909f28e9-245a-df90-52f1-98b0f63a2b3a@amd.com \
--to=mario.limonciello@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=nakato@nakato.io \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.