From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45EDC2B9F4 for ; Fri, 25 Jun 2021 07:53:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5753C613C0 for ; Fri, 25 Jun 2021 07:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5753C613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwgeT-0006WS-9x for qemu-devel@archiver.kernel.org; Fri, 25 Jun 2021 03:53:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwgdo-0005jU-3t for qemu-devel@nongnu.org; Fri, 25 Jun 2021 03:52:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwgdl-0005f9-Ow for qemu-devel@nongnu.org; Fri, 25 Jun 2021 03:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624607560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jn8hkH5HCvV2P2qC2chvpKEmitrXo6WW+CJAcQti6s4=; b=Y+U9U9iG1LfQrP0QegXPrwPwNaeBbjhnvLZzoyT2YUEoDyKycsjWp36QmnQMen1sm6sNc3 zqk8MUqrqhEf2iD/eYd/fx4EmM8LflqwnOBk2kgiudLi+CGIoBFLBkqhF3Po20vqKXpD1K jbRTWrXkBHx6lLzsDk7YYLGLLLQEAbc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-f5TGqlYxMxGvYC24ajkGWg-1; Fri, 25 Jun 2021 03:52:39 -0400 X-MC-Unique: f5TGqlYxMxGvYC24ajkGWg-1 Received: by mail-ed1-f70.google.com with SMTP id w1-20020aa7da410000b029039533674a84so53931eds.9 for ; Fri, 25 Jun 2021 00:52:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Jn8hkH5HCvV2P2qC2chvpKEmitrXo6WW+CJAcQti6s4=; b=OU8NNTP4T7FdMgNVJgV+Ry6Z5bmF7S4Y+40m7m6Sdoopq0k69LLpSrY4GQyh8vefJF vozzjQXrwADxCfNTodRAdxuT0cTwV+7AbPKg8edM3pFGFs5VKN1GPxV7/G9AGYUHVhgN YOHzYiYzjnXgxN7/lNb6NsMX4aSvjzaRu3Yf/oN1/iEuLCmwooLRKVMCD7UIGqbxMAnv lL1kkga9VfBAH702J2a72r8vjdxS7f/aayoNp1rEl27FzQdcOawdDGsyFjMAVN9tyJpz a7McMO8mRYm5wRh9y+l5R4oDw3Q9fLkb0ubqTzyEyQVkGt0jA1Bdr/99JzZPQ9f0eAiY QTGg== X-Gm-Message-State: AOAM530NQVXcd5kN1J3Dcq4KkNX5USC6XPAQKqW0berthyju4UdQf8rq tWI/cbIhIgTz3dTF1QeH6sQihDbanIQUM4kZnvDjChl0YBcsUlsB7pgaIRa3SdGvNm8pydYrO3d IgXE5c2eDD+2n6Ak= X-Received: by 2002:a50:eb8c:: with SMTP id y12mr12726119edr.189.1624607558125; Fri, 25 Jun 2021 00:52:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDYjDN0J4/Xlu1cxcNIDeHEAddoNcUBa47pSGlOGi70mSS9lmzQLJ36AIWjqGDkPF6pJ4W8A== X-Received: by 2002:a50:eb8c:: with SMTP id y12mr12726103edr.189.1624607557974; Fri, 25 Jun 2021 00:52:37 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e46:160:b272:8083:d5:bc7d]) by smtp.gmail.com with ESMTPSA id dd15sm3417978edb.45.2021.06.25.00.52.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 00:52:37 -0700 (PDT) Subject: Re: [PATCH 04/11] block-backend: align max_transfer to request alignment To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210624180423.1322165-1-pbonzini@redhat.com> <20210624180423.1322165-5-pbonzini@redhat.com> From: Max Reitz Message-ID: <90a7ba21-6039-ee89-e4fe-04d86b6b19e7@redhat.com> Date: Fri, 25 Jun 2021 09:52:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210624180423.1322165-5-pbonzini@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.362, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, mlevitsk@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24.06.21 20:04, Paolo Bonzini wrote: > Block device requests must be aligned to bs->bl.request_alignment. > It makes sense for drivers to align bs->bl.max_transfer the same > way; however when there is no specified limit, blk_get_max_transfer > just returns INT_MAX. Since the contract of the function does not > specify that INT_MAX means "no maximum", just align the outcome > of the function (whether INT_MAX or bs->bl.max_transfer) before > returning it. > > Signed-off-by: Paolo Bonzini > --- > block/block-backend.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Max Reitz