RE: [PATCH v2 1/5] dt-bindings: pwrap: mediatek: add pwrap support for MT6797

["Argus Lin (林書慶)" <argus.lin@mediatek.com>]

[-- Attachment #1.1: Type: text/html, Size: 5760 bytes --]

[-- Attachment #1.2: Type: text/plain, Size: 3108 bytes --]



-----Original Message-----
From: Matthias Brugger [mailto:matthias.bgg@gmail.com] 
Sent: Tuesday, January 30, 2018 8:58 PM
To: Argus Lin (林書慶) <argus.lin@mediatek.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will Deacon <will.deacon@arm.com>
Cc: Chenglin Xu (徐成林) <Chenglin.Xu@mediatek.com>; Sean Wang (王志亘) <sean.wang@mediatek.com>; wsd_upstream <wsd_upstream@mediatek.com>; HenryC Chen (陳建豪) <HenryC.Chen@mediatek.com>; Flora Fu (傅君茹) <Flora.Fu@mediatek.com>; Chen Zhong (钟辰) <Chen.Zhong@mediatek.com>; Christophe Jaillet <christophe.jaillet@wanadoo.fr>; shailendra . v <shailendra.v@samsung.com>; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/5] dt-bindings: pwrap: mediatek: add pwrap support for MT6797



On 01/29/2018 10:09 AM, argus.lin@mediatek.com wrote:
> From: Argus Lin <argus.lin@mediatek.com>
> 
> We add pwrap support for MT6797 SoCs.
> 
> Signed-off-by: Argus Lin <argus.lin@mediatek.com>
> ---
>  Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt 
> b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
> index bf80e3f96f8c..f9987c30f0d5 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
> +++ b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
> @@ -19,6 +19,7 @@ IP Pairing
>  Required properties in pwrap device node.
>  - compatible:
>  	"mediatek,mt2701-pwrap" for MT2701/7623 SoCs
> +	"mediatek,mt6797-pwrap" for MT6797 SoCs

Looks good to me. When you send the new series, would you mind to add a cover letter in which you describe which changes you made in every version of the patch series? That makes the reviewing for me much easier :)

Thanks!

Dear Matthias:
Sure, I will add cover letter next time.
>  	"mediatek,mt7622-pwrap" for MT7622 SoCs
>  	"mediatek,mt8135-pwrap" for MT8135 SoCs
>  	"mediatek,mt8173-pwrap" for MT8173 SoCs
> --
> 2.12.5
> 
> ************* Email Confidentiality Notice
>  ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or 
> otherwise exempt from disclosure under applicable laws. It is intended 
> to be conveyed only to the designated recipient(s). Any use, 
> dissemination, distribution, printing, retaining or copying of this 
> e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may 
> be unlawful. If you are not an intended recipient of this e-mail, or 
> believe
>  
> that you have received this e-mail in error, please notify the sender 
> immediately (by replying to this e-mail), delete any and all copies of 
> this e-mail (including any attachments) from your system, and do not 
> disclose the content of this e-mail to any other person. Thank  you!
>