From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v2 3/3] arm64: dts: a3720: add support for espressobin with populated emmc
Date: Wed, 14 Oct 2020 10:37:57 +0200 [thread overview]
Message-ID: <90bae037-1181-965c-d121-c86f95a55e4b@gmail.com> (raw)
In-Reply-To: <20201014082133.5m2e42o3ycd6hjxu@pali>
On 14/10/2020 10:21, Pali Roh?r wrote:
<snip>
>>> diff --git a/doc/README.marvell b/doc/README.marvell
>>> index 5416bc3035..be07f31f8c 100644
>>> --- a/doc/README.marvell
>>> +++ b/doc/README.marvell
>>> @@ -43,8 +43,11 @@ Build Procedure
>>> In order to prevent this, the required device-tree MUST be set during compilation.
>>> All device-tree files are located in ./arch/arm/dts/ folder.
>>> - For other DB boards (MacchiatoBin, EspressoBin and 3700 DB board) compile u-boot with
>>> - just default device-tree from defconfig using:
>>> + For the EspressoBin board with populated eMMC device use
>>> + # make DEVICE_TREE=armada-3720-espressobin-emmc
>>> +
>>> + For other DB boards (MacchiatoBin, EspressoBin without soldered eMMC and 3700 DB board)
>>> + compile u-boot with just default device-tree from defconfig using:
>
> Hello! Does not it really make sense to do autodetection of eMMC
> presence and enable it in U-Boot code only when needed and therefore
> avoid having two DTS files and needs for specifying DEVICE_TREE variable
> and therefore variant of Espressobin, as I stated in previous emails?
>
> I think this just complicates build process... E.g. we already have a
> code in U-Boot which detects V5 vs V7 variant.
I still like the idea, but I'm still hesitating to just enable the emmc
everywhere. There's the issue with powering down the emmc block if it's
not populated. How would that work once we switch to atf for comphy control?
From a different angle: If we could just do that, why does Linux have
different devicetrees?
Regards,
Andre
next prev parent reply other threads:[~2020-10-14 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 15:33 [PATCH v2 1/3] arm64: dts: armada-3720-espressobin: use Linux model/compatible strings Andre Heider
2020-09-04 15:33 ` [PATCH v2 2/3] arm64: dts: armada-3720-espressobin: split common parts to .dtsi Andre Heider
2020-10-14 8:17 ` Stefan Roese
2020-09-04 15:33 ` [PATCH v2 3/3] arm64: dts: a3720: add support for espressobin with populated emmc Andre Heider
2020-09-09 9:16 ` Andre Heider
2020-09-10 18:04 ` Andre Heider
2020-10-14 8:17 ` Stefan Roese
2020-10-14 8:21 ` Pali Rohár
2020-10-14 8:37 ` Andre Heider [this message]
2020-10-14 8:45 ` Pali Rohár
2020-10-14 13:20 ` Pali Rohár
2020-10-02 5:51 ` [PATCH v3] arm64: dts: armada-3720-espressobin: use Linux model/compatible strings Andre Heider
2020-10-02 10:56 ` Pali Rohár
2020-10-07 4:57 ` Stefan Roese
2020-10-14 8:16 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90bae037-1181-965c-d121-c86f95a55e4b@gmail.com \
--to=a.heider@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.