From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH] crypto/dpaa2_sec: remove iova conversion for
 fle address
Date: Wed, 9 May 2018 17:59:14 +0530
Message-ID: <90cd576c-93f6-6398-95bd-e51e02ad0f40@nxp.com>
References: <20180509092642.9092-1-shreyansh.jain@nxp.com>
 <ca1fb35f-cdae-58b0-f566-aac579509377@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CD04F1B@IRSMSX108.ger.corp.intel.com>
 <b9470eaf-2c46-10b9-76e0-72391d90274c@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CD050B2@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-HE1-obe.outbound.protection.outlook.com
 (mail-he1eur01on0050.outbound.protection.outlook.com [104.47.0.50])
 by dpdk.org (Postfix) with ESMTP id 484381B16B
 for <dev@dpdk.org>; Wed,  9 May 2018 14:12:41 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD050B2@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 09 May 2018 05:00 PM, De Lara Guarch, Pablo wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com]
>> Sent: Wednesday, May 9, 2018 12:40 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Hemant Agrawal
>> <hemant.agrawal@nxp.com>
>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for
>> fle address
>>
>> On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>>>> Sent: Wednesday, May 9, 2018 10:14 AM
>>>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; De Lara Guarch, Pablo
>>>> <pablo.de.lara.guarch@intel.com>
>>>> Cc: akhil.goyal@nxp.com; dev@dpdk.org; Hemant Agrawal
>>>> <hemant.agrawal@nxp.com>
>>>> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova
>>>> conversion for fle address
>>>>
>>>> On 5/9/2018 2:56 PM, Shreyansh Jain wrote:
>>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>
>>>>> fle is already in virtual addressing mode - no need to perform
>>>>> address conversion for it.
>>>>>
>>>>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
>>>>> Cc: akhil.goyal@nxp.com
>>>>>
>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>
>>> ...
>>>
>>>>>
>>>> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>>>
>>> Added Cc: stable@dpdk.org (try remembering this for next time, please).
>>
>> Thanks for doing it this time. I'll take care of this next time.
> 
> No worries. Actually, gcc 32 bits is broken:
> 
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7:
> error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>    op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1));
> 
> Is this PMD supposed to be compatible for 32-bit targets?

Oh! This is bad. I will send you an update on this in a few minutes.
Ideally, the code was written for 64bit in mind - though, it should 
still be able to work (at least compile) for 32 bit.

> 
> Thanks,
> Pablo
> 
>>
>>>
>>> Applied to dpdk-next-crypto.
>>> Thanks,
>>>
>>> Pablo
>>>
>