From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0FDC61DD8 for ; Mon, 16 Nov 2020 14:14:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8FE8222EC for ; Mon, 16 Nov 2020 14:14:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WgMz8DPq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728870AbgKPOOg (ORCPT ); Mon, 16 Nov 2020 09:14:36 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:53038 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbgKPOOg (ORCPT ); Mon, 16 Nov 2020 09:14:36 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AGEECjG098332; Mon, 16 Nov 2020 08:14:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1605536052; bh=CesylDhKL5F2RLO21Mz02Qpf8QzNoQ/J7g1qiBS/bhk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=WgMz8DPq7tarq6XoqKf+09VI1CV/IylTOh3eRy4neU4iGFxwlpzL+JYRGLn6nwLJD r+len0k2/7TlqmXVEq028HR8JT6yI8M5qz5N27t0rM9P71V1PTskiVeREfth+v5LpI 14RyGKzaKeX+PeKX5W7C8RRX9n5j+TAQfkdwIn3s= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AGEEBNq087815 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Nov 2020 08:14:11 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 16 Nov 2020 08:14:11 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 16 Nov 2020 08:14:11 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AGEE7b8075117; Mon, 16 Nov 2020 08:14:08 -0600 Subject: Re: [PATCH v1 0/4] Add bus format negotiation support for Cadence MHDP8546 driver To: Yuti Amonkar , , , , , , , , , , , CC: , , , , References: <1605260794-29806-1-git-send-email-yamonkar@cadence.com> From: Tomi Valkeinen Message-ID: <90d19291-f0ca-df64-1687-3b25fbf418de@ti.com> Date: Mon, 16 Nov 2020 16:14:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1605260794-29806-1-git-send-email-yamonkar@cadence.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13/11/2020 11:46, Yuti Amonkar wrote: > This patch series add bus format negotiation support for Cadence MHDP8546 bridge > driver. > > The patch series has four patches in the below sequence: > 1. drm: bridge: cdns-mhdp8546: Add output bus format negotiation > Add minimal output bus format negotiation support. > 2. drm: bridge: cdns-mhdp8546: Modify atomic_get_input_bus_format bridge function. > Get the input format based on output format supported. > 3. drm: bridge: cdns-mhdp8546: Remove setting of bus format using connector info > Remove the bus format configuration using connector info structure. > 4. drm: bridge: cdns-mhdp8546: Retrieve the pixel format and bpc based on bus format > Get the pixel format and bpc based on negotiated output bus format. > > This patch series is dependent on tidss series [1] for the new connector model support. > > [1] > https://patchwork.kernel.org/project/dri-devel/cover/20201109170601.21557-1-nikhil.nd@ti.com/ Can you explain how this works? Afaics, what we should be doing is: - We don't have proper bus formats for DP output, so we need to use MEDIA_BUS_FMT_FIXED as the output format. This is what you do in the first patch. (But is that patch even needed, if MEDIA_BUS_FMT_FIXED is the default anyway) - In cdns_mhdp_get_input_bus_fmts, the function should exit if the given output format is not MEDIA_BUS_FMT_FIXED. - In cdns_mhdp_get_input_bus_fmts, the driver should return all the RGB bus formats, if MHDP is able to upscale/downscale RGB (e.g. RGB 8-bpc to RGB 12-bpc). - If the monitor supports YUV modes according to the display_info, cdns_mhdp_get_input_bus_fmts can also return those. - Then later, in atomic_check and commit, mhdp driver has the negotiated bus format, which it should use to program the registers. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D64C4742C for ; Mon, 16 Nov 2020 14:14:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AA9722265 for ; Mon, 16 Nov 2020 14:14:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="WgMz8DPq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AA9722265 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C21F899E8; Mon, 16 Nov 2020 14:14:30 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BA91899D6 for ; Mon, 16 Nov 2020 14:14:28 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0AGEECjG098332; Mon, 16 Nov 2020 08:14:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1605536052; bh=CesylDhKL5F2RLO21Mz02Qpf8QzNoQ/J7g1qiBS/bhk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=WgMz8DPq7tarq6XoqKf+09VI1CV/IylTOh3eRy4neU4iGFxwlpzL+JYRGLn6nwLJD r+len0k2/7TlqmXVEq028HR8JT6yI8M5qz5N27t0rM9P71V1PTskiVeREfth+v5LpI 14RyGKzaKeX+PeKX5W7C8RRX9n5j+TAQfkdwIn3s= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0AGEEBNq087815 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Nov 2020 08:14:11 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 16 Nov 2020 08:14:11 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 16 Nov 2020 08:14:11 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0AGEE7b8075117; Mon, 16 Nov 2020 08:14:08 -0600 Subject: Re: [PATCH v1 0/4] Add bus format negotiation support for Cadence MHDP8546 driver To: Yuti Amonkar , , , , , , , , , , , References: <1605260794-29806-1-git-send-email-yamonkar@cadence.com> From: Tomi Valkeinen Message-ID: <90d19291-f0ca-df64-1687-3b25fbf418de@ti.com> Date: Mon, 16 Nov 2020 16:14:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1605260794-29806-1-git-send-email-yamonkar@cadence.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mparab@cadence.com, nsekhar@ti.com, nikhil.nd@ti.com, jsarha@ti.com, sjakhade@cadence.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 13/11/2020 11:46, Yuti Amonkar wrote: > This patch series add bus format negotiation support for Cadence MHDP8546 bridge > driver. > > The patch series has four patches in the below sequence: > 1. drm: bridge: cdns-mhdp8546: Add output bus format negotiation > Add minimal output bus format negotiation support. > 2. drm: bridge: cdns-mhdp8546: Modify atomic_get_input_bus_format bridge function. > Get the input format based on output format supported. > 3. drm: bridge: cdns-mhdp8546: Remove setting of bus format using connector info > Remove the bus format configuration using connector info structure. > 4. drm: bridge: cdns-mhdp8546: Retrieve the pixel format and bpc based on bus format > Get the pixel format and bpc based on negotiated output bus format. > > This patch series is dependent on tidss series [1] for the new connector model support. > > [1] > https://patchwork.kernel.org/project/dri-devel/cover/20201109170601.21557-1-nikhil.nd@ti.com/ Can you explain how this works? Afaics, what we should be doing is: - We don't have proper bus formats for DP output, so we need to use MEDIA_BUS_FMT_FIXED as the output format. This is what you do in the first patch. (But is that patch even needed, if MEDIA_BUS_FMT_FIXED is the default anyway) - In cdns_mhdp_get_input_bus_fmts, the function should exit if the given output format is not MEDIA_BUS_FMT_FIXED. - In cdns_mhdp_get_input_bus_fmts, the driver should return all the RGB bus formats, if MHDP is able to upscale/downscale RGB (e.g. RGB 8-bpc to RGB 12-bpc). - If the monitor supports YUV modes according to the display_info, cdns_mhdp_get_input_bus_fmts can also return those. - Then later, in atomic_check and commit, mhdp driver has the negotiated bus format, which it should use to program the registers. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel