All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] Input: goodix - Improve gpiod_get() error logging
Date: Tue, 7 Dec 2021 11:07:03 +0100	[thread overview]
Message-ID: <90d371ae-550c-c2ee-a475-93d29f8c06d0@redhat.com> (raw)
In-Reply-To: <Ya8Nzkh+VwcQCUIi@google.com>

Hi Dmitry,

On 12/7/21 08:31, Dmitry Torokhov wrote:
> Hi Hans,
> 
> On Mon, Dec 06, 2021 at 05:47:45PM +0100, Hans de Goede wrote:
>> goodix_get_gpio_config() errors are fatal (abort probe()) so log them
>> at KERN_ERR level rather then as debug messages.
>>
>> This change uses dev_err_probe() to automatically suppress the errors
>> in case of -EPROBE_DEFER.
> 
> I really believe that dev_err_probe() is wrong API as the providers
> should be setting the reason for deferred probe failures.
> 
> Could you simply swap dev_dbg() for dev_err()?

Done for v2, which I'm sending out right away.

Note I've dropped the first patch for v2 since you said you
applied this.

Regards,

Hans


p.s.

Any chance you could also take a look at this 2 patch patch-series,
this has been pending for a while now:

https://lore.kernel.org/linux-input/20211122220637.11386-1-hdegoede@redhat.com/T/#t


  reply	other threads:[~2021-12-07 10:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 16:47 [PATCH 0/4] Input: goodix - pen support + misc patches Hans de Goede
2021-12-06 16:47 ` [PATCH 1/4] Input: goodix - Add id->model mapping for the "9111" model Hans de Goede
2021-12-07  7:29   ` Dmitry Torokhov
2021-12-06 16:47 ` [PATCH 2/4] Input: goodix - Improve gpiod_get() error logging Hans de Goede
2021-12-07  7:31   ` Dmitry Torokhov
2021-12-07 10:07     ` Hans de Goede [this message]
2021-12-06 16:47 ` [PATCH 3/4] Input: goodix - Use the new soc_intel_is_byt() helper Hans de Goede
2021-12-06 16:47 ` [PATCH 4/4] Input: goodix - Add pen support Hans de Goede
2021-12-07 17:50   ` Dmitry Torokhov
2021-12-08  8:37     ` Hans de Goede
2021-12-08  8:51       ` Dmitry Torokhov
2021-12-08 17:02         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90d371ae-550c-c2ee-a475-93d29f8c06d0@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.