All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] arm64: zynqmp: Fix SVD mask for getting chip ID
Date: Thu, 20 Jul 2017 11:07:47 +0200	[thread overview]
Message-ID: <90d39b29dbe471d5a6ca0f75c12de2600c477c30.1500541666.git.michal.simek@xilinx.com> (raw)
In-Reply-To: <f7267e572e470de08b6e0a94e2d2f4fd7cfb17d3.1500541666.git.michal.simek@xilinx.com>

Mask should start from the first bit - using 0xe is just wrong.
3bits are used that's why 0x7 mask is correct.
This patch is fixing silicon ID code detection. Previous behavior was
that bit0 was completely ignored.
Issue was found on 2eg chip detection.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/zynqmppl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/zynqmppl.h b/include/zynqmppl.h
index fb5200ec84a6..4c8c2f88f04c 100644
--- a/include/zynqmppl.h
+++ b/include/zynqmppl.h
@@ -20,7 +20,7 @@
 #define ZYNQMP_CSU_IDCODE_DEVICE_CODE_MASK	(0xf << \
 					ZYNQMP_CSU_IDCODE_DEVICE_CODE_SHIFT)
 #define ZYNQMP_CSU_IDCODE_SVD_SHIFT	12
-#define ZYNQMP_CSU_IDCODE_SVD_MASK	(0xe << ZYNQMP_CSU_IDCODE_SVD_SHIFT)
+#define ZYNQMP_CSU_IDCODE_SVD_MASK	(0x7 << ZYNQMP_CSU_IDCODE_SVD_SHIFT)
 
 extern struct xilinx_fpga_op zynqmp_op;
 
-- 
1.9.1

  parent reply	other threads:[~2017-07-20  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20  9:07 [U-Boot] [PATCH 1/8] arm64: zynqmp: Provide a Kconfig option to define OCM and TCM in MMU Michal Simek
2017-07-20  9:07 ` [U-Boot] [PATCH 2/8] arm64: zynqmp: Define a way to intialize TCM Michal Simek
2017-07-20  9:07 ` [U-Boot] [PATCH 3/8] arm64: zynqmp: Remove ifdef around zynqmp mmio read and write rotuines Michal Simek
2017-07-20  9:07 ` [U-Boot] [PATCH 4/8] arm64: zynqmp: Call psu_init from board_early_init_f Michal Simek
2017-07-20  9:07 ` [U-Boot] [PATCH 5/8] arm64: zynqmp: Add Kconfig option for adding psu_init to binary Michal Simek
2017-07-20  9:07 ` Michal Simek [this message]
2017-07-20  9:07 ` [U-Boot] [PATCH 7/8] arm64: zynqmp: Do not setup time if already setup Michal Simek
2017-07-20  9:07 ` [U-Boot] [PATCH 8/8] arm64: zynqmp: Dont write to system timestamp generator Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90d39b29dbe471d5a6ca0f75c12de2600c477c30.1500541666.git.michal.simek@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.