From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4079C43603 for ; Mon, 16 Dec 2019 15:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7752D20665 for ; Mon, 16 Dec 2019 15:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="if4TIjb/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728425AbfLPPle (ORCPT ); Mon, 16 Dec 2019 10:41:34 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55220 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728376AbfLPPle (ORCPT ); Mon, 16 Dec 2019 10:41:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576510892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oeIc59QSTUoM+WKt9UthuhNY2ejH+cHhDJxHGyG7QBo=; b=if4TIjb/1pwmvlWy7qWjGXmj6m1ePgonCir+mNXOOcK9G7MvLKLAZ6HSrJ8z5nmXVhvpJH kyXCk2SEXpmhK3++r+9cV+8zXmJlaiHyGeD54NJRUIc848cJbmWd7rIZNiTHJH3y0XDtzW dXgEQHgxdgzCo1v/rfU7atJ9WJJmgYQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-EUncpHjPPDaJsBUUSeEt1w-1; Mon, 16 Dec 2019 10:41:31 -0500 X-MC-Unique: EUncpHjPPDaJsBUUSeEt1w-1 Received: by mail-wm1-f69.google.com with SMTP id p5so1180391wmc.4 for ; Mon, 16 Dec 2019 07:41:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oeIc59QSTUoM+WKt9UthuhNY2ejH+cHhDJxHGyG7QBo=; b=jgDuLzCywtVVZJxFFEt2DlkNXk3FwdXFe8Z64yMQMERAeXT7u0m6fn5dPYeoYtprPu 0n71aAxNGbUjDKzSMen34MxCIV0F8EPdK2rONyUGTnKjeQqWHm5nyhb+Dzwi2KHTeSI5 AkFPEdE7K6Q1d5eMw7yb4IwuSOuNfjcFRvN1ug6tX6vyMCiJzbiXE8SOaorhNED1WlS4 N2tApehBxNXTnVjpRahSOytLe4Kgs3nB2SS7HIUpjtwwYW8Njve4zAEfVxq44c9VSC5I mLRv3N1cwZGWamnunqklLarh0eZdq22IkuIulb48Ab7GEGmgFO/Q7bks+bwy5X/Q4QQ0 MWkg== X-Gm-Message-State: APjAAAU11eqMmyWIgj5f30shvDq1m21eaA2b6pj5akTbxCnExJBMa05H ChxLza8SzzpNWr2RHg/NUX5dK8ssv97EBfuaK3OU/qA630ZTZvvbAOvrgrREvH5YuL5Br1TmUTu VdSYycXEw/CYm X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125221wrn.270.1576510890029; Mon, 16 Dec 2019 07:41:30 -0800 (PST) X-Google-Smtp-Source: APXvYqypDXszAwMOZCzf4Ez0io31KjZBaZhfECz0yOnY8MQ2T2JBsgh1CjxeGSVWMrX9dHTIjFOC2w== X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125154wrn.270.1576510889523; Mon, 16 Dec 2019 07:41:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:cde8:2463:95a9:1d81? ([2001:b07:6468:f312:cde8:2463:95a9:1d81]) by smtp.gmail.com with ESMTPSA id d10sm21967922wrw.64.2019.12.16.07.41.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 07:41:28 -0800 (PST) Subject: Re: [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h' To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, John Snow , Eduardo Habkost , Paul Durrant , Marcel Apfelbaum , kvm@vger.kernel.org, Stefano Stabellini , Igor Mammedov , Anthony Perard , qemu-block@nongnu.org, Richard Henderson , xen-devel@lists.xenproject.org, Sergio Lopez References: <20191213161753.8051-1-philmd@redhat.com> <20191213161753.8051-13-philmd@redhat.com> <20191215045812-mutt-send-email-mst@kernel.org> <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> From: Paolo Bonzini Message-ID: <90d54a3b-ae96-43ac-0f8e-268c1257f7d0@redhat.com> Date: Mon, 16 Dec 2019 16:41:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 16/12/19 16:37, Philippe Mathieu-Daudé wrote: > On 12/15/19 10:58 AM, Michael S. Tsirkin wrote: >> On Fri, Dec 13, 2019 at 05:47:28PM +0100, Philippe Mathieu-Daudé wrote: >>> On 12/13/19 5:17 PM, Philippe Mathieu-Daudé wrote: >>>> Historically, QEMU started with only one X86 machine: the PC. >>>> The 'hw/i386/pc.h' header was used to store all X86 and PC >>>> declarations. Since we have now multiple machines based on the >>>> X86 architecture, move the PC-specific declarations in a new >>>> header. >>>> We use 'internal' in the name to explicit this header is restricted >>>> to the X86 architecture. Other architecture can not access it. >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> --- >>>> Maybe name it 'pc_machine.h'? >>> >>> I forgot to describe here (and in the cover), what's follow after this >>> patch. >>> >>> Patch #13 moves PCMachineClass to >>> >>> If you ignore PCMachineState, "hw/i386/pc.h" now only contains 76 >>> lines, and >>> it is easier to see what is PC machine specific, what is X86 >>> specific, and >>> what is device generic (not X86 related at all): >>> >>> - GSI is common to X86 (Paolo sent [3], [6]) >>> - IOAPIC is common to X86 >>> - i8259 is multiarch (Paolo [2]) >>> - PCI_HOST definitions and pc_pci_hole64_start() are X86 >>> - pc_machine_is_smm_enabled() is X86 (Paolo sent [5]) >>> - hpet >>> - tsc (Paolo sent [3]) >>> - 3 more functions >>> >>> So we can move half of this file to "pc_internal.h" and the other to >>> >>> One problem is the Q35 MCH north bridge which directly sets the PCI >>> PCMachineState->bus in q35_host_realize(). This seems a QOM violation >>> and is >>> probably easily fixable. >>> >>> Maybe I can apply Paolo's patches instead of this #12, move X86-generic >>> declarations to "hw/i386/x86.h", and directly git-move what's left of >>> "hw/i386/pc.h" to "pc_internal.h". >> >> Yea that sounds a bit better. > > OK, I'll wait for Paolo's next pull get in, then continue based on that, > including Paolo's "x86: allow building without PC machine types" series. > > (Thanks Paolo for picking most of this series!) FWIW I don't think kvm_i8259_init should be in sysemu/kvm.h, since it's x86-specific and that would be something like the same mistake already done with hw/i386/pc.h. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6275C43603 for ; Mon, 16 Dec 2019 15:42:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D2B20665 for ; Mon, 16 Dec 2019 15:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aY5986Cq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D2B20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igsVy-0006WX-El for qemu-devel@archiver.kernel.org; Mon, 16 Dec 2019 10:42:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34517) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igsV6-0005aj-KM for qemu-devel@nongnu.org; Mon, 16 Dec 2019 10:41:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igsV5-0005NE-Hc for qemu-devel@nongnu.org; Mon, 16 Dec 2019 10:41:36 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:26296 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1igsV5-0005LS-Da for qemu-devel@nongnu.org; Mon, 16 Dec 2019 10:41:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576510894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cu162pOTWU5yRvxVUJyOyppXqvklmFV84tiKSaDKRvg=; b=aY5986CqFe8rVaHQxT85AbjqS5rU8RixRoauc/D5ooV1EAdrlKmrfxcD1DdTUS55DoDSSl u42rPkC09UbGQipKpbKIEP5VeqZ5NBEZS0ndDw4lcD++EIwaM55eMELKZW2WEp8Fmr8Q2Z dMddsfv+7k9EWmspyGW1KGfzV85pqck= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138-SIEmcVY3O2m1lJMNljGz2A-1; Mon, 16 Dec 2019 10:41:31 -0500 Received: by mail-wm1-f70.google.com with SMTP id t4so1199892wmf.2 for ; Mon, 16 Dec 2019 07:41:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oeIc59QSTUoM+WKt9UthuhNY2ejH+cHhDJxHGyG7QBo=; b=Sh2wQgWE/CqsiluOgS1AGs02O1cD26g/NjLPvHpb6j5AeXGKEz5aMmjsemr3Caf7RS xOQizvF46y0sE4nVSIExNhHgI1WhOIlAfEPJmU4Pu5dBrmsaPxW4sH6xx1uErIzEo++2 NssfUWeyKWqrocYMQxtEngcJGyymV8OuDtIuFM74PyzoKtPP+0wWDj2upd1mFTWK5Pm8 ga9XIQOl1D95zJ3OogcNGmFeW73VcOA510h7OY11e6v0qfQGzPXsPJGiWCsFzLzVAeGA aQ7kfXq8AASg6Ri0LNOucaPgJ56ycwqxaNm78eLZAM21KWKsGlOZhS4JfmXsmPkTRBDd HZyw== X-Gm-Message-State: APjAAAXoryh+mY523uTuMgb36XFbQnnbxNLHyt2XAr10tcMd1zW33Syb ubXePMOKP3o2zhip51cGrlpIkQdIwZK0WNHUq9MG2c/R2qBnnKmXdf3HFIliEGxLxzgdZzDOOY6 NfQ9/txOaVB3rzmc= X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125216wrn.270.1576510890028; Mon, 16 Dec 2019 07:41:30 -0800 (PST) X-Google-Smtp-Source: APXvYqypDXszAwMOZCzf4Ez0io31KjZBaZhfECz0yOnY8MQ2T2JBsgh1CjxeGSVWMrX9dHTIjFOC2w== X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125154wrn.270.1576510889523; Mon, 16 Dec 2019 07:41:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:cde8:2463:95a9:1d81? ([2001:b07:6468:f312:cde8:2463:95a9:1d81]) by smtp.gmail.com with ESMTPSA id d10sm21967922wrw.64.2019.12.16.07.41.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 07:41:28 -0800 (PST) Subject: Re: [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h' To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" References: <20191213161753.8051-1-philmd@redhat.com> <20191213161753.8051-13-philmd@redhat.com> <20191215045812-mutt-send-email-mst@kernel.org> <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> From: Paolo Bonzini Message-ID: <90d54a3b-ae96-43ac-0f8e-268c1257f7d0@redhat.com> Date: Mon, 16 Dec 2019 16:41:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> Content-Language: en-US X-MC-Unique: SIEmcVY3O2m1lJMNljGz2A-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Sergio Lopez , Eduardo Habkost , kvm@vger.kernel.org, Paul Durrant , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Igor Mammedov , qemu-block@nongnu.org, John Snow , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/12/19 16:37, Philippe Mathieu-Daud=C3=A9 wrote: > On 12/15/19 10:58 AM, Michael S. Tsirkin wrote: >> On Fri, Dec 13, 2019 at 05:47:28PM +0100, Philippe Mathieu-Daud=C3=A9 wr= ote: >>> On 12/13/19 5:17 PM, Philippe Mathieu-Daud=C3=A9 wrote: >>>> Historically, QEMU started with only one X86 machine: the PC. >>>> The 'hw/i386/pc.h' header was used to store all X86 and PC >>>> declarations. Since we have now multiple machines based on the >>>> X86 architecture, move the PC-specific declarations in a new >>>> header. >>>> We use 'internal' in the name to explicit this header is restricted >>>> to the X86 architecture. Other architecture can not access it. >>>> >>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>>> --- >>>> Maybe name it 'pc_machine.h'? >>> >>> I forgot to describe here (and in the cover), what's follow after this >>> patch. >>> >>> Patch #13 moves PCMachineClass to >>> >>> If you ignore PCMachineState, "hw/i386/pc.h" now only contains 76 >>> lines, and >>> it is easier to see what is PC machine specific, what is X86 >>> specific, and >>> what is device generic (not X86 related at all): >>> >>> - GSI is common to X86 (Paolo sent [3], [6]) >>> - IOAPIC is common to X86 >>> - i8259 is multiarch (Paolo [2]) >>> - PCI_HOST definitions and pc_pci_hole64_start() are X86 >>> - pc_machine_is_smm_enabled() is X86 (Paolo sent [5]) >>> - hpet >>> - tsc (Paolo sent [3]) >>> - 3 more functions >>> >>> So we can move half of this file to "pc_internal.h" and the other to >>> >>> One problem is the Q35 MCH north bridge which directly sets the PCI >>> PCMachineState->bus in q35_host_realize(). This seems a QOM violation >>> and is >>> probably easily fixable. >>> >>> Maybe I can apply Paolo's patches instead of this #12, move X86-generic >>> declarations to "hw/i386/x86.h", and directly git-move what's left of >>> "hw/i386/pc.h" to "pc_internal.h". >> >> Yea that sounds a bit better. >=20 > OK, I'll wait for Paolo's next pull get in, then continue based on that, > including Paolo's "x86: allow building without PC machine types" series. >=20 > (Thanks Paolo for picking most of this series!) FWIW I don't think kvm_i8259_init should be in sysemu/kvm.h, since it's x86-specific and that would be something like the same mistake already done with hw/i386/pc.h. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B8EC43603 for ; Mon, 16 Dec 2019 15:41:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9647920665 for ; Mon, 16 Dec 2019 15:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aY5986Cq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9647920665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1igsVF-00057r-4K; Mon, 16 Dec 2019 15:41:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1igsVD-00057m-QH for xen-devel@lists.xenproject.org; Mon, 16 Dec 2019 15:41:43 +0000 X-Inumbo-ID: 8a652588-201a-11ea-b6f1-bc764e2007e4 Received: from us-smtp-1.mimecast.com (unknown [207.211.31.120]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 8a652588-201a-11ea-b6f1-bc764e2007e4; Mon, 16 Dec 2019 15:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576510894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cu162pOTWU5yRvxVUJyOyppXqvklmFV84tiKSaDKRvg=; b=aY5986CqFe8rVaHQxT85AbjqS5rU8RixRoauc/D5ooV1EAdrlKmrfxcD1DdTUS55DoDSSl u42rPkC09UbGQipKpbKIEP5VeqZ5NBEZS0ndDw4lcD++EIwaM55eMELKZW2WEp8Fmr8Q2Z dMddsfv+7k9EWmspyGW1KGfzV85pqck= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-247-kNI3mzbjPtCOF654PIr9zQ-1; Mon, 16 Dec 2019 10:41:31 -0500 Received: by mail-wm1-f71.google.com with SMTP id o24so1182119wmh.0 for ; Mon, 16 Dec 2019 07:41:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oeIc59QSTUoM+WKt9UthuhNY2ejH+cHhDJxHGyG7QBo=; b=LpwuedAmBsWpPijdN5IBBNAW2N8wYinTHkpknseVmfFVhpKI0fCveOIx6Z2aH5L5Zq C/lABPGG7cE2na81Ugn/0wTVha/3Xq6k5do+j2MLOPHU/HoF0Rq+M9QJoglgQaGT7SzT n/fIrjNYQMHDCXPJOrYfmZCN8Q5ueAwfiR7LUUyWRxg8RVnC/Zbt1z6Ncv4Srlzj4F5r NXi0D/x2Jx3AwjQROwjL79f42UFWiKp7pJa5lkAYncKMrbgN2DYMuuFmWozGXoLRvoDg jbs8LGz86bHdJKAe49IbAJrKRpwllgg1iD5/ddCtoOK1vZBcBNX1BiexbztKOcSIRSlB pYdA== X-Gm-Message-State: APjAAAV3I8ZvOVbRn7aBZEKgCSVU4srfbs56AmaIA0ferlVmQq3Tanm0 XeyNP3545Px67jLdWz0LUKgfprdhz6A0gyEiyarA+92S9W/kqaw8+zE4XtgblDT0Jne31ubO+hw nKrA2oB2tkcEJDN2ek8QrcEjyrAY= X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125217wrn.270.1576510890028; Mon, 16 Dec 2019 07:41:30 -0800 (PST) X-Google-Smtp-Source: APXvYqypDXszAwMOZCzf4Ez0io31KjZBaZhfECz0yOnY8MQ2T2JBsgh1CjxeGSVWMrX9dHTIjFOC2w== X-Received: by 2002:adf:ea42:: with SMTP id j2mr31125154wrn.270.1576510889523; Mon, 16 Dec 2019 07:41:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:cde8:2463:95a9:1d81? ([2001:b07:6468:f312:cde8:2463:95a9:1d81]) by smtp.gmail.com with ESMTPSA id d10sm21967922wrw.64.2019.12.16.07.41.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 07:41:28 -0800 (PST) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" References: <20191213161753.8051-1-philmd@redhat.com> <20191213161753.8051-13-philmd@redhat.com> <20191215045812-mutt-send-email-mst@kernel.org> <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> From: Paolo Bonzini Message-ID: <90d54a3b-ae96-43ac-0f8e-268c1257f7d0@redhat.com> Date: Mon, 16 Dec 2019 16:41:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <0d15c735-73b4-7875-ec0f-8c181508f0d4@redhat.com> Content-Language: en-US X-MC-Unique: kNI3mzbjPtCOF654PIr9zQ-1 X-Mimecast-Spam-Score: 0 Subject: Re: [Xen-devel] [PATCH 12/12] hw/i386/pc: Move PC-machine specific declarations to 'pc_internal.h' X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Sergio Lopez , Eduardo Habkost , kvm@vger.kernel.org, Paul Durrant , qemu-devel@nongnu.org, Marcel Apfelbaum , xen-devel@lists.xenproject.org, Anthony Perard , Igor Mammedov , qemu-block@nongnu.org, John Snow , Richard Henderson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTYvMTIvMTkgMTY6MzcsIFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIHdyb3RlOgo+IE9uIDEy LzE1LzE5IDEwOjU4IEFNLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4+IE9uIEZyaSwgRGVj IDEzLCAyMDE5IGF0IDA1OjQ3OjI4UE0gKzAxMDAsIFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIHdy b3RlOgo+Pj4gT24gMTIvMTMvMTkgNToxNyBQTSwgUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgd3Jv dGU6Cj4+Pj4gSGlzdG9yaWNhbGx5LCBRRU1VIHN0YXJ0ZWQgd2l0aCBvbmx5IG9uZSBYODYgbWFj aGluZTogdGhlIFBDLgo+Pj4+IFRoZSAnaHcvaTM4Ni9wYy5oJyBoZWFkZXIgd2FzIHVzZWQgdG8g c3RvcmUgYWxsIFg4NiBhbmQgUEMKPj4+PiBkZWNsYXJhdGlvbnMuIFNpbmNlIHdlIGhhdmUgbm93 IG11bHRpcGxlIG1hY2hpbmVzIGJhc2VkIG9uIHRoZQo+Pj4+IFg4NiBhcmNoaXRlY3R1cmUsIG1v dmUgdGhlIFBDLXNwZWNpZmljIGRlY2xhcmF0aW9ucyBpbiBhIG5ldwo+Pj4+IGhlYWRlci4KPj4+ PiBXZSB1c2UgJ2ludGVybmFsJyBpbiB0aGUgbmFtZSB0byBleHBsaWNpdCB0aGlzIGhlYWRlciBp cyByZXN0cmljdGVkCj4+Pj4gdG8gdGhlIFg4NiBhcmNoaXRlY3R1cmUuIE90aGVyIGFyY2hpdGVj dHVyZSBjYW4gbm90IGFjY2VzcyBpdC4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBl IE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAcmVkaGF0LmNvbT4KPj4+PiAtLS0KPj4+PiBNYXliZSBu YW1lIGl0ICdwY19tYWNoaW5lLmgnPwo+Pj4KPj4+IEkgZm9yZ290IHRvIGRlc2NyaWJlIGhlcmUg KGFuZCBpbiB0aGUgY292ZXIpLCB3aGF0J3MgZm9sbG93IGFmdGVyIHRoaXMKPj4+IHBhdGNoLgo+ Pj4KPj4+IFBhdGNoICMxMyBtb3ZlcyBQQ01hY2hpbmVDbGFzcyB0bwo+Pj4KPj4+IElmIHlvdSBp Z25vcmUgUENNYWNoaW5lU3RhdGUsICJody9pMzg2L3BjLmgiIG5vdyBvbmx5IGNvbnRhaW5zIDc2 Cj4+PiBsaW5lcywgYW5kCj4+PiBpdCBpcyBlYXNpZXIgdG8gc2VlIHdoYXQgaXMgUEMgbWFjaGlu ZSBzcGVjaWZpYywgd2hhdCBpcyBYODYKPj4+IHNwZWNpZmljLCBhbmQKPj4+IHdoYXQgaXMgZGV2 aWNlIGdlbmVyaWMgKG5vdCBYODYgcmVsYXRlZCBhdCBhbGwpOgo+Pj4KPj4+IC0gR1NJIGlzIGNv bW1vbiB0byBYODYgKFBhb2xvIHNlbnQgWzNdLCBbNl0pCj4+PiAtIElPQVBJQyBpcyBjb21tb24g dG8gWDg2Cj4+PiAtIGk4MjU5IGlzIG11bHRpYXJjaCAoUGFvbG8gWzJdKQo+Pj4gLSBQQ0lfSE9T VCBkZWZpbml0aW9ucyBhbmQgcGNfcGNpX2hvbGU2NF9zdGFydCgpIGFyZSBYODYKPj4+IC0gcGNf bWFjaGluZV9pc19zbW1fZW5hYmxlZCgpIGlzIFg4NiAoUGFvbG8gc2VudCBbNV0pCj4+PiAtIGhw ZXQKPj4+IC0gdHNjIChQYW9sbyBzZW50IFszXSkKPj4+IC0gMyBtb3JlIGZ1bmN0aW9ucwo+Pj4K Pj4+IFNvIHdlIGNhbiBtb3ZlIGhhbGYgb2YgdGhpcyBmaWxlIHRvICJwY19pbnRlcm5hbC5oIiBh bmQgdGhlIG90aGVyIHRvCj4+Pgo+Pj4gT25lIHByb2JsZW0gaXMgdGhlIFEzNSBNQ0ggbm9ydGgg YnJpZGdlIHdoaWNoIGRpcmVjdGx5IHNldHMgdGhlIFBDSQo+Pj4gUENNYWNoaW5lU3RhdGUtPmJ1 cyBpbiBxMzVfaG9zdF9yZWFsaXplKCkuIFRoaXMgc2VlbXMgYSBRT00gdmlvbGF0aW9uCj4+PiBh bmQgaXMKPj4+IHByb2JhYmx5IGVhc2lseSBmaXhhYmxlLgo+Pj4KPj4+IE1heWJlIEkgY2FuIGFw cGx5IFBhb2xvJ3MgcGF0Y2hlcyBpbnN0ZWFkIG9mIHRoaXMgIzEyLCBtb3ZlIFg4Ni1nZW5lcmlj Cj4+PiBkZWNsYXJhdGlvbnMgdG8gImh3L2kzODYveDg2LmgiLCBhbmQgZGlyZWN0bHkgZ2l0LW1v dmUgd2hhdCdzIGxlZnQgb2YKPj4+ICJody9pMzg2L3BjLmgiIHRvICJwY19pbnRlcm5hbC5oIi4K Pj4KPj4gWWVhIHRoYXQgc291bmRzIGEgYml0IGJldHRlci4KPiAKPiBPSywgSSdsbCB3YWl0IGZv ciBQYW9sbydzIG5leHQgcHVsbCBnZXQgaW4sIHRoZW4gY29udGludWUgYmFzZWQgb24gdGhhdCwK PiBpbmNsdWRpbmcgUGFvbG8ncyAieDg2OiBhbGxvdyBidWlsZGluZyB3aXRob3V0IFBDIG1hY2hp bmUgdHlwZXMiIHNlcmllcy4KPiAKPiAoVGhhbmtzIFBhb2xvIGZvciBwaWNraW5nIG1vc3Qgb2Yg dGhpcyBzZXJpZXMhKQoKRldJVyBJIGRvbid0IHRoaW5rIGt2bV9pODI1OV9pbml0IHNob3VsZCBi ZSBpbiBzeXNlbXUva3ZtLmgsIHNpbmNlIGl0J3MKeDg2LXNwZWNpZmljIGFuZCB0aGF0IHdvdWxk IGJlIHNvbWV0aGluZyBsaWtlIHRoZSBzYW1lIG1pc3Rha2UgYWxyZWFkeQpkb25lIHdpdGggaHcv aTM4Ni9wYy5oLgoKUGFvbG8KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9q ZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVu LWRldmVs