From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54078C388F9 for ; Tue, 27 Oct 2020 20:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1147620725 for ; Tue, 27 Oct 2020 20:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pEIfSei7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2902133AbgJ0Uhe (ORCPT ); Tue, 27 Oct 2020 16:37:34 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:41253 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2900490AbgJ0Uhd (ORCPT ); Tue, 27 Oct 2020 16:37:33 -0400 Received: by mail-lf1-f67.google.com with SMTP id 126so4035630lfi.8; Tue, 27 Oct 2020 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7rp8OgTEAWtuKJtMNiLhS1/R8myCG5UhnRurxGX0itc=; b=pEIfSei7bmZJp5rQNKjGJ1YAY4mj3MLEzP+ie3m0TBYOMLJH4G156rMIn85hVZgEC1 azFPSR5gMLIbusPBB46uAK6oGubJ+1BkF77NXjCWGLnWAkNoBt02Urav3PHU/+4KC4Eb RnFp8H2pMwIzgCZYTHrP7GCG38Zc3IcYNEioxWgveaZAkVvFlJ5FapUc8FwkCMm/CKmK DHObifrr0wVW9tWM2qhI31qxKy3JhBeXM4lxJ7uTP6oz2+cQSJojV8p/CJTvl55n2yEA VeUheDR5E3sWn9aD/Tg5eEUkYSq/CeJ5tgW4k9h/t74Ag3xpXjjNcHkbray3nX03mPt0 1umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7rp8OgTEAWtuKJtMNiLhS1/R8myCG5UhnRurxGX0itc=; b=bruO25l9MQOnFtYT+0XWoLBEwj0/xVqahmCjaSWyZzlTkCI10dT5dPxP3vqcNtliv9 Ozw2s02BKHZ1jY9XGfXe2ILmxvIurHtGh113umbkNrUzmglr6Fqk3FP/zGnmoD7eIEQV faXJkNi5gV6rfEAoTAsKRg/ug97tc9U6q4kUqwtXu3NVRmkFt5hiawkcDeYAPcOPPg/9 N689WO+xmx6LXHWQaEwDms+pTD0O3huegL051vqk9mnJyaACcojDnthGCGPXIbsiwrcd 84yueCwApfCqTKvbMo4BlIdW1WHEdZWO/FgvE+mUWFWta4VNjA+EKDBlgBT849FpADSq 6+Ww== X-Gm-Message-State: AOAM531ZAaySDrSMZ4qs5pXUf82iwC3yXzAdcVr6IP99J7V5lNGykaJV RbYxMZbjkBFA8E7BOH40gJiMkywJErU= X-Google-Smtp-Source: ABdhPJym33W/chgtCjkXL4iuOZZNtixcgyiRRX4KlkNwIlFRpM3sMfAYENyAfUzTcy1uJQku22By8A== X-Received: by 2002:ac2:5207:: with SMTP id a7mr1416790lfl.56.1603831050126; Tue, 27 Oct 2020 13:37:30 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id l20sm162128lfc.274.2020.10.27.13.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 13:37:29 -0700 (PDT) Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property To: Krzysztof Kozlowski Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> <20201027193039.GA140636@kozik-lap> From: Dmitry Osipenko Message-ID: <90df8e53-6dec-f75f-5f82-539cb0f72583@gmail.com> Date: Tue, 27 Oct 2020 23:37:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027193039.GA140636@kozik-lap> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 27.10.2020 22:30, Krzysztof Kozlowski пишет: > On Tue, Oct 27, 2020 at 10:17:19PM +0300, Dmitry Osipenko wrote: >> 27.10.2020 11:54, Krzysztof Kozlowski пишет: >>> On Mon, Oct 26, 2020 at 01:16:47AM +0300, Dmitry Osipenko wrote: >>>> Tegra20 External Memory Controller talks to DRAM chips and it needs to be >>>> reprogrammed when memory frequency changes. Tegra Memory Controller sits >>>> behind EMC and these controllers are tightly coupled. This patch adds the >>>> new phandle property which allows to properly express connection of EMC >>>> and MC hardware in a device-tree, it also put the Tegra20 EMC binding on >>>> par with Tegra30+ EMC bindings, which is handy to have. >>>> >>>> Signed-off-by: Dmitry Osipenko >>>> --- >>>> .../bindings/memory-controllers/nvidia,tegra20-emc.txt | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt >>>> index 567cffd37f3f..1b0d4417aad8 100644 >>>> --- a/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt >>>> +++ b/Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt >>>> @@ -12,6 +12,7 @@ Properties: >>>> irrespective of ram-code configuration. >>>> - interrupts : Should contain EMC General interrupt. >>>> - clocks : Should contain EMC clock. >>>> +- nvidia,memory-controller : Phandle of the Memory Controller node. >>> >>> It looks like you adding a required property which is an ABI break. >> The T20 EMC driver is unused so far in upstream and it will become used >> only once this series is applied. Hence it's fine to change the ABI. > > The ABI is not about upstream, but downstream. There are no other > upstreams using this ABI. Unless you have in mind that existing T20 EMC > driver was a noop, doing absolutely nothing, therefore there is no > breakage of any other users? The T20 EMC driver was a 100% noop for now. It's safe to change the ABI. The T30/124 EMC drivers have users, but these are unsafe drivers (with the known issues) until this series is applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F5BC388F7 for ; Wed, 28 Oct 2020 08:07:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EEC020714 for ; Wed, 28 Oct 2020 08:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pEIfSei7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EEC020714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 407E46EC57; Wed, 28 Oct 2020 08:06:37 +0000 (UTC) Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by gabe.freedesktop.org (Postfix) with ESMTPS id D18676E0DD for ; Tue, 27 Oct 2020 20:37:31 +0000 (UTC) Received: by mail-lf1-x143.google.com with SMTP id l2so4110535lfk.0 for ; Tue, 27 Oct 2020 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7rp8OgTEAWtuKJtMNiLhS1/R8myCG5UhnRurxGX0itc=; b=pEIfSei7bmZJp5rQNKjGJ1YAY4mj3MLEzP+ie3m0TBYOMLJH4G156rMIn85hVZgEC1 azFPSR5gMLIbusPBB46uAK6oGubJ+1BkF77NXjCWGLnWAkNoBt02Urav3PHU/+4KC4Eb RnFp8H2pMwIzgCZYTHrP7GCG38Zc3IcYNEioxWgveaZAkVvFlJ5FapUc8FwkCMm/CKmK DHObifrr0wVW9tWM2qhI31qxKy3JhBeXM4lxJ7uTP6oz2+cQSJojV8p/CJTvl55n2yEA VeUheDR5E3sWn9aD/Tg5eEUkYSq/CeJ5tgW4k9h/t74Ag3xpXjjNcHkbray3nX03mPt0 1umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7rp8OgTEAWtuKJtMNiLhS1/R8myCG5UhnRurxGX0itc=; b=LGMWIiV4TFEVnjal7iTXTPX/573+rL2CifcmHFsiNmzu/4A77+YfYNQ4cevyuUyjsO htByN0ksH5HURDvzkoDvpvurZR6+vAYjMy3cNBxvlaDQxVnhthNPxTf8fRvYM+yDJhxX YGAuKDDIuVZguYPJntcFDHohpZAaFYUprAx0q/qMmWvmKWUUvRVT/hfZdzCLNvWogQJ9 ltHTJKwX8X1aSCwG1ds51RVjQJiWTzegoMKEGMaczEUibEgeX6fK4jFIS1XwzkG/QEvo FrCvOhR6xe7QoVsefHg8Yd3SyvlthwIBvpp4VCMsheb7iO2fJdCKIn0uN0cs50kkrkt6 w2zA== X-Gm-Message-State: AOAM530v9ZY8JbNIDIuRYdKeQw/vu6lxRtmo+TzNo1GZOqvs3LrcTJ2F XiV5CyV6e3tK+EOaZbsPkpg= X-Google-Smtp-Source: ABdhPJym33W/chgtCjkXL4iuOZZNtixcgyiRRX4KlkNwIlFRpM3sMfAYENyAfUzTcy1uJQku22By8A== X-Received: by 2002:ac2:5207:: with SMTP id a7mr1416790lfl.56.1603831050126; Tue, 27 Oct 2020 13:37:30 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id l20sm162128lfc.274.2020.10.27.13.37.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 13:37:29 -0700 (PDT) Subject: Re: [PATCH v6 04/52] dt-bindings: memory: tegra20: emc: Document nvidia,memory-controller property To: Krzysztof Kozlowski References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-5-digetx@gmail.com> <20201027085417.GD4244@kozik-lap> <54191034-dcb9-7cab-333b-5bb2553f0ed1@gmail.com> <20201027193039.GA140636@kozik-lap> From: Dmitry Osipenko Message-ID: <90df8e53-6dec-f75f-5f82-539cb0f72583@gmail.com> Date: Tue, 27 Oct 2020 23:37:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027193039.GA140636@kozik-lap> Content-Language: en-US X-Mailman-Approved-At: Wed, 28 Oct 2020 08:06:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjcuMTAuMjAyMCAyMjozMCwgS3J6eXN6dG9mIEtvemxvd3NraSDQv9C40YjQtdGCOgo+IE9uIFR1 ZSwgT2N0IDI3LCAyMDIwIGF0IDEwOjE3OjE5UE0gKzAzMDAsIERtaXRyeSBPc2lwZW5rbyB3cm90 ZToKPj4gMjcuMTAuMjAyMCAxMTo1NCwgS3J6eXN6dG9mIEtvemxvd3NraSDQv9C40YjQtdGCOgo+ Pj4gT24gTW9uLCBPY3QgMjYsIDIwMjAgYXQgMDE6MTY6NDdBTSArMDMwMCwgRG1pdHJ5IE9zaXBl bmtvIHdyb3RlOgo+Pj4+IFRlZ3JhMjAgRXh0ZXJuYWwgTWVtb3J5IENvbnRyb2xsZXIgdGFsa3Mg dG8gRFJBTSBjaGlwcyBhbmQgaXQgbmVlZHMgdG8gYmUKPj4+PiByZXByb2dyYW1tZWQgd2hlbiBt ZW1vcnkgZnJlcXVlbmN5IGNoYW5nZXMuIFRlZ3JhIE1lbW9yeSBDb250cm9sbGVyIHNpdHMKPj4+ PiBiZWhpbmQgRU1DIGFuZCB0aGVzZSBjb250cm9sbGVycyBhcmUgdGlnaHRseSBjb3VwbGVkLiBU aGlzIHBhdGNoIGFkZHMgdGhlCj4+Pj4gbmV3IHBoYW5kbGUgcHJvcGVydHkgd2hpY2ggYWxsb3dz IHRvIHByb3Blcmx5IGV4cHJlc3MgY29ubmVjdGlvbiBvZiBFTUMKPj4+PiBhbmQgTUMgaGFyZHdh cmUgaW4gYSBkZXZpY2UtdHJlZSwgaXQgYWxzbyBwdXQgdGhlIFRlZ3JhMjAgRU1DIGJpbmRpbmcg b24KPj4+PiBwYXIgd2l0aCBUZWdyYTMwKyBFTUMgYmluZGluZ3MsIHdoaWNoIGlzIGhhbmR5IHRv IGhhdmUuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBn bWFpbC5jb20+Cj4+Pj4gLS0tCj4+Pj4gIC4uLi9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMv bnZpZGlhLHRlZ3JhMjAtZW1jLnR4dCAgICAgICAgICB8IDIgKysKPj4+PiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtZW1j LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxl cnMvbnZpZGlhLHRlZ3JhMjAtZW1jLnR4dAo+Pj4+IGluZGV4IDU2N2NmZmQzN2YzZi4uMWIwZDQ0 MTdhYWQ4IDEwMDY0NAo+Pj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlhLHRlZ3JhMjAtZW1jLnR4dAo+Pj4+ICsrKyBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZW1vcnktY29udHJvbGxlcnMvbnZpZGlh LHRlZ3JhMjAtZW1jLnR4dAo+Pj4+IEBAIC0xMiw2ICsxMiw3IEBAIFByb3BlcnRpZXM6Cj4+Pj4g ICAgaXJyZXNwZWN0aXZlIG9mIHJhbS1jb2RlIGNvbmZpZ3VyYXRpb24uCj4+Pj4gIC0gaW50ZXJy dXB0cyA6IFNob3VsZCBjb250YWluIEVNQyBHZW5lcmFsIGludGVycnVwdC4KPj4+PiAgLSBjbG9j a3MgOiBTaG91bGQgY29udGFpbiBFTUMgY2xvY2suCj4+Pj4gKy0gbnZpZGlhLG1lbW9yeS1jb250 cm9sbGVyIDogUGhhbmRsZSBvZiB0aGUgTWVtb3J5IENvbnRyb2xsZXIgbm9kZS4KPj4+Cj4+PiBJ dCBsb29rcyBsaWtlIHlvdSBhZGRpbmcgYSByZXF1aXJlZCBwcm9wZXJ0eSB3aGljaCBpcyBhbiBB QkkgYnJlYWsuCj4+IFRoZSBUMjAgRU1DIGRyaXZlciBpcyB1bnVzZWQgc28gZmFyIGluIHVwc3Ry ZWFtIGFuZCBpdCB3aWxsIGJlY29tZSB1c2VkCj4+IG9ubHkgb25jZSB0aGlzIHNlcmllcyBpcyBh cHBsaWVkLiBIZW5jZSBpdCdzIGZpbmUgdG8gY2hhbmdlIHRoZSBBQkkuCj4gCj4gVGhlIEFCSSBp cyBub3QgYWJvdXQgdXBzdHJlYW0sIGJ1dCBkb3duc3RyZWFtLiBUaGVyZSBhcmUgbm8gb3RoZXIK PiB1cHN0cmVhbXMgdXNpbmcgdGhpcyBBQkkuIFVubGVzcyB5b3UgaGF2ZSBpbiBtaW5kIHRoYXQg ZXhpc3RpbmcgVDIwIEVNQwo+IGRyaXZlciB3YXMgYSBub29wLCBkb2luZyBhYnNvbHV0ZWx5IG5v dGhpbmcsIHRoZXJlZm9yZSB0aGVyZSBpcyBubwo+IGJyZWFrYWdlIG9mIGFueSBvdGhlciB1c2Vy cz8KClRoZSBUMjAgRU1DIGRyaXZlciB3YXMgYSAxMDAlIG5vb3AgZm9yIG5vdy4gSXQncyBzYWZl IHRvIGNoYW5nZSB0aGUgQUJJLgoKVGhlIFQzMC8xMjQgRU1DIGRyaXZlcnMgaGF2ZSB1c2Vycywg YnV0IHRoZXNlIGFyZSB1bnNhZmUgZHJpdmVycyAod2l0aAp0aGUga25vd24gaXNzdWVzKSB1bnRp bCB0aGlzIHNlcmllcyBpcyBhcHBsaWVkLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK