From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:44414 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755446Ab1BXO1e (ORCPT ); Thu, 24 Feb 2011 09:27:34 -0500 References: <9AA38BEC-4364-4F45-968B-E33BA5098C34@mattjan.us> <201101252229.35418.hverkuil@xs4all.nl> <4D666116.70605@redhat.com> <201102241451.30452.hverkuil@xs4all.nl> In-Reply-To: <201102241451.30452.hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: oops cx2341x control handler From: Andy Walls Date: Thu, 24 Feb 2011 09:27:17 -0500 To: Hans Verkuil , Mauro Carvalho Chehab CC: Matt Janus , linux-media@vger.kernel.org Message-ID: <90e0bfe3-57b6-4c65-8e2d-a18bd08b4459@email.android.com> List-ID: Sender: Hans Verkuil wrote: >On Thursday, February 24, 2011 14:45:58 Mauro Carvalho Chehab wrote: >> Em 25-01-2011 19:29, Hans Verkuil escreveu: >> > Hi Matt, >> > >> > On Tuesday, January 25, 2011 03:10:38 Matt Janus wrote: >> >> A quick test with mplayer didn't error, when i tried to use mythtv >the driver crashed and resulted in this: >> > >> > I could reproduce this and the fix is below. Please test! >> >> What's the status of this patch? Should it be applied or not? > >Absolutely! It's a nasty bug. > >Regards, > > Hans > >> >> Cheers, >> Mauro >> > >> > Regards, >> > >> > Hans >> > >> > From 6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f Mon Sep 17 00:00:00 >2001 >> > Message-Id: ><6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f.1295990866.git.hverkuil@xs4all.nl> >> > From: Hans Verkuil >> > Date: Tue, 25 Jan 2011 22:25:39 +0100 >> > Subject: [PATCH] cx18: fix kernel oops when setting MPEG control >before capturing. >> > >> > The cxhdl->priv field was not set initially, only after capturing >started. >> > >> > Signed-off-by: Hans Verkuil >> > --- >> > drivers/media/video/cx18/cx18-driver.c | 1 + >> > 1 files changed, 1 insertions(+), 0 deletions(-) >> > >> > diff --git a/drivers/media/video/cx18/cx18-driver.c >b/drivers/media/video/cx18/cx18-driver.c >> > index 869690b..877e201 100644 >> > --- a/drivers/media/video/cx18/cx18-driver.c >> > +++ b/drivers/media/video/cx18/cx18-driver.c >> > @@ -713,6 +713,7 @@ static int __devinit cx18_init_struct1(struct >cx18 *cx) >> > cx->cxhdl.capabilities = CX2341X_CAP_HAS_TS | >CX2341X_CAP_HAS_SLICED_VBI; >> > cx->cxhdl.ops = &cx18_cxhdl_ops; >> > cx->cxhdl.func = cx18_api_func; >> > + cx->cxhdl.priv = &cx->streams[CX18_ENC_STREAM_TYPE_MPG]; >> > ret = cx2341x_handler_init(&cx->cxhdl, 50); >> > if (ret) >> > return ret; >> >> > >-- >Hans Verkuil - video4linux developer - sponsored by Cisco >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" >in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Andy Walls