All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] DTS: ARM: OMAP5: uevm: add µSD card detect
@ 2017-05-15  8:31 H. Nikolaus Schaller
  2017-05-16 16:47 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: H. Nikolaus Schaller @ 2017-05-15  8:31 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring, Mark Rutland,
	Russell King
  Cc: letux-kernel, kernel, linux-omap, devicetree, linux-kernel,
	H. Nikolaus Schaller

If we have Linux installed in eMMC we can boot without
µSD card, but inserting one is not recognised.

The reason is that the card detect gpio (gpio5_152)
is not configured and attached to the mmc1 interface
driver and the mmc driver does not poll by default.

Hence we add pinmux and gpio setup for the SDCARD_NCD
signal.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap5-uevm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index d58b034513da..1a6e28c3d847 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -142,6 +142,13 @@
 	};
 };
 
+&mmc1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc1_pins>;
+
+	cd-gpios = <&gpio5 24 GPIO_ACTIVE_LOW>;	/* gpio5_152 */
+};
+
 &omap5_pmx_core {
 	evm_keys_pins: pinmux_evm_keys_gpio_pins {
 		pinctrl-single,pins = <
@@ -161,6 +168,12 @@
 			OMAP5_IOPAD(0x0a8, PIN_INPUT_PULLUP | MUX_MODE6)	/* gpio3_76 */
 		>;
 	};
+
+	mmc1_pins: pinmux_mmc1_pins {
+		pinctrl-single,pins = <
+			OMAP5_IOPAD(0x1d4, PIN_INPUT_PULLUP | MUX_MODE6)	/* gpio5_152 */
+		>;
+	};
 };
 
 &tpd12s015 {
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] DTS: ARM: OMAP5: uevm: add µSD card detect
  2017-05-15  8:31 [PATCH v4] DTS: ARM: OMAP5: uevm: add µSD card detect H. Nikolaus Schaller
@ 2017-05-16 16:47 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2017-05-16 16:47 UTC (permalink / raw)
  To: H. Nikolaus Schaller
  Cc: Benoît Cousson, Rob Herring, Mark Rutland, Russell King,
	letux-kernel, kernel, linux-omap, devicetree, linux-kernel

* H. Nikolaus Schaller <hns@goldelico.com> [170515 01:35]:
> If we have Linux installed in eMMC we can boot without
> µSD card, but inserting one is not recognised.
> 
> The reason is that the card detect gpio (gpio5_152)
> is not configured and attached to the mmc1 interface
> driver and the mmc driver does not poll by default.
> 
> Hence we add pinmux and gpio setup for the SDCARD_NCD
> signal.

Applying into omap-for-v4.13/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-16 16:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-15  8:31 [PATCH v4] DTS: ARM: OMAP5: uevm: add µSD card detect H. Nikolaus Schaller
2017-05-16 16:47 ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.