From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf] tools: bpf: fix NULL return handling in bpf__prepare_load Date: Tue, 15 May 2018 16:20:48 +0200 Message-ID: <90ea1b1c-26f5-3928-4897-536e576d2b4a@iogearbox.net> References: <20180511112142.23324-1-yuehaibing@huawei.com> <605c7b96-83dc-9a9e-7037-32b2c2dfcb2e@iogearbox.net> <20180515141143.GH2917@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: YueHaibing , alexander.shishkin@linux.intel.com, mingo@redhat.com, peterz@infradead.org, netdev@vger.kernel.org, namhyung@kernel.org To: Arnaldo Carvalho de Melo Return-path: Received: from www62.your-server.de ([213.133.104.62]:49537 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752568AbeEOOVB (ORCPT ); Tue, 15 May 2018 10:21:01 -0400 In-Reply-To: <20180515141143.GH2917@kernel.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/15/2018 04:11 PM, Arnaldo Carvalho de Melo wrote: > Em Sun, May 13, 2018 at 01:20:22AM +0200, Daniel Borkmann escreveu: >> [ +Arnaldo ] >> >> On 05/11/2018 01:21 PM, YueHaibing wrote: >>> bpf_object__open()/bpf_object__open_buffer can return error pointer or NULL, >>> check the return values with IS_ERR_OR_NULL() in bpf__prepare_load and >>> bpf__prepare_load_buffer >>> >>> Signed-off-by: YueHaibing >>> --- >>> tools/perf/util/bpf-loader.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> This should probably be routed via Arnaldo due to the fix in perf itself. If >> there's no particular preference on which tree, we could potentially route it >> as well via bpf with Acked-by from Arnaldo, but that is up to him. Arnaldo, >> any preference? > > I'm preparing a pull req right now, and working a bit on perf's BPF > support, so why not, I'll merge it, thanks, Sounds good, thanks Arnaldo! > - Arnaldo