From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EDB4C433FE for ; Wed, 12 Oct 2022 11:40:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5F410E02A; Wed, 12 Oct 2022 11:40:51 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1EDF10E02A for ; Wed, 12 Oct 2022 11:40:46 +0000 (UTC) Received: from [192.168.1.15] (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 863614D3; Wed, 12 Oct 2022 13:40:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665574845; bh=PoMLaUO3iyBb9Q+CXqh8cQQDeoGi91boQRGd4J0FeF4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hv8PP6D0a42nAn4AWOW4hYMJL3l4kKn9kZJAChIRsLp7xd3tCJllvTWPYgn914en5 Dc2/p4u3ltPEM1WAF+cWplz0d1ccg99WlA73S0hnCkcFtmJqiuPJuWuWIt3VfP1LX3 AF/VDcMAkFnFLB5o4NKDjwWSToajmoW64SFu5+EE= Message-ID: <90ef166f-fe36-e243-6eee-516500986c6f@ideasonboard.com> Date: Wed, 12 Oct 2022 14:40:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH v5 3/6] drm/tidss: Add support for AM625 DSS Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , Rob Herring , David Airlie , Daniel Vetter , Krzysztof Kozlowski References: <20220928175223.15225-1-a-bhatia1@ti.com> <20220928175223.15225-4-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20220928175223.15225-4-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Devicetree List , Vignesh Raghavendra , Linux Kernel List , DRI Development List , Rahul T R Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 28/09/2022 20:52, Aradhya Bhatia wrote: > Add support for the DSS controller on TI's new AM625 SoC in the tidss > driver. > > The first video port (VP0) in am625-dss can output OLDI signals through > 2 OLDI TXes. A 3rd port has been added with "DISPC_VP_OLDI" bus type. > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 61 ++++++++++++++++++++++++++++- > drivers/gpu/drm/tidss/tidss_dispc.h | 3 ++ > drivers/gpu/drm/tidss/tidss_drv.c | 1 + > 3 files changed, 64 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index dd3c6a606ae2..34f0da4bb3e3 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -93,6 +93,7 @@ const struct dispc_features dispc_k2g_feats = { > .common_regs = tidss_k2g_common_regs, > > .num_vps = 1, > + .num_max_ports = 1, I would just use "num_ports" here, as it describes the HW (e.g. we have num_vps = 4 for J7, even if we'd only use one of the VPs). I would also rename "TIDSS_MAX_PORTS". Maybe TIDSS_MAX_VPS. And check carefully that it's never used for the output ports. Or maybe this field should be "num_output_ports", and try to use "output port" term in the driver for the..., well, output ports, to make the distinction between the videoport and output port more clear. Tomi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57495C43217 for ; Wed, 12 Oct 2022 11:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229627AbiJLLk4 (ORCPT ); Wed, 12 Oct 2022 07:40:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiJLLkx (ORCPT ); Wed, 12 Oct 2022 07:40:53 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C03957894; Wed, 12 Oct 2022 04:40:48 -0700 (PDT) Received: from [192.168.1.15] (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 863614D3; Wed, 12 Oct 2022 13:40:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665574845; bh=PoMLaUO3iyBb9Q+CXqh8cQQDeoGi91boQRGd4J0FeF4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hv8PP6D0a42nAn4AWOW4hYMJL3l4kKn9kZJAChIRsLp7xd3tCJllvTWPYgn914en5 Dc2/p4u3ltPEM1WAF+cWplz0d1ccg99WlA73S0hnCkcFtmJqiuPJuWuWIt3VfP1LX3 AF/VDcMAkFnFLB5o4NKDjwWSToajmoW64SFu5+EE= Message-ID: <90ef166f-fe36-e243-6eee-516500986c6f@ideasonboard.com> Date: Wed, 12 Oct 2022 14:40:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [RFC PATCH v5 3/6] drm/tidss: Add support for AM625 DSS Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , Rob Herring , David Airlie , Daniel Vetter , Krzysztof Kozlowski Cc: Nishanth Menon , Vignesh Raghavendra , Rahul T R , DRI Development List , Devicetree List , Linux Kernel List References: <20220928175223.15225-1-a-bhatia1@ti.com> <20220928175223.15225-4-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20220928175223.15225-4-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/2022 20:52, Aradhya Bhatia wrote: > Add support for the DSS controller on TI's new AM625 SoC in the tidss > driver. > > The first video port (VP0) in am625-dss can output OLDI signals through > 2 OLDI TXes. A 3rd port has been added with "DISPC_VP_OLDI" bus type. > > Signed-off-by: Aradhya Bhatia > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 61 ++++++++++++++++++++++++++++- > drivers/gpu/drm/tidss/tidss_dispc.h | 3 ++ > drivers/gpu/drm/tidss/tidss_drv.c | 1 + > 3 files changed, 64 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index dd3c6a606ae2..34f0da4bb3e3 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -93,6 +93,7 @@ const struct dispc_features dispc_k2g_feats = { > .common_regs = tidss_k2g_common_regs, > > .num_vps = 1, > + .num_max_ports = 1, I would just use "num_ports" here, as it describes the HW (e.g. we have num_vps = 4 for J7, even if we'd only use one of the VPs). I would also rename "TIDSS_MAX_PORTS". Maybe TIDSS_MAX_VPS. And check carefully that it's never used for the output ports. Or maybe this field should be "num_output_ports", and try to use "output port" term in the driver for the..., well, output ports, to make the distinction between the videoport and output port more clear. Tomi