From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DCA3C433F5 for ; Mon, 20 Sep 2021 09:22:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F7E060F58 for ; Mon, 20 Sep 2021 09:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F7E060F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.190443.340262 (Exim 4.92) (envelope-from ) id 1mSFVE-0006an-8q; Mon, 20 Sep 2021 09:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 190443.340262; Mon, 20 Sep 2021 09:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFVE-0006ag-5R; Mon, 20 Sep 2021 09:22:20 +0000 Received: by outflank-mailman (input) for mailman id 190443; Mon, 20 Sep 2021 09:22:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mSFVD-0006aZ-ER for xen-devel@lists.xenproject.org; Mon, 20 Sep 2021 09:22:19 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3f8ea34c-19f4-11ec-b867-12813bfff9fa; Mon, 20 Sep 2021 09:22:17 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C9A5422075; Mon, 20 Sep 2021 09:22:16 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E1B413A81; Mon, 20 Sep 2021 09:22:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p7nYJMhSSGHWPQAAMHmgww (envelope-from ); Mon, 20 Sep 2021 09:22:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f8ea34c-19f4-11ec-b867-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1632129736; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oS03HDtKLKfHZjyM+5QbPlj+nBWvnzYfMe8HQgMTFdA=; b=GqYVrzoKEv8ooxuzEvmoSWZXLxYtDeuG8zjaevG1+I4DBR0boFFgwjaU90efz8JFitTuCG kSLbV23aulQ/bmSvisyTVB5sEnVv2jSKuUVMHN4DEU5bTwYm6qUrkYD8fpF5ZevAB4QK+/ Wo7MXud9i6SvjSWIJ6O1kO8IpAZKfgM= To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall References: <20210917154625.89315-1-roger.pau@citrix.com> <20210917154625.89315-5-roger.pau@citrix.com> From: Juergen Gross Subject: Re: [PATCH 4/6] tools/xenstored: use atexit to close interfaces Message-ID: <90f64a21-d5fc-fab3-2f3c-73de00421cb3@suse.com> Date: Mon, 20 Sep 2021 11:22:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210917154625.89315-5-roger.pau@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CqVaxyiOTWfZrucNpfGOhilOMvonvIArM" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CqVaxyiOTWfZrucNpfGOhilOMvonvIArM Content-Type: multipart/mixed; boundary="4zhg7M398UstSw5PtCmq64k9YCY8ST5nY"; protected-headers="v1" From: Juergen Gross To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Ian Jackson , Wei Liu , Julien Grall Message-ID: <90f64a21-d5fc-fab3-2f3c-73de00421cb3@suse.com> Subject: Re: [PATCH 4/6] tools/xenstored: use atexit to close interfaces References: <20210917154625.89315-1-roger.pau@citrix.com> <20210917154625.89315-5-roger.pau@citrix.com> In-Reply-To: <20210917154625.89315-5-roger.pau@citrix.com> --4zhg7M398UstSw5PtCmq64k9YCY8ST5nY Content-Type: multipart/mixed; boundary="------------2A7B7DE445A6071263267B5F" Content-Language: en-US This is a multi-part message in MIME format. --------------2A7B7DE445A6071263267B5F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 17.09.21 17:46, Roger Pau Monne wrote: > Exploiting the talloc clean up routines to close the Xen interfaces > is cumbersome, specially when atexit can be used to the same effect. >=20 > Convert xc and gnttab to use atexit which allows to drop one > indirection from the storing variables. >=20 > No functional change intended. >=20 > Signed-off-by: Roger Pau Monn=C3=A9 > --- > tools/xenstore/xenstored_core.h | 2 +- > tools/xenstore/xenstored_domain.c | 57 +++++++++++++-----------------= - > 2 files changed, 25 insertions(+), 34 deletions(-) >=20 > diff --git a/tools/xenstore/xenstored_domain.c b/tools/xenstore/xenstor= ed_domain.c > index 47e9107c14..8930303773 100644 > --- a/tools/xenstore/xenstored_domain.c > +++ b/tools/xenstore/xenstored_domain.c > @@ -737,35 +725,38 @@ void dom0_init(void) > xenevtchn_notify(xce_handle, dom0->port); > } > =20 > +void interface_cleanup(void) > +{ > + if (xc_handle) { > + xc_interface_close(xc_handle); > + xc_handle =3D NULL; > + } > + if (xgt_handle) { > + xengnttab_close(xgt_handle); > + xgt_handle =3D NULL; > + } Could you please add closing of xce_handle(), too? Juergen --------------2A7B7DE445A6071263267B5F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2A7B7DE445A6071263267B5F-- --4zhg7M398UstSw5PtCmq64k9YCY8ST5nY-- --CqVaxyiOTWfZrucNpfGOhilOMvonvIArM Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmFIUscFAwAAAAAACgkQsN6d1ii/Ey80 wQf/QeSaaesxhFHKUvVz4H+PTKY8l08BJ5TUEAfqwsVJpfxWm7BACP6o3Tdn6pAkcjSdzUtFIOAm DWokeeTh5c0CXpr5zT0E//C1ukx7kb6SDEf13XzaaJ7XXlINpidXd3GbqJAoadxVapeFv83/FQUL VhG6PUPHEmThR5EpNhr+9MaudxKhWjXdICk8gQFcdTHw5MQIdfANJ9QBeOmVU7aUqso3xEpGVeom kLBKOYg0obCcHNF2CBjR315fCU8n2bApxKlUOzYmxjGpyptSQXIgTUIk+ulcUkz9oqqQdIaW/Af2 hObPUeE89rtOMq5UTBb5aTydV5Wkz3ujJ104weJyEA== =FiVS -----END PGP SIGNATURE----- --CqVaxyiOTWfZrucNpfGOhilOMvonvIArM--