From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BA8C10DCE for ; Tue, 10 Mar 2020 21:47:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 324F4222C3 for ; Tue, 10 Mar 2020 21:47:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="TIyXZFh+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 324F4222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40999 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBmjC-0001Ka-4T for qemu-devel@archiver.kernel.org; Tue, 10 Mar 2020 17:47:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBmW6-0004RS-Oz for qemu-devel@nongnu.org; Tue, 10 Mar 2020 17:34:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBmW5-0001Bb-2m for qemu-devel@nongnu.org; Tue, 10 Mar 2020 17:34:22 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBmW4-0001B0-OV for qemu-devel@nongnu.org; Tue, 10 Mar 2020 17:34:21 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ALOQK8002907; Tue, 10 Mar 2020 21:34:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=Dy8VUMxMzXEryR/4XLShV3/+DUIanm1QrKp3jOze6yQ=; b=TIyXZFh+vKbUkHjSbneR+9Xk4dWx6ejC+cy9bHEGtt47wBzD8wWyqBxwFtPNcOd6TECw bfH2qJOT+FPY4Y35rVokcWHuKAiGfNxA+b9MlUslFtXaYSa4MAE+jbgKla/x2VuvRv0I WxGAFEv9m3pksmuNQlD/pZWVvpbGLTAt/OHuNvvRWN7s7b/qBPPzb0tJTqR47S0ExLt9 VS/SCjoXG6U/xkxc29/6wQxJbvgbMasEGRclqFUFC0HqRP+odQdLPAKHy7aMTgxaIGSR qvOIs1LnAsaxEpcoQhYvWWbi2fYjb8LgxwCKTp6FbdZEzxeN+3B3S5SqGxBAS6dw7nWD hw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2yp9v6390x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 21:34:18 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02ALYGTg173728; Tue, 10 Mar 2020 21:34:18 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2yp8pu5jsx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Mar 2020 21:34:17 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 02ALY4AY026110; Tue, 10 Mar 2020 21:34:04 GMT Received: from [192.168.14.112] (/79.181.212.171) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 10 Mar 2020 14:34:04 -0700 Subject: Re: [PATCH 05/14] hw/i386/vmport: Report VMX type in CMD_GETVERSION To: "Michael S. Tsirkin" References: <20200309235411.76587-1-liran.alon@oracle.com> <20200309235411.76587-6-liran.alon@oracle.com> <20200310081144-mutt-send-email-mst@kernel.org> <43b5d99e-70f2-39dc-1a12-e6c6d9e75d5a@oracle.com> <20200310082730-mutt-send-email-mst@kernel.org> <506ba498-ba50-9415-18b3-bcaff1561c55@oracle.com> <20200310084758-mutt-send-email-mst@kernel.org> <1f4766b2-9683-8ebf-752e-a0378bb0cbc3@oracle.com> <20200310094350-mutt-send-email-mst@kernel.org> <6d3c248f-f8fe-754d-59e5-8f2740a55263@oracle.com> <20200310133646-mutt-send-email-mst@kernel.org> From: Liran Alon Message-ID: <91053e38-8bd1-d316-acd0-561dfc016fd5@oracle.com> Date: Tue, 10 Mar 2020 23:34:00 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200310133646-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9556 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=908 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100127 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9556 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxlogscore=951 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003100127 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, Nikita Leshenko , pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/03/2020 23:16, Michael S. Tsirkin wrote: > On Tue, Mar 10, 2020 at 04:46:19PM +0200, Liran Alon wrote: >> There is no license issue here. It's only definitions. > So it seems that in your opinion > - definition names in the interface do not need a license > and > - it is fair to reuse them without a license for the purpose > of making your compatible interface easier to use for > people familiar with the original > > Did I get that right? I'm for sure not an expert on open source code licenses. You probably know this area much more than I do. But yes, this is what I would have thought. That it's not an issue to copy the enum definition. If I'm wrong and it is an issue, is declaring a new enum with new names not a license issue and can be done instead? Or am I only allowed to use hard-coded numbers, point to original code from where I deduced the number, and specify number meaning in comment? -Liran