From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 766DDCCA479 for ; Sat, 25 Jun 2022 20:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233382AbiFYUEW (ORCPT ); Sat, 25 Jun 2022 16:04:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233374AbiFYUEW (ORCPT ); Sat, 25 Jun 2022 16:04:22 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E79A7140BC for ; Sat, 25 Jun 2022 13:04:19 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id cw10so11261188ejb.3 for ; Sat, 25 Jun 2022 13:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=484IUMcow05iyV1q6ajSQK3ecgIAOqLkAvID94WbHbc=; b=xKKkluQB5W5jsjMGpvV4mWayJh3F87PZNANoAlbx1ANdQtwKrl0tFLSdSnt7PTz8q9 pourHAfc7ZlH8/92enAJ3nxTsh1n/eQnOYpOgN7a+B+uqVo4MVMFzGgUo88QeKLcZikg /7V0Jjsyw9gB73faVN6mAwwOrTMscQKhKjbF5PCoKPJJwTPMl6gA/8ebrwwlMcuvHBWw fC4hmtaNENs0rNgrz1wmwij7uWQ8/mIYA2S0hU2j3VQcnTtdR1wh/A0W37igzjhy2yqd jq9jdDG4j+7o6CQmtNgBbiMV/kWkzu+PVjc+stDbYngDv5Laq9bjrlDDv2dgs9h4fHc2 iAGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=484IUMcow05iyV1q6ajSQK3ecgIAOqLkAvID94WbHbc=; b=YNGMRI0ZqIhxUUh4pyObMSe2lcoyX78+pMpgH5P3GRZwFJeA+3W1VBF4oxRU76jG1V esNIvqufk/wdQtTxfa8/ji7SNeBzEFhcCypNcBwWmrlr5GHHWsc9g+sjYMov61Ii6MwP mCfd1NhNiV0afkiaD1NCFtXgPoeh/TITMJtbamxbeEyzp6N0sA8xFkTaKVYAWe5Yxajf 3OjRKlpJngrs7ISBWzfJDS653fJjXset5ye8J88bvrOBjwBj4BLnlXTXQHsQSvOBztJn A3lzyQFZfqdCyiJ1Vc4pxW7cPRVm9BRrv+CdA2yLhkWiznNwNyoFGkinGgR2J0adLfOj NZUQ== X-Gm-Message-State: AJIora+SN+auumQ/p2mjHMCKpji7W37C/giB6hgwlZt6Pe1Ryqx59Ssg 5DKgYqH7InzTAGLkiEuHmcy11Q== X-Google-Smtp-Source: AGRyM1vAHJsB0fQVRjAcZCjkgpVQmm2apAqr3ltjCElkOyYJUzZB1QBiv4XLi9yN/SstZ0ELo/1w+w== X-Received: by 2002:a17:907:7256:b0:722:e5a8:e3a3 with SMTP id ds22-20020a170907725600b00722e5a8e3a3mr5296645ejc.599.1656187458520; Sat, 25 Jun 2022 13:04:18 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id f8-20020a056402150800b0043578cf97d0sm4579259edw.23.2022.06.25.13.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jun 2022 13:04:18 -0700 (PDT) Message-ID: <9116badb-32c2-3727-6037-fd87b45af4b8@linaro.org> Date: Sat, 25 Jun 2022 22:04:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v13 4/5] arm64: dts: qcom: sc7180: Add pazquel dts files Content-Language: en-US To: Doug Anderson , "Joseph S. Barrera III" Cc: LKML , Alexandru M Stan , Stephen Boyd , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm References: <20220625022716.683664-1-joebar@chromium.org> <20220624192643.v13.4.I41e2c2dc12961fe000ebc4d4ef6f0bc5da1259ea@changeid> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 25/06/2022 16:45, Doug Anderson wrote: > Hi, > > On Fri, Jun 24, 2022 at 7:28 PM Joseph S. Barrera III > wrote: >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index e55dbaa6dc12..69cd4b3b911b 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -11,6 +11,12 @@ >> #include >> #include >> >> +#ifdef __SC7180_TROGDOR_DTSI__ >> +#error "Duplicate include" >> +#else >> +#define __SC7180_TROGDOR_DTSI__ >> +#endif >> + > > I'm not convinced about the need for this. That being said: We have several DTSI files included by several different boards. Some are describing board (in a common way), some only common subset of board or SoC. In none of the cases we include such include guard, so why is this one different? Best regards, Krzysztof