From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0214FC433F5 for ; Sat, 23 Oct 2021 10:10:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4C9760F02 for ; Sat, 23 Oct 2021 10:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230366AbhJWKMi (ORCPT ); Sat, 23 Oct 2021 06:12:38 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:34502 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230140AbhJWKMh (ORCPT ); Sat, 23 Oct 2021 06:12:37 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B81FF21961; Sat, 23 Oct 2021 10:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1634983817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+YuMhNQ8yWz/x0r4XI9OAcaAghuZAgWukacs9DP7j0=; b=TAZYv5FwU93lDOrq8p4IYks3IhezUk2qXsRdbVbyZ25Jwkb/KU1r9aYaGwrOaIvQ0TU2WK WhGi0/tEZGCG805HyATiUk2yUxEWCOyBSW5NbRSvVqoJ/mC1RgKYR2Ngsk3qt9gUn5sKFy bHkZ4YctBrr2KHDhuTRIS9zUaDK6sbo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6FC601332F; Sat, 23 Oct 2021 10:10:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MbbCF4nfc2E9VAAAMHmgww (envelope-from ); Sat, 23 Oct 2021 10:10:17 +0000 Subject: Re: 5.14.9 aarch64 OOPS Workqueue: btrfs-delalloc btrfs_work_helper To: Chris Murphy Cc: Su Yue , Qu Wenruo , Qu Wenruo , Btrfs BTRFS References: <7de9iylb.fsf@damenly.su> <35owijrm.fsf@damenly.su> <9e746c1c-85e5-c766-26fa-a4d83f1bfd34@suse.com> From: Nikolay Borisov Message-ID: <91185758-fdaf-f8da-01eb-a9932734fc09@suse.com> Date: Sat, 23 Oct 2021 13:09:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 22.10.21 г. 20:18, Chris Murphy wrote: > On Fri, Oct 22, 2021 at 7:43 AM Nikolay Borisov wrote: >> >> I also looked at the assembly generated in async_cow_submit to see if >> anything funny happens while the async_chunk->inode check is performed - >> everything looks fine. Also given that the extents list is empty and the >> inode is NULL I'd assume that the "write" side is also correct i.e the >> code in async_cow_start. This pretty much excludes a codegen problem. >> >> Chris can you add the following line in submit_compressed_extents right >> before the BTRFS_I() function is called: >> >> WARN_ON(!async_chunk->inode); >> >> And re-run the workload again? > > I'll look into how we can do this. I build kernels per > https://kernelnewbies.org/KernelBuild but maybe it's better to do it > within Fedora infrastructure to keep things more the same and > reproducible? I'm not really sure, so I've asked in the bug > https://bugzilla.redhat.com/show_bug.cgi?id=2011928#c41 - if you have > two cents to add let me know in this thread or that one. > > Any other configs to change while we're building a new kernel? > CONFIG_BTRFS_ASSERT=y ? > > inode.c > 849:static noinline void submit_compressed_extents(struct async_chunk > *async_chunk) > 850-{ > 851- struct btrfs_inode *inode = BTRFS_I(async_chunk->inode); > > becomes > > 849:static noinline void submit_compressed_extents(struct async_chunk > *async_chunk) > 850-{ > 851- WARN_ON(!async_chunk->inode); > 852- struct btrfs_inode *inode = BTRFS_I(async_chunk->inode); > > ? > (I'm looking at 5.15-rc6) Yes. > > >