All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikas Manocha <vikas.manocha@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE
Date: Wed, 5 Apr 2017 09:12:02 -0700	[thread overview]
Message-ID: <911c23df-1740-7b8b-0261-77c3c2047756@st.com> (raw)
In-Reply-To: <CAPnjgZ3TPo7P0kbuyB-oR_rpgrg4g5VMQr9XcwnWrdTr7ct6cQ@mail.gmail.com>

Hi Simon,

On 04/04/2017 08:27 PM, Simon Glass wrote:
> Hi Vikas,
> 
> On 4 April 2017 at 15:59, Vikas Manocha <vikas.manocha@st.com> wrote:
>> Address translation is not working at present even if SPL_OF_TRANSLATE is
>> enabled which makes this configuration useless. This patch enables address
>> translation for SPL U-Boot when SPL_OF_TRANSLATE is selected.
>>
>> Signed-off-by: Vikas Manocha <vikas.manocha@st.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v3: changed "u-boot" to "U-Boot" in commit message.
>> Changes in v2: Added commit message
>>
>>  lib/fdtdec.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
>> index 81f47ef..a1c4d16 100644
>> --- a/lib/fdtdec.c
>> +++ b/lib/fdtdec.c
>> @@ -112,7 +112,7 @@ fdt_addr_t fdtdec_get_addr_size_fixed(const void *blob, int node,
>>                 return FDT_ADDR_T_NONE;
>>         }
>>
>> -#if !defined(CONFIG_SPL_BUILD) && defined(CONFIG_OF_LIBFDT)
>> +#if defined(CONFIG_SPL_OF_TRANSLATE) || defined(CONFIG_OF_LIBFDT)
>>         if (translate)
>>                 addr = fdt_translate_address(blob, node, prop_addr);
>>         else
>> --
>> 1.9.1
>>
> 
> Actually I'm a bit unsure about this patch. You already have a patch applied:
> 
> 5efa1bf libfdt: use CONFIG_IS_ENABLED for OF_LIBFDT


This patch(5efa1bf) was recently applied & serves the same purpose.
We can ignore my patch.

Cheers,
Vikas

> 
> Do you actually want this one else well? If so, please resend it as it
> conflicts.
> 
> Regards,
> Simon
> .
> 

      reply	other threads:[~2017-04-05 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 21:59 [U-Boot] [PATCH v3] fdt: allow address translation in case of SPL_OF_TRANSLATE Vikas Manocha
2017-04-05  3:27 ` Simon Glass
2017-04-05 16:12   ` Vikas Manocha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911c23df-1740-7b8b-0261-77c3c2047756@st.com \
    --to=vikas.manocha@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.