All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Bitan Biswas <bbiswas@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Shardar Mohammed <smohammed@nvidia.com>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Mantravadi Karthik <mkarthik@nvidia.com>
Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects
Date: Thu, 30 May 2019 14:43:05 +0300	[thread overview]
Message-ID: <911e52ed-8f3c-583a-7610-e38723219eca@gmail.com> (raw)
In-Reply-To: <e9e3d8b0-a76a-81a9-1110-2d07ba1c787f@gmail.com>

30.05.2019 14:36, Dmitry Osipenko пишет:
> 30.05.2019 9:14, Bitan Biswas пишет:
>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
>> except for BUG/BUG_ON checks
> 
> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
> hence there is absolutely no good reason in making system unusable on a
> software bug. BUG_ON may be more useful for development, but not for a
> casual daily usage.
> 
>> Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
>> ---
> 
>> @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
>>  	u32 *buffer = NULL;
>>  	int err = 0;
>>  	bool dma;
>> -	u16 xfer_time = 100;
>> +	u16 xfer_tm = 100;
> 
> What's wrong with the "time"? I'm finding the "xfer_tm" as a very
> unintuitive naming.
> 

Also, please don't version patch as v2 if v1 was never sent out.

  reply	other threads:[~2019-05-30 11:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30  6:14 [PATCH V2] drivers: i2c: tegra: fix checkpatch defects Bitan Biswas
2019-05-30  6:14 ` Bitan Biswas
2019-05-30 11:36 ` Dmitry Osipenko
2019-05-30 11:43   ` Dmitry Osipenko [this message]
2019-05-31  9:04     ` Bitan Biswas
2019-05-31  9:04       ` Bitan Biswas
2019-05-31 12:45       ` Dmitry Osipenko
2019-06-06  6:24         ` Bitan Biswas
2019-06-06  6:24           ` Bitan Biswas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911e52ed-8f3c-583a-7610-e38723219eca@gmail.com \
    --to=digetx@gmail.com \
    --cc=bbiswas@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkarthik@nvidia.com \
    --cc=skomatineni@nvidia.com \
    --cc=smohammed@nvidia.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.