From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6110AC432BE for ; Wed, 1 Sep 2021 08:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A4F56103A for ; Wed, 1 Sep 2021 08:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243200AbhIAIVd (ORCPT ); Wed, 1 Sep 2021 04:21:33 -0400 Received: from lb2-smtp-cloud9.xs4all.net ([194.109.24.26]:54405 "EHLO lb2-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243072AbhIAIVa (ORCPT ); Wed, 1 Sep 2021 04:21:30 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id LLTumbxEylQKhLLTvmHxed; Wed, 01 Sep 2021 10:20:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1630484430; bh=GfCHqSZv2nZlr8KsNnFiMZi9+oWhMPoyCqpwjG+OdiE=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=cevdEFABsVf5kVrWj4kTmLhuAArUTVho1wy+fLzKmWs63SXLDvGQwrAyVtVDNHE08 NbJxU7ydFxjX8MfoNyolX2QvEMOXIkWasr+PeFdtnmcGAE48blnE8HVoiuZS8xNLos Socp/WsGnBRArsGpcXUwwqpk/391O4MT3IXrIdaE6itCG3i9UABvInj5a+i+3n6eTS uivaZKfWMipq3NoYlxpAjWFsYBSNSda0OJ6QvIFB0W7c9JZMgUqbP8sxczsaCrqADy 1482EOrWQYiuiIX3QJ7nAlvO+Zenvb3DIGq3QdJ7BVwGPklDUvE9cEYFDGg8x3ZAMZ YaIWuBiFE37lA== Subject: Re: [PATCH] media: sti/c8sectpfe: Make use of the helper function devm_platform_ioremap_resource_byname() To: Cai Huoqing Cc: Patrice Chotard , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901055631.7829-1-caihuoqing@baidu.com> From: Hans Verkuil Message-ID: <91245ea5-215f-5e60-0a97-7c29ceb7c3a9@xs4all.nl> Date: Wed, 1 Sep 2021 10:20:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210901055631.7829-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfJRoayrIqmcHfdDz2ck/bNwHScVxGGQWvquTGIyrIs576AcabdctUNUbGEj+i494562eYjGHj0UVa70tJWJuO4uud54+g/wh83pgODOiGDexGiuBjZtO nMkD4naXo1NJR9paGA7PLOzwL+EwM0v0onjBBBs4Idu0huK9cyQT2OE5TzFADN11hscON0n2uglKXcknJWvzGeQ+7LPT171ViNY9XFR0TgFqoZ59AEfHYr/z dPn1Bnfks5usPN4SVihU2fH6JH2lFsNHL6n5lWWZwwNYJL/OuT8owx2rpzr8A1Q9Q13z0nvmYOsGCU2q3Tkhn4L1DTqMz/CLLCLHA0GcC+szcwSSw4NwvL+3 u88IE8f99yhumFwJXnQ4N+zwkBxgBkyHj0KpEm7g6Edd53zgXZOKzNmHndDYnm1jM6Sk8gyqEEhrIdqEsiJ7qgqZL7ErY2Api+QjQmz6yOfEPGyijIQZlwAj 1Rdqg+R7kn3AVMoR Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2021 07:56, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource_byname() helper instead of > calling platform_get_resource_byname() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing > --- > drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > index 02dc78bd7fab..9f05984f711a 100644 > --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c > @@ -665,7 +665,6 @@ static int c8sectpfe_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct device_node *child, *np = dev->of_node; > struct c8sectpfei *fei; > - struct resource *res; > int ret, index = 0; > struct channel_info *tsin; > > @@ -676,14 +675,11 @@ static int c8sectpfe_probe(struct platform_device *pdev) > > fei->dev = dev; > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "c8sectpfe"); > - fei->io = devm_ioremap_resource(dev, res); > + fei->io = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe"); > if (IS_ERR(fei->io)) > return PTR_ERR(fei->io); > > - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "c8sectpfe-ram"); > - fei->sram = devm_ioremap_resource(dev, res); > + fei->sram = devm_platform_ioremap_resource_byname(pdev, "c8sectpfe-ram"); > if (IS_ERR(fei->sram)) > return PTR_ERR(fei->sram); > > Compile error: drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c: In function ‘c8sectpfe_probe’: drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: error: ‘res’ undeclared (first use in this function); did you mean ‘ret’? 686 | fei->sram_size = resource_size(res); | ^~~ | ret drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:686:33: note: each undeclared identifier is reported only once for each function it appears in Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9A9C432BE for ; Wed, 1 Sep 2021 09:01:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C42E3604AC for ; Wed, 1 Sep 2021 09:01:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C42E3604AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KEJmT2i6tDP19nQZnzm3pF5UMMCz8xQRgk2anwrPdJ4=; b=ee2GAc1J9IMi/M6yYX9Np7Cjqe UN1Gy+4nvNwMzNEZDIYegryXHQOg1CZwaqQhMr0/KrZ/1k7oLajaYiGwOC1IzdbfSJMIHmwxWyTY+ ZU9AWdIyKyMADXh3pE4Zj6oPrxTCkI4I/3F2ojpb+jIXRMV7sTcoZBJpnneYOONnSRugR3DHTt8/o 2Gijdt/EZ0YlITS01GNFF0ThnU15pkIQKIPRclI7gVTCoRIvRQCWV8jNCd/ON9XkwLg2cm29egzEB PqHiNl6UOs8YLHZjdFrtDEgSj91dF+WIVu/Dqeekv3i1DTRZYFBLIisnpIeIMwIiSjvlY2cEuwWg5 /Ur4P9jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLM4x-004hpP-DY; Wed, 01 Sep 2021 08:58:44 +0000 Received: from lb2-smtp-cloud9.xs4all.net ([2001:888:0:108::2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLLUH-004XkE-Py for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 08:20:53 +0000 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id LLTumbxEylQKhLLTvmHxed; Wed, 01 Sep 2021 10:20:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1630484430; bh=GfCHqSZv2nZlr8KsNnFiMZi9+oWhMPoyCqpwjG+OdiE=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=cevdEFABsVf5kVrWj4kTmLhuAArUTVho1wy+fLzKmWs63SXLDvGQwrAyVtVDNHE08 NbJxU7ydFxjX8MfoNyolX2QvEMOXIkWasr+PeFdtnmcGAE48blnE8HVoiuZS8xNLos Socp/WsGnBRArsGpcXUwwqpk/391O4MT3IXrIdaE6itCG3i9UABvInj5a+i+3n6eTS uivaZKfWMipq3NoYlxpAjWFsYBSNSda0OJ6QvIFB0W7c9JZMgUqbP8sxczsaCrqADy 1482EOrWQYiuiIX3QJ7nAlvO+Zenvb3DIGq3QdJ7BVwGPklDUvE9cEYFDGg8x3ZAMZ YaIWuBiFE37lA== Subject: Re: [PATCH] media: sti/c8sectpfe: Make use of the helper function devm_platform_ioremap_resource_byname() To: Cai Huoqing Cc: Patrice Chotard , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901055631.7829-1-caihuoqing@baidu.com> From: Hans Verkuil Message-ID: <91245ea5-215f-5e60-0a97-7c29ceb7c3a9@xs4all.nl> Date: Wed, 1 Sep 2021 10:20:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210901055631.7829-1-caihuoqing@baidu.com> Content-Language: en-US X-CMAE-Envelope: MS4xfJRoayrIqmcHfdDz2ck/bNwHScVxGGQWvquTGIyrIs576AcabdctUNUbGEj+i494562eYjGHj0UVa70tJWJuO4uud54+g/wh83pgODOiGDexGiuBjZtO nMkD4naXo1NJR9paGA7PLOzwL+EwM0v0onjBBBs4Idu0huK9cyQT2OE5TzFADN11hscON0n2uglKXcknJWvzGeQ+7LPT171ViNY9XFR0TgFqoZ59AEfHYr/z dPn1Bnfks5usPN4SVihU2fH6JH2lFsNHL6n5lWWZwwNYJL/OuT8owx2rpzr8A1Q9Q13z0nvmYOsGCU2q3Tkhn4L1DTqMz/CLLCLHA0GcC+szcwSSw4NwvL+3 u88IE8f99yhumFwJXnQ4N+zwkBxgBkyHj0KpEm7g6Edd53zgXZOKzNmHndDYnm1jM6Sk8gyqEEhrIdqEsiJ7qgqZL7ErY2Api+QjQmz6yOfEPGyijIQZlwAj 1Rdqg+R7kn3AVMoR X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_012050_036122_70404756 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDEvMDkvMjAyMSAwNzo1NiwgQ2FpIEh1b3Fpbmcgd3JvdGU6Cj4gVXNlIHRoZSBkZXZtX3Bs YXRmb3JtX2lvcmVtYXBfcmVzb3VyY2VfYnluYW1lKCkgaGVscGVyIGluc3RlYWQgb2YKPiBjYWxs aW5nIHBsYXRmb3JtX2dldF9yZXNvdXJjZV9ieW5hbWUoKSBhbmQgZGV2bV9pb3JlbWFwX3Jlc291 cmNlKCkKPiBzZXBhcmF0ZWx5Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2FpIEh1b3FpbmcgPGNhaWh1 b3FpbmdAYmFpZHUuY29tPgo+IC0tLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3N0aS9jOHNl Y3RwZmUvYzhzZWN0cGZlLWNvcmUuYyB8IDggKystLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9zdGkvYzhzZWN0cGZlL2M4c2VjdHBmZS1jb3JlLmMgYi9kcml2ZXJzL21l ZGlhL3BsYXRmb3JtL3N0aS9jOHNlY3RwZmUvYzhzZWN0cGZlLWNvcmUuYwo+IGluZGV4IDAyZGM3 OGJkN2ZhYi4uOWYwNTk4NGY3MTFhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZv cm0vc3RpL2M4c2VjdHBmZS9jOHNlY3RwZmUtY29yZS5jCj4gKysrIGIvZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9zdGkvYzhzZWN0cGZlL2M4c2VjdHBmZS1jb3JlLmMKPiBAQCAtNjY1LDcgKzY2NSw2 IEBAIHN0YXRpYyBpbnQgYzhzZWN0cGZlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ICAJc3RydWN0IGRldmlj ZV9ub2RlICpjaGlsZCwgKm5wID0gZGV2LT5vZl9ub2RlOwo+ICAJc3RydWN0IGM4c2VjdHBmZWkg KmZlaTsKPiAtCXN0cnVjdCByZXNvdXJjZSAqcmVzOwo+ICAJaW50IHJldCwgaW5kZXggPSAwOwo+ ICAJc3RydWN0IGNoYW5uZWxfaW5mbyAqdHNpbjsKPiAgCj4gQEAgLTY3NiwxNCArNjc1LDExIEBA IHN0YXRpYyBpbnQgYzhzZWN0cGZlX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gIAo+ICAJZmVpLT5kZXYgPSBkZXY7Cj4gIAo+IC0JcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291 cmNlX2J5bmFtZShwZGV2LCBJT1JFU09VUkNFX01FTSwgImM4c2VjdHBmZSIpOwo+IC0JZmVpLT5p byA9IGRldm1faW9yZW1hcF9yZXNvdXJjZShkZXYsIHJlcyk7Cj4gKwlmZWktPmlvID0gZGV2bV9w bGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAiYzhzZWN0cGZlIik7Cj4gIAlp ZiAoSVNfRVJSKGZlaS0+aW8pKQo+ICAJCXJldHVybiBQVFJfRVJSKGZlaS0+aW8pOwo+ICAKPiAt CXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZV9ieW5hbWUocGRldiwgSU9SRVNPVVJDRV9NRU0s Cj4gLQkJCQkJImM4c2VjdHBmZS1yYW0iKTsKPiAtCWZlaS0+c3JhbSA9IGRldm1faW9yZW1hcF9y ZXNvdXJjZShkZXYsIHJlcyk7Cj4gKwlmZWktPnNyYW0gPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBf cmVzb3VyY2VfYnluYW1lKHBkZXYsICJjOHNlY3RwZmUtcmFtIik7Cj4gIAlpZiAoSVNfRVJSKGZl aS0+c3JhbSkpCj4gIAkJcmV0dXJuIFBUUl9FUlIoZmVpLT5zcmFtKTsKPiAgCj4gCgpDb21waWxl IGVycm9yOgoKZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zdGkvYzhzZWN0cGZlL2M4c2VjdHBmZS1j b3JlLmM6IEluIGZ1bmN0aW9uIOKAmGM4c2VjdHBmZV9wcm9iZeKAmToKZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9zdGkvYzhzZWN0cGZlL2M4c2VjdHBmZS1jb3JlLmM6Njg2OjMzOiBlcnJvcjog4oCY cmVz4oCZIHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlzIGZ1bmN0aW9uKTsgZGlkIHlvdSBt ZWFuIOKAmHJldOKAmT8KICA2ODYgfCAgZmVpLT5zcmFtX3NpemUgPSByZXNvdXJjZV9zaXplKHJl cyk7CiAgICAgIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn4KICAgICAgfCAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldApkcml2ZXJzL21lZGlhL3BsYXRmb3Jt L3N0aS9jOHNlY3RwZmUvYzhzZWN0cGZlLWNvcmUuYzo2ODY6MzM6IG5vdGU6IGVhY2ggdW5kZWNs YXJlZCBpZGVudGlmaWVyIGlzIHJlcG9ydGVkIG9ubHkgb25jZSBmb3IgZWFjaCBmdW5jdGlvbiBp dCBhcHBlYXJzIGluCgpSZWdhcmRzLAoKCUhhbnMKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK