From: Martin Doucha <mdoucha@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_rtnetlink: pass error codes using rtnl_errno variable
Date: Tue, 22 Jun 2021 18:17:37 +0200 [thread overview]
Message-ID: <912a58e4-3c05-4de0-6346-7cfa80f6fbd4@suse.cz> (raw)
In-Reply-To: <871r8t6frr.fsf@suse.de>
On 22. 06. 21 18:11, Richard Palethorpe wrote:
> Hello Martin,
>
> Martin Doucha <mdoucha@suse.cz> writes:
>> +extern int rtnl_errno;
>
> This is polluting the name space. I suppose it can be prepended
> with tst_, but does the test author need to see this? Or you could even
> just merge tst_netdevice and tst_rtnetlink.
>
> Otherwise I think this approach is fine.
You're right, I should have prefixed it with tst_. I'll send v2 in a moment.
Yes, test authors will need to access this variable if they want to use
RTNL_CHECK_ACKS() or RTNL_SEND_VALIDATE() in their tests.
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
prev parent reply other threads:[~2021-06-22 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 15:48 [LTP] [PATCH] tst_rtnetlink: pass error codes using rtnl_errno variable Martin Doucha
2021-06-22 16:11 ` Richard Palethorpe
2021-06-22 16:17 ` Martin Doucha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=912a58e4-3c05-4de0-6346-7cfa80f6fbd4@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.