From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9FABC43387 for ; Wed, 19 Dec 2018 10:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DFCD21873 for ; Wed, 19 Dec 2018 10:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728997AbeLSKb7 (ORCPT ); Wed, 19 Dec 2018 05:31:59 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:9526 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727066AbeLSKb6 (ORCPT ); Wed, 19 Dec 2018 05:31:58 -0500 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJAVJlu025689; Wed, 19 Dec 2018 11:31:36 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2pcr8xw6dx-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 19 Dec 2018 11:31:36 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 05A9D34; Wed, 19 Dec 2018 10:31:35 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag6node3.st.com [10.75.127.18]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D36411686; Wed, 19 Dec 2018 10:31:35 +0000 (GMT) Received: from SFHDAG6NODE3.st.com (10.75.127.18) by SFHDAG6NODE3.st.com (10.75.127.18) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 19 Dec 2018 11:31:35 +0100 Received: from SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6]) by SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6%20]) with mapi id 15.00.1347.000; Wed, 19 Dec 2018 11:31:35 +0100 From: Patrice CHOTARD To: Russell King - ARM Linux CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup Thread-Topic: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup Thread-Index: AQHUluC8wzYjRbliykengwL93mfzKqWElOMAgAAUSoCAAAZLAIABHgkA Date: Wed, 19 Dec 2018 10:31:35 +0000 Message-ID: <913263b2-7421-5174-2e7d-5a15df40e51e@st.com> References: <1545144493-11600-1-git-send-email-patrice.chotard@st.com> <20181218155239.GP26090@n2100.armlinux.org.uk> <20181218172748.GQ26090@n2100.armlinux.org.uk> In-Reply-To: <20181218172748.GQ26090@n2100.armlinux.org.uk> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-19_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgUnVzc2VsbA0KDQpPbiAxMi8xOC8xOCA2OjI3IFBNLCBSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggd3JvdGU6DQo+IE9uIFR1ZSwgRGVjIDE4LCAyMDE4IGF0IDA1OjA1OjE4UE0gKzAwMDAsIFBh dHJpY2UgQ0hPVEFSRCB3cm90ZToNCj4+IEhpIFJ1c3NlbGwNCj4+DQo+PiBPbiAxMi8xOC8xOCA0 OjUyIFBNLCBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3JvdGU6DQo+Pj4gT24gVHVlLCBEZWMg MTgsIDIwMTggYXQgMDM6NDg6MTNQTSArMDEwMCwgcGF0cmljZS5jaG90YXJkQHN0LmNvbSB3cm90 ZToNCj4+Pj4gRnJvbTogUGF0cmljZSBDaG90YXJkIDxwYXRyaWNlLmNob3RhcmRAc3QuY29tPg0K Pj4+Pg0KPj4+PiBEdWUgdG8gcGVuX3JlbGVhc2UgYW5kIGJvb3RfbG9jayByZW1vdmFsLCBzZWNv bmRhcnkgQ1BVJ3MgYnJpbmd1cA0KPj4+PiB3YXMgYnJva2VuLiBSZXN0b3JlIENQVSdzIGJyaW5n dXAgYnkgcmV3b3JraW5nIHByb3Blcmx5DQo+Pj4+IC5zbXBfcHJlcGFyZV9jcHVzIGFuZCAuc21w X2Jvb3Rfc2Vjb25kYXJ5IFNUaSBjYWxsYmFja3MuDQo+Pj4NCj4+PiBTb3JyeSwgbWF5YmUgSSBk b24ndCB1bmRlcnN0YW5kIHlvdXIgY29tbWl0IG1lc3NhZ2UsIGJ1dCB5b3Ugc2VlbSB0byBiZQ0K Pj4+IHNheWluZyB0aGF0IHJlbW92YWwgb2YgdGhlIHBlbl9yZWxlYXNlIGFuZCBib290X2xvY2sg YnJva2UgU1RpJ3Mgc2Vjb25kYXJ5DQo+Pj4gQ1BVIGJyaW5nIHVwPyAgUGxlYXNlIGNsYXJpZnks IGFuZCBleHBsYWluIGhvdyB0aGF0IGhhcHBlbmVkLg0KPj4NCj4+IENvcnJlY3QsIENQVTEgZmFp bGVkIHRvIGNvbWUgb25saW5lLg0KPj4NCj4+IEl0IHNlZW1zIHRoYXQgd3JpdGluZyBzZWNvbmRh cnlfc3RhcnR1cCBhZGRyZXNzIGF0IGNwdS1yZWxlYXNlLWFkZHIgaW4NCj4+IC5zbXBfcHJlcGFy ZV9jcHVzIGNhbGxiYWNrIHdhcyB0b28gZWFybHkuDQo+Pg0KPj4gRG9pbmcgaXQgaW4gLnNtcF9i b290X3NlY29uZGFyeSBjYWxsYmFjaywgaW5zdXJlcyB0aGF0IHNlY29uZGFyeV9kYXRhDQo+PiBz dHJ1Y3QgaXMgcG9wdWxhdGVkIGluIF9fY3B1X3VwKCkgKHN0YWNrLCBwZ2RpciBhbmQgc3dhcHBl cl9wZ19kaXIgZmllbGRzKS4NCj4gDQo+IEFoLCB5b3UncmUgc2F5aW5nIHRoYXQgaXQgY2F1c2Vz IHRoZSBDUFUgdG8ganVtcCB0byBzZWNvbmRhcnlfc3RhcnR1cA0KPiB3aGlsZSB0aGUgYm9vdCBD UFUgaXMgaW4gc21wX3ByZXBhcmVfY3B1cygpPyAgV2hhdCB0cmlnZ2VycyB0aGUgQ1BVDQoNClll cw0KDQo+IHRvIGp1bXAgdG8gdGhlIGFkZHJlc3Mgd3JpdHRlbiB0byBjcHVfc3RydF9wdHI/ICBX aGF0IHlvdSdyZSBzYXlpbmcNCj4gc2VlbXMgdG8gc3VnZ2VzdCB0aGF0IGl0J3MgdGhlIHdyaXRl IHRvIHRoYXQgYWRkcmVzcywgcmF0aGVyIHRoYW4gdGhlDQo+IElQSSB0aGF0J3Mgc2VudCBpbiBz dGlfYm9vdF9zZWNvbmRhcnkoKS4NCg0KQXQgcGxhdGZvcm0gc3RhcnR1cCwgYW4gVS1Cb290cm9t IGZpcm13YXJlIGluaXRpYWxpemUgc2Vjb25kYXJ5IENQVSBhbmQNCm1ha2UgaXQgc3Bpbm5pbmcg d2FpdGluZyBmb3IgYSBqdW1wIGFkZHJlc3MgdG8gYmUgd3JpdHRlbiBhdCBjcHVfc3RydF9wdHIu DQoNCkkgZGlkbid0IHBheSBhdHRlbnRpb24gdG8gdGhlIElQSSwgeW91IGFyZSByaWdodCBJUEkg aXMgdXNlbGVzcywgaSB3aWxsDQpyZW1vdmUgaXQuDQoNCj4gDQo+IElmIHRoZSBJUEkgaW4gc3Rp X2Jvb3Rfc2Vjb25kYXJ5KCkgaXNuJ3QgZG9pbmcgYW55dGhpbmcsIGl0IG91Z2h0IHRvDQo+IGJl IHJlbW92ZWQuICBJdCdkIGFsc28gYmUgYSBnb29kIGlkZWEgdG8gZG9jdW1lbnQgd2hhdCdzIGdv aW5nIG9uIGFzDQo+IGNvbW1lbnRzIGluIHRoZSBjb2RlIGZvciBmdXR1cmUgbWFpbnRhbmVuY2Uu DQoNCkFncmVlLCBpIHdpbGwgYWRkIGEgY29tbWVudC4NCg0KVGhhbmtzDQoNClBhdHJpY2UNCg0K PiANCj4+IElmIHlvdSBhcmUgb2ssIGkgd2lsbCBwaWNrIHVwIHlvdXIgcGF0Y2ggWzFdIGFuZCB0 aGlzIG9uZSB0byBwcmVwYXJlIGENCj4+IFNUaSBwdWxsLXJlcXVlc3QuDQo+IA0KPiBZZXMsIGFs dGhvdWdoIEknbGwgaGF2ZSB0byBkZWxheSBwYXRjaCA5IGFzIGEgcmVzdWx0Lg0KPiA= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E136DC43612 for ; Wed, 19 Dec 2018 10:32:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 941CB218A6 for ; Wed, 19 Dec 2018 10:32:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jZu/m28B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 941CB218A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IdXR8gTokhSxW+B2nl0g1GyUfAlVc9wfwakaiiohdjM=; b=jZu/m28BO69PXy QQiBS1Llpa7nvg7yAOYD/Q8uxud6GlSiI1Ubw4c5bzg/a6QU0oywsKx0ctT7EMaqzS3zc33opfyW1 wODJW1Jti+u9U2dYBP8mItHlP8NByb/Ss3PozwqTCR/aRyjnt0ahYaxAIrXj6l9A+p1QcwQ1Q8bGK 7GUT6AzUZQju8QOsSc7Xh6f45XVkSzfeVtzIFfviLoFnjjZBqVGBNejKbbkieNpOLXJmcycP26sbK hoQ7UiO0BnRNGLMp2UZo4dBEGBrWhbNfgKmXw4vrIMnLuW9ExfEovTjWjItG3gsaMvK2MhP33RcY8 5Ym1uRj9KkLY02fhuIWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZZ8v-0003Nz-Qi; Wed, 19 Dec 2018 10:31:57 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZZ8s-0003Mw-1C for linux-arm-kernel@lists.infradead.org; Wed, 19 Dec 2018 10:31:56 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJAVJlu025689; Wed, 19 Dec 2018 11:31:36 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2pcr8xw6dx-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 19 Dec 2018 11:31:36 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 05A9D34; Wed, 19 Dec 2018 10:31:35 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag6node3.st.com [10.75.127.18]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D36411686; Wed, 19 Dec 2018 10:31:35 +0000 (GMT) Received: from SFHDAG6NODE3.st.com (10.75.127.18) by SFHDAG6NODE3.st.com (10.75.127.18) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 19 Dec 2018 11:31:35 +0100 Received: from SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6]) by SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6%20]) with mapi id 15.00.1347.000; Wed, 19 Dec 2018 11:31:35 +0100 From: Patrice CHOTARD To: Russell King - ARM Linux Subject: Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup Thread-Topic: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup Thread-Index: AQHUluC8wzYjRbliykengwL93mfzKqWElOMAgAAUSoCAAAZLAIABHgkA Date: Wed, 19 Dec 2018 10:31:35 +0000 Message-ID: <913263b2-7421-5174-2e7d-5a15df40e51e@st.com> References: <1545144493-11600-1-git-send-email-patrice.chotard@st.com> <20181218155239.GP26090@n2100.armlinux.org.uk> <20181218172748.GQ26090@n2100.armlinux.org.uk> In-Reply-To: <20181218172748.GQ26090@n2100.armlinux.org.uk> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-19_06:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181219_023154_365121_5E37BFE9 X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell On 12/18/18 6:27 PM, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 05:05:18PM +0000, Patrice CHOTARD wrote: >> Hi Russell >> >> On 12/18/18 4:52 PM, Russell King - ARM Linux wrote: >>> On Tue, Dec 18, 2018 at 03:48:13PM +0100, patrice.chotard@st.com wrote: >>>> From: Patrice Chotard >>>> >>>> Due to pen_release and boot_lock removal, secondary CPU's bringup >>>> was broken. Restore CPU's bringup by reworking properly >>>> .smp_prepare_cpus and .smp_boot_secondary STi callbacks. >>> >>> Sorry, maybe I don't understand your commit message, but you seem to be >>> saying that removal of the pen_release and boot_lock broke STi's secondary >>> CPU bring up? Please clarify, and explain how that happened. >> >> Correct, CPU1 failed to come online. >> >> It seems that writing secondary_startup address at cpu-release-addr in >> .smp_prepare_cpus callback was too early. >> >> Doing it in .smp_boot_secondary callback, insures that secondary_data >> struct is populated in __cpu_up() (stack, pgdir and swapper_pg_dir fields). > > Ah, you're saying that it causes the CPU to jump to secondary_startup > while the boot CPU is in smp_prepare_cpus()? What triggers the CPU Yes > to jump to the address written to cpu_strt_ptr? What you're saying > seems to suggest that it's the write to that address, rather than the > IPI that's sent in sti_boot_secondary(). At platform startup, an U-Bootrom firmware initialize secondary CPU and make it spinning waiting for a jump address to be written at cpu_strt_ptr. I didn't pay attention to the IPI, you are right IPI is useless, i will remove it. > > If the IPI in sti_boot_secondary() isn't doing anything, it ought to > be removed. It'd also be a good idea to document what's going on as > comments in the code for future maintanence. Agree, i will add a comment. Thanks Patrice > >> If you are ok, i will pick up your patch [1] and this one to prepare a >> STi pull-request. > > Yes, although I'll have to delay patch 9 as a result. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel