From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/3] librte_reorder: New reorder library
Date: Thu, 29 Jan 2015 17:35:09 +0000
Message-ID: <91383E96CE459D47BCE92EFBF5CE73B004F43DE1@IRSMSX108.ger.corp.intel.com>
References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com>
 <9416100.1lhCgRCuAQ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>, "Pattan, Reshma"
 <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <9416100.1lhCgRCuAQ@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Thomas,

> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, January 20, 2015 8:01 AM
> To: Pattan, Reshma
> Cc: dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library
>=20
> Hi,
>=20
> 2015-01-07 16:39, Reshma Pattan:
> >             1)New library to provide reordering of out of ordered
> >             mbufs based on sequence number of mbuf. Library uses reorde=
r
> buffer structure
> >             which in tern uses two circular buffers called ready and or=
der buffers.
> >             *rte_reorder_create API creates instance of reorder buffer.
> >             *rte_reorder_init API initializes given reorder buffer inst=
ance.
> >             *rte_reorder_reset API resets given reorder buffer instance=
.
> >             *rte_reorder_insert API inserts the mbuf into order circula=
r buffer.
> >             *rte_reorder_fill_overflow moves mbufs from order buffer to=
 ready
> buffer
> >             to accomodate early packets in order buffer.
> >             *rte_reorder_drain API provides draining facility to fetch =
out
> >             reordered mbufs from order and ready buffers.
> >
> >         Signed-off-by: Reshma Pattan <reshma.pattan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >         Signed-off-by: Richardson Bruce <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>=20
> I think 2 things are missing in this patchset:
>=20
> 1) Could you show some performance numbers to compare a simple
> forwarding with and without this library, in the commit log?
>=20
I'm not allowed to provide specific performance numbers.
I could try to give some kind of relative performance estimate (%), but any=
one else is free to provide those numbers.

> 2) Could you add some documentation in doc/ directory for programmer's
> guide?
>=20
I'll be sending a v2 shortly with a new entry for the programmers guide.

Thank you,
Sergio

> Thank you
> --
> Thomas