Re: [PATCH v3] rdma: Add bind option

From: Jens Axboe <axboe@kernel.dk>
To: Sitsofe Wheeler <sitsofe@gmail.com>, Stephen Bates <sbates@raithlin.com>
Cc: "fio@vger.kernel.org" <fio@vger.kernel.org>,
	"logang@deltatee.com" <logang@deltatee.com>,
	"elliott@hpe.com" <elliott@hpe.com>
Subject: Re: [PATCH v3] rdma: Add bind option
Date: Wed, 22 Nov 2017 13:15:44 -0700	[thread overview]
Message-ID: <9142459b-2a3e-bedb-794d-c150a64598fd@kernel.dk> (raw)
In-Reply-To: <CALjAwxjW3grF90L-5tksdtK4u-6fM5_2Y2Cqf7e02Hz0yjBa4w@mail.gmail.com>

On 11/22/2017 01:13 PM, Sitsofe Wheeler wrote:
> On 22 November 2017 at 18:01, Stephen  Bates <sbates@raithlin.com> wrote:
>>> In certain configurations it can be useful to bind a rdma_cm to a
>>> particular network interface. For example in multi-path or loopback.
>>>
>>> Add a bindname option that the local rdma_cm will try and bind too.
>>>
>>> The bind code is based off that used in rping [1].
>>>
>>> [1] https://github.com/linux-rdma/rdma-core/blob/ \
>>>    master/librdmacm/examples/rping.c
>>>
>>> Signed-off-by: Stephen Bates <sbates@raithlin.com>
>>> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>>
>>
>> Hi Jens
>>
>> Do you have any concerns or issues with this patch?
> 
> One quick suggestion - any chance you could update the HOWTO and fio.1
> documentation to include the new ioengine parameter?

Thanks Sitsofe, I somehow missed this. Yes, those options should be added
to the engine specific options in both those files.

-- 
Jens Axboe