Re: [PATCH 42/56] fscache: Convert fscache_set_page_dirty() to fscache_dirty_folio()

[John Hubbard <jhubbard@nvidia.com>]

On 2/9/22 12:22, Matthew Wilcox (Oracle) wrote:
> Convert all users of fscache_set_page_dirty to use fscache_dirty_folio.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
>   .../filesystems/caching/netfs-api.rst         |  7 +++--
>   fs/9p/vfs_addr.c                              | 10 +++----
>   fs/afs/file.c                                 |  2 +-
>   fs/afs/internal.h                             |  4 +--
>   fs/afs/write.c                                |  5 ++--
>   fs/ceph/addr.c                                | 27 +++++++++---------
>   fs/ceph/cache.h                               | 13 +++++----
>   fs/cifs/file.c                                | 11 ++++----
>   fs/fscache/io.c                               | 28 ++++++++++---------
>   include/linux/fscache.h                       |  8 ++++--
>   10 files changed, 61 insertions(+), 54 deletions(-)
> 

Hi Matthew,

I was just reading through this in case my pin_user_pages() changes
had any overlap (I think not), and noticed a build issue, below.

...
>   static inline int ceph_begin_cache_operation(struct netfs_read_request *rreq)
> @@ -133,9 +133,10 @@ static inline void ceph_fscache_unpin_writeback(struct inode *inode,
>   {
>   }
>   
> -static inline int ceph_fscache_set_page_dirty(struct page *page)
> +static inline int ceph_fscache_dirty_folio(struct address_space *mapping,
> +		struct folio *folio)
>   {
> -	return __set_page_dirty_nobuffers(page);
> +	return filemap_dirty_folio(folio);

I believe that should be:

	return filemap_dirty_folio(mapping, folio);


thanks,
-- 
John Hubbard
NVIDIA