From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (unknown [209.85.212.172]) by mail.openembedded.org (Postfix) with ESMTP id DCEA360897 for ; Fri, 9 May 2014 05:59:59 +0000 (UTC) Received: by mail-wi0-f172.google.com with SMTP id hi2so774908wib.17 for ; Thu, 08 May 2014 23:00:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=NKbJbGmA0+3bLUrtVGax04KK5fbLd2EPOjYNA8evEZw=; b=ZSDbCZ8JRXjnchnr22lSmCOSzs8fesqtiXG3dOQn1pf9U+MoQU76URP0YLOsDIXv/n vEEM4n28ja8X4Ur+7qwa3G4c9jLJ0d/8SzY8IgVuNBYsb3rkxORfdVT0cWpUiInfhM5R IiTV1P9ixFCp86ev1FDozVfGyjInCs+y0JTim6LySmuEkKiS8iPC4tPCVLhn++7viEQQ ZsHgLrPfmjv3sfDgbTc+Cphz3/tpp7pWJono4uC9NqicBCUtq4CS4VHKAxj3QpgV822q aICIjXnj9ny2gsstozHKjep8Z6+csWOxyaaw11oryMi9GMyl+FqQ0Lfo2NLMOfdcuDSR ijfQ== X-Gm-Message-State: ALoCoQnWuD3CJffteQyeEwJJZ3gxQQ4X6E1jbB7Us4huXxe3p0XzMgvKDcuJpwWD9in/eEdJhMxe X-Received: by 10.194.91.175 with SMTP id cf15mr6738559wjb.5.1399615199959; Thu, 08 May 2014 22:59:59 -0700 (PDT) Received: from ?IPv6:2001:610:612::c98c:c22d:ccab:585? ([2001:610:612:0:c98c:c22d:ccab:585]) by mx.google.com with ESMTPSA id kp5sm4102716wjb.30.2014.05.08.22.59.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 08 May 2014 22:59:59 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) From: Koen Kooi In-Reply-To: <7A042294-2122-4EA0-BE1F-68E0BB65512D@dominion.thruhere.net> Date: Fri, 9 May 2014 07:59:56 +0200 Message-Id: <916F5AEB-85EC-4CE0-8771-79F7467D6A86@dominion.thruhere.net> References: <1399019818-4767-1-git-send-email-koen.kooi@linaro.org> <536BB2C0.60903@linux.intel.com> <7A042294-2122-4EA0-BE1F-68E0BB65512D@dominion.thruhere.net> To: Saul Wold X-Mailer: Apple Mail (2.1874) Cc: Koen Kooi , openembedded-core@lists.openembedded.org Subject: Re: [PATCHv4] git: fix perl binding installation X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 06:00:00 -0000 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Op 8 mei 2014, om 19:30 heeft Koen Kooi het = volgende geschreven: >=20 > Op 8 mei 2014, om 18:37 heeft Saul Wold het = volgende geschreven: >=20 >> On 05/02/2014 01:36 AM, Koen Kooi wrote: >>> Git.pm wasn't ending up in the package because do_install removed it >>> with a misleading comment about multilib. Workaround the problem so >>> that Git.pm ends up in the correct dir *and* doesn't get deleted. >>>=20 >>=20 >> Seems to be a problem as RP was concerned with: >>=20 >>=20 >>> /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/bin/git difftool >>> Can't locate Error.pm in @INC (@INC contains: = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/perl-native/perl/5= .14.3 = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/perl-native/perl//= 5.14.3 = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/perl-native/perl/ = /srv/ssd/machines/meta-intel-iot-devkit/build/tmp/sysroots/x86_64-linux/us= r/lib/perl-native/perl/5.14.3 .) at = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/git/git-core/git-d= ifftool line 17. >>> BEGIN failed--compilation aborted at = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/git/git-core/git-d= ifftool line 17. >>=20 >> Doing a find in my sysroot: >>=20 >> = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/perl-native/perl/5= .14.3/CPANPLUS/Error.pm >> = /srv/ssd/builds/world/tmp/sysroots/x86_64-linux/usr/lib/perl/5.14.3/Error.= pm >=20 > Drat, I checked for buildpaths and didn't find anything. I'll retest = and send a new version hopefully tomorrow. I need to read errors better :) Do you have = http://patches.openembedded.org/patch/70635/ applied? And did 'difftool' = work before this? None of the perl tools worked for me due to error.pm = missing. >=20 > regards, >=20 > Koen >=20 >>=20 >> Sau! >>=20 >>=20 >>> Signed-off-by: Koen Kooi >>> --- >>> meta/recipes-devtools/git/git.inc | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>>=20 >>> diff --git a/meta/recipes-devtools/git/git.inc = b/meta/recipes-devtools/git/git.inc >>> index 73e11eb..178b768 100644 >>> --- a/meta/recipes-devtools/git/git.inc >>> +++ b/meta/recipes-devtools/git/git.inc >>> @@ -28,10 +28,14 @@ do_install () { >>> template_dir=3D${datadir}/git-core/templates \ >>> GIT_PYTHON_DIR=3D${D}${datadir}/git-core/python >>>=20 >>> + cd ${B}/perl && oe_runmake install DESTDIR=3D"${D}" = bindir=3D${bindir} >>> + >>> # ${libdir} is not applicable here, perl-native files are always >>> # installed to /usr/lib on both 32/64 bits targets. >>> + # Fix up build paths and point to target locations. >>> + mv ${D}${exec_prefix}/lib/perl-native/perl = ${D}${exec_prefix}/lib/perl >>> + sed -i -e s:${D}::g = ${D}${exec_prefix}/lib/perl/*/auto/Git/.packlist >>> rm -rf ${D}${exec_prefix}/lib/perl-native >>> - rmdir ${D}${exec_prefix}/lib || true >>> } >>>=20 >>> PERLSEDFIXUP =3D " \ >>> @@ -75,6 +79,7 @@ PERLTOOLS =3D " \ >>> PACKAGES =3D+ "${PN}-perltools" >>> FILES_${PN}-perltools +=3D " \ >>> ${PERLTOOLS} \ >>> + ${prefix}/lib/perl \ >>> ${datadir}/perl \ >>> " >>> RDEPENDS_${PN}-perltools =3D "${PN} perl perl-module-file-path = liberror-perl findutils"