From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFDBC07E99 for ; Mon, 5 Jul 2021 17:07:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBC0F6196C for ; Mon, 5 Jul 2021 17:07:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBC0F6196C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0S3z-00040T-MW for qemu-devel@archiver.kernel.org; Mon, 05 Jul 2021 13:07:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0S1I-0001Bv-Ho for qemu-devel@nongnu.org; Mon, 05 Jul 2021 13:04:32 -0400 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]:33700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0S1G-0001kp-WB for qemu-devel@nongnu.org; Mon, 05 Jul 2021 13:04:32 -0400 Received: by mail-qt1-x833.google.com with SMTP id w13so12675234qtc.0 for ; Mon, 05 Jul 2021 10:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=lyZ006BpTP0Cg0029ChDj40RT2X+XZOXlDQR2fqBnh8=; b=vJFJwUQMW6FzYiG4Sni2H0KOlLNF22xu4tG6Eq9J7ywnvY7t9tAEXKj8b/ULqnc2Ia cklY7VoTU7eDFglaN/n7juvxKaQe4bPPV5tHxL36DCIAVoLT27zOzRV/n9MVN0q6kkFl 3gJ0up92kNTtdKuHqkcDDidDV9wvxMyEQA/zLkHgreMB8V/mjUb1NcyDVqqL9I3upF9G 9/CET1QGVPtCq0pliXV11kx3b1IgIb0qpP2XysOE1fQnEbMPL2uC4MNX7l2XxdNmZ8Fn dguFyKKTuTNqDzumKlJNxBfaD9BQVNhKcc6Fxoor01h43Vq1VXSMaFy7if2Vrd4YI6Uu zN4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=lyZ006BpTP0Cg0029ChDj40RT2X+XZOXlDQR2fqBnh8=; b=FFBJuPcq7OgRDXf4DpKZXBTryPuvpBmJe3HFGChHSgN4cuvNAErPU2QThHj/xTUYQq Ds+tenBXhNKyqxgj11E7o2G139fMyRF62S7aXXuKXxwfadAxQKfoTSTVAr7ip8gpu08M 8utzHZ65MwNUpjn3Nst4SeVNy0z5Cbi7KBUC5jYNDVjjAoigLnraQPYQCfh3akcOhVOX KBlTYK/1ZWJ3W4KR65xt7Foy2PFWamAuaauQKr4YyWHrxnlVnsYyVoAmuBJVbj+tmbd3 qRY9uvE0JmxIlix7VajWdfZD4m0KMOP1K/zrYuOA2meIBePaovw6XUkSWXgCj5wXwP/w toyQ== X-Gm-Message-State: AOAM532o577qjcrHJj9XnIbTAw3vfdBzcbzIBkb+Oc1sSdiVlJwcW3NC a9Lgs95ICkSH6ZRFr9TbRf9Bmg== X-Google-Smtp-Source: ABdhPJwq3jvIcCmSoAx6bq3diCKe0bnwvG7jW8c27PL6ZzHkkeEU3vXOXgzKZSour3q8KC44s/ADYQ== X-Received: by 2002:ac8:674d:: with SMTP id n13mr10600618qtp.381.1625504669191; Mon, 05 Jul 2021 10:04:29 -0700 (PDT) Received: from localhost.localdomain (bras-base-stsvon1503w-grc-22-142-114-143-47.dsl.bell.ca. [142.114.143.47]) by smtp.gmail.com with ESMTPSA id x14sm3394174qta.90.2021.07.05.10.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jul 2021 10:04:28 -0700 (PDT) Message-ID: <916a2c2eb368835dbd17fe0b90be541abbebde93.camel@linaro.org> Subject: Re: [PATCH v5 01/10] hw/intc: GICv3 ITS initial framework From: shashi.mallela@linaro.org To: Peter Maydell Date: Mon, 05 Jul 2021 13:04:27 -0400 In-Reply-To: References: <20210630153156.9421-1-shashi.mallela@linaro.org> <20210630153156.9421-2-shashi.mallela@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-16.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=shashi.mallela@linaro.org; helo=mail-qt1-x833.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Radoslaw Biernacki , QEMU Developers , qemu-arm , Igor Mammedov , Leif Lindholm Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 2021-07-05 at 17:25 +0100, Peter Maydell wrote: > On Mon, 5 Jul 2021 at 16:55, wrote: > > On Mon, 2021-07-05 at 15:58 +0100, Peter Maydell wrote: > > > On Wed, 30 Jun 2021 at 16:32, Shashi Mallela < > > > shashi.mallela@linaro.org> wrote: > > > > Added register definitions relevant to ITS,implemented overall > > > > ITS device framework with stubs for ITS control and translater > > > > regions read/write,extended ITS common to handle mmio init > > > > between > > > > existing kvm device and newer qemu device. > > > > > > > > Signed-off-by: Shashi Mallela > > > > Reviewed-by: Peter Maydell > > > > +static void gicv3_arm_its_realize(DeviceState *dev, Error > > > > **errp) > > > > +{ > > > > + GICv3ITSState *s = ARM_GICV3_ITS_COMMON(dev); > > > > + > > > > + gicv3_its_init_mmio(s, &gicv3_its_control_ops, > > > > &gicv3_its_translation_ops); > > > > + > > > > + if (s->gicv3->cpu->gicr_typer & GICR_TYPER_PLPIS) { > > > > > > Can you remind me why we make this check, please? When would we > > > have created an ITS device but not have a GICv3 with LPI support? > > This check applies to GIC's physical LPI support only as against > > GIC's > > virtual LPI support. > > Right, but when would we have a GIC with no physical LPI support > but an ITS is present ? If we only support Direct injection of virtual interrupts (which can have their own vPEID and the vPE table),then the ITS present could havejust virtual LPI support > > thanks > -- PMM