From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32B2C433FE for ; Tue, 8 Nov 2022 19:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229725AbiKHTp0 (ORCPT ); Tue, 8 Nov 2022 14:45:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiKHTpV (ORCPT ); Tue, 8 Nov 2022 14:45:21 -0500 Received: from smtpout.efficios.com (smtpout.efficios.com [IPv6:2607:5300:203:5aae::31e5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 519D31D654; Tue, 8 Nov 2022 11:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1667936717; bh=N9FGx501778vNVrOHYv7pAKWQyx42YqgfZDZQz7Kpgk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k3iNJAuKTFU1zCZs/molOCmMlgz/rjg/gx2J96nBs8Qmowxl5/5/XbzmM8ddiN31j HH4vY1V+Uxx11sHIUyU0mRQmfs0aMLSZ5a/hDbv13H4spU7VQ8qf8+L/eIZWvDnQ6N gZlzjsswfTAW1xCXAv7yESvj2OK11CO1cnMXGS9n2glgaqwBEkIBADosDHvorRPBwl nf+qFoDKxJndZCKSQczBv5XFZUTh3oSyQyJxyTvL1kBrAuE05fxgs5r+fvXxkMOCp1 QER9Qns99zg8tw80p/vMPMxUTTon9pMOpqjOGnuM1kh53FKdiK+OBDXP+4MLO/tg01 RlnUMNIryPV9Q== Received: from [172.16.0.153] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4N6JV51LvbzgHZ; Tue, 8 Nov 2022 14:45:17 -0500 (EST) Message-ID: <916c7a1f-fddd-77d6-6f91-6d3c196e1d86@efficios.com> Date: Tue, 8 Nov 2022 14:45:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v5 08/24] sched: Introduce per memory space current virtual cpu id Content-Language: en-US To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , "Paul E . McKenney" , Boqun Feng , "H . Peter Anvin" , Paul Turner , linux-api@vger.kernel.org, Christian Brauner , Florian Weimer , David.Laight@aculab.com, carlos@redhat.com, Peter Oskolkov , Alexander Mikhalitsyn , Chris Kennelly References: <20221103200359.328736-1-mathieu.desnoyers@efficios.com> <20221103200359.328736-9-mathieu.desnoyers@efficios.com> From: Mathieu Desnoyers In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-11-08 08:00, Peter Zijlstra wrote: > On Thu, Nov 03, 2022 at 04:03:43PM -0400, Mathieu Desnoyers wrote: > >> diff --git a/fs/exec.c b/fs/exec.c >> index 349a5da91efe..93eb88f4053b 100644 >> --- a/fs/exec.c >> +++ b/fs/exec.c >> @@ -1013,6 +1013,9 @@ static int exec_mmap(struct mm_struct *mm) >> tsk->active_mm = mm; >> tsk->mm = mm; >> lru_gen_add_mm(mm); >> + mm_init_vcpu_lock(mm); >> + mm_init_vcpumask(mm); >> + mm_init_node_vcpumask(mm); >> /* >> * This prevents preemption while active_mm is being loaded and >> * it and mm are being updated, which could cause problems for > >> @@ -1150,6 +1154,9 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p, >> >> mm->user_ns = get_user_ns(user_ns); >> lru_gen_init_mm(mm); >> + mm_init_vcpu_lock(mm); >> + mm_init_vcpumask(mm); >> + mm_init_node_vcpumask(mm); >> return mm; >> >> fail_nocontext: > > Why isn't all that a single mm_init_vcpu(mm) or something ? Good point, I'll update that. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com