Re: [PATCH 3/4] drm/amdgpu: Make amdgpu_vram_mgr_bo_invisible_size always accurate

From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	"Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 3/4] drm/amdgpu: Make amdgpu_vram_mgr_bo_invisible_size always accurate
Date: Mon, 18 Jun 2018 13:30:37 +0200	[thread overview]
Message-ID: <91723ad0-f220-86b9-6fe6-0a11668dd250@gmail.com> (raw)
In-Reply-To: <3140ef24-f8c9-5863-ff44-4c83192eabb1-otUistvHUpPR7s880joybQ@public.gmane.org>

Am 15.06.2018 um 17:19 schrieb Michel Dänzer:
> On 2018-06-15 05:18 PM, Christian König wrote:
>> Am 15.06.2018 um 17:14 schrieb Michel Dänzer:
>>> On 2018-06-15 05:11 PM, Christian König wrote:
>>>> Am 15.06.2018 um 16:42 schrieb Michel Dänzer:
>>>>> +
>>>>> +    if (mem->start >= adev->gmc.visible_vram_size >> PAGE_SHIFT)
>>>>>             return amdgpu_bo_size(bo);
>>>>>     -    return 0;
>>>>> +    if (!nodes)
>>>>> +        return 0;
>>>>> +
>>>>> +    spin_lock(&mgr->lock);
>>>> I actually don't see any need to grab the lock here.
>>> Ah, so amdgpu_vram_mgr_del only grabs it for drm_mm_remove_node?
>> Yes, exactly.
> Will drop it in v2, thanks!

Haven't seeen v2 yet, but with that lock removed the whole series is 
Reviewed-by: Christian König <christian.koenig@amd.com>.

Regards,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx