From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A89F9ECAAD3 for ; Fri, 2 Sep 2022 00:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233901AbiIBAtr (ORCPT ); Thu, 1 Sep 2022 20:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233070AbiIBAtq (ORCPT ); Thu, 1 Sep 2022 20:49:46 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C03BDA346C; Thu, 1 Sep 2022 17:49:43 -0700 (PDT) Subject: Re: [PATCH -next 2/3] md/raid10: convert resync_lock to use seqlock DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1662079781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0tfKxGEYrA0RBCCtx0QWA44gG7pan/FKXmz4kkJLuMg=; b=domX3+D/CcCUokpt8f3DKgU6FIdsOVqYte6ENDaUHk2/J4u6HpfQHkqTgdF+RFLQI/Xrpz Ik34IbDRuo852jbWQYdjM8LwKB7xjktuvluX2bSV9YPynEX/i0DEMod7H7txypzblnAcMo 351pFc/7CcnIzf0kGw+AYczU4ttOok0= To: Logan Gunthorpe , Yu Kuai , song@kernel.org Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com References: <20220829131502.165356-1-yukuai1@huaweicloud.com> <20220829131502.165356-3-yukuai1@huaweicloud.com> <04128618-962f-fd4e-64a9-09ecf7f83776@deltatee.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Message-ID: <917c01c1-1e2b-66f9-69f1-ed706b7ffc8f@linux.dev> Date: Fri, 2 Sep 2022 08:49:37 +0800 MIME-Version: 1.0 In-Reply-To: <04128618-962f-fd4e-64a9-09ecf7f83776@deltatee.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 9/2/22 2:41 AM, Logan Gunthorpe wrote: > Hi, > > On 2022-08-29 07:15, Yu Kuai wrote: >> From: Yu Kuai >> >> Currently, wait_barrier() will hold 'resync_lock' to read 'conf->barrier', >> and io can't be dispatched until 'barrier' is dropped. >> >> Since holding the 'barrier' is not common, convert 'resync_lock' to use >> seqlock so that holding lock can be avoided in fast path. >> >> Signed-off-by: Yu Kuai > I've found some lockdep issues starting with this patch in md-next while > running mdadm tests (specifically 00raid10 when run about 10 times in a > row). > > I've seen a couple different lock dep errors. The first seems to be > reproducible on this patch, then it possibly changes to the second on > subsequent patches. Not sure exactly. That's why I said "try mdadm test suites too to avoid regression." ... Guoqing