From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5355C352A3 for ; Tue, 11 Feb 2020 07:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3F20206D7 for ; Tue, 11 Feb 2020 07:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727723AbgBKHmp (ORCPT ); Tue, 11 Feb 2020 02:42:45 -0500 Received: from ivanoab7.miniserver.com ([37.128.132.42]:42908 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726219AbgBKHmp (ORCPT ); Tue, 11 Feb 2020 02:42:45 -0500 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1QBs-0007Vn-1k; Tue, 11 Feb 2020 07:42:40 +0000 Received: from sleer.kot-begemot.co.uk ([192.168.3.72]) by jain.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j1QBp-0007Nw-Mr; Tue, 11 Feb 2020 07:42:39 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso To: Jason Wang , netdev@vger.kernel.org Cc: linux-um@lists.infradead.org, mst@redhat.com, virtualization@lists.linux-foundation.org References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> From: Anton Ivanov Organization: Cambridge Greys Message-ID: <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> Date: Tue, 11 Feb 2020 07:42:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Clacks-Overhead: GNU Terry Pratchett Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/02/2020 02:51, Jason Wang wrote: > > On 2020/2/11 上午12:55, Anton Ivanov wrote: >> >> >> On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: >>> From: Anton Ivanov >>> >>> Some of the frames marked as GSO which arrive at >>> virtio_net_hdr_from_skb() have no GSO_TYPE, no >>> fragments (data_len = 0) and length significantly shorter >>> than the MTU (752 in my experiments). >>> >>> This is observed on raw sockets reading off vEth interfaces >>> in all 4.x and 5.x kernels I tested. >>> >>> These frames are reported as invalid while they are in fact >>> gso-less frames. >>> >>> This patch marks the vnet header as no-GSO for them instead >>> of reporting it as invalid. >>> >>> Signed-off-by: Anton Ivanov >>> --- >>>   include/linux/virtio_net.h | 8 ++++++-- >>>   1 file changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >>> index 0d1fe9297ac6..d90d5cff1b9a 100644 >>> --- a/include/linux/virtio_net.h >>> +++ b/include/linux/virtio_net.h >>> @@ -112,8 +112,12 @@ static inline int virtio_net_hdr_from_skb(const >>> struct sk_buff *skb, >>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; >>>           else if (sinfo->gso_type & SKB_GSO_TCPV6) >>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; >>> -        else >>> -            return -EINVAL; >>> +        else { >>> +            if (skb->data_len == 0) >>> +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; >>> +            else >>> +                return -EINVAL; >>> +        } >>>           if (sinfo->gso_type & SKB_GSO_TCP_ECN) >>>               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >>>       } else >>> >> >> ping. >> > > Do you mean gso_size is set but gso_type is not? Looks like a bug > elsewhere. > > Thanks > > Yes. I could not trace it where it is coming from. I see it when doing recvmmsg on raw sockets in the UML vector network drivers. -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1QBv-0007hi-NP for linux-um@lists.infradead.org; Tue, 11 Feb 2020 07:42:45 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> From: Anton Ivanov Message-ID: <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> Date: Tue, 11 Feb 2020 07:42:37 +0000 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Jason Wang , netdev@vger.kernel.org Cc: virtualization@lists.linux-foundation.org, linux-um@lists.infradead.org, mst@redhat.com T24gMTEvMDIvMjAyMCAwMjo1MSwgSmFzb24gV2FuZyB3cm90ZToKPiAKPiBPbiAyMDIwLzIvMTEg 5LiK5Y2IMTI6NTUsIEFudG9uIEl2YW5vdiB3cm90ZToKPj4KPj4KPj4gT24gMDkvMTIvMjAxOSAx MDo0OCwgYW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbSB3cm90ZToKPj4+IEZyb206IEFu dG9uIEl2YW5vdiA8YW50b24uaXZhbm92QGNhbWJyaWRnZWdyZXlzLmNvbT4KPj4+Cj4+PiBTb21l IG9mIHRoZSBmcmFtZXMgbWFya2VkIGFzIEdTTyB3aGljaCBhcnJpdmUgYXQKPj4+IHZpcnRpb19u ZXRfaGRyX2Zyb21fc2tiKCkgaGF2ZSBubyBHU09fVFlQRSwgbm8KPj4+IGZyYWdtZW50cyAoZGF0 YV9sZW4gPSAwKSBhbmQgbGVuZ3RoIHNpZ25pZmljYW50bHkgc2hvcnRlcgo+Pj4gdGhhbiB0aGUg TVRVICg3NTIgaW4gbXkgZXhwZXJpbWVudHMpLgo+Pj4KPj4+IFRoaXMgaXMgb2JzZXJ2ZWQgb24g cmF3IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4+PiBpbiBhbGwgNC54IGFu ZCA1Lngga2VybmVscyBJIHRlc3RlZC4KPj4+Cj4+PiBUaGVzZSBmcmFtZXMgYXJlIHJlcG9ydGVk IGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+Pj4gZ3NvLWxlc3MgZnJhbWVzLgo+ Pj4KPj4+IFRoaXMgcGF0Y2ggbWFya3MgdGhlIHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhl bSBpbnN0ZWFkCj4+PiBvZiByZXBvcnRpbmcgaXQgYXMgaW52YWxpZC4KPj4+Cj4+PiBTaWduZWQt b2ZmLWJ5OiBBbnRvbiBJdmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4+ PiAtLS0KPj4+IMKgIGluY2x1ZGUvbGludXgvdmlydGlvX25ldC5oIHwgOCArKysrKystLQo+Pj4g wqAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Cj4+ PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmggYi9pbmNsdWRlL2xpbnV4 L3ZpcnRpb19uZXQuaAo+Pj4gaW5kZXggMGQxZmU5Mjk3YWM2Li5kOTBkNWNmZjFiOWEgMTAwNjQ0 Cj4+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+Pj4gKysrIGIvaW5jbHVkZS9s aW51eC92aXJ0aW9fbmV0LmgKPj4+IEBAIC0xMTIsOCArMTEyLDEyIEBAIHN0YXRpYyBpbmxpbmUg aW50IHZpcnRpb19uZXRfaGRyX2Zyb21fc2tiKGNvbnN0IAo+Pj4gc3RydWN0IHNrX2J1ZmYgKnNr YiwKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9f TkVUX0hEUl9HU09fVENQVjQ7Cj4+PiDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZSBpZiAoc2luZm8t Pmdzb190eXBlICYgU0tCX0dTT19UQ1BWNikKPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGhkci0+Z3NvX3R5cGUgPSBWSVJUSU9fTkVUX0hEUl9HU09fVENQVjY7Cj4+PiAtwqDCoMKgwqDC oMKgwqAgZWxzZQo+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+ PiArwqDCoMKgwqDCoMKgwqAgZWxzZSB7Cj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAo c2tiLT5kYXRhX2xlbiA9PSAwKQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBo ZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX05PTkU7Cj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBlbHNlCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVy biAtRUlOVkFMOwo+Pj4gK8KgwqDCoMKgwqDCoMKgIH0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCBp ZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19UQ1BfRUNOKQo+Pj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgaGRyLT5nc29fdHlwZSB8PSBWSVJUSU9fTkVUX0hEUl9HU09fRUNOOwo+Pj4g wqDCoMKgwqDCoCB9IGVsc2UKPj4+Cj4+Cj4+IHBpbmcuCj4+Cj4gCj4gRG8geW91IG1lYW4gZ3Nv X3NpemUgaXMgc2V0IGJ1dCBnc29fdHlwZSBpcyBub3Q/IExvb2tzIGxpa2UgYSBidWcgCj4gZWxz ZXdoZXJlLgo+IAo+IFRoYW5rcwo+IAo+IApZZXMuCgpJIGNvdWxkIG5vdCB0cmFjZSBpdCB3aGVy ZSBpdCBpcyBjb21pbmcgZnJvbS4KCkkgc2VlIGl0IHdoZW4gZG9pbmcgcmVjdm1tc2cgb24gcmF3 IHNvY2tldHMgaW4gdGhlIFVNTCB2ZWN0b3IgbmV0d29yayAKZHJpdmVycy4KCgotLSAKQW50b24g Ui4gSXZhbm92CkNhbWJyaWRnZWdyZXlzIExpbWl0ZWQuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZC4g Q29tcGFueSBOdW1iZXIgMTAyNzM2NjEKaHR0cHM6Ly93d3cuY2FtYnJpZGdlZ3JleXMuY29tLwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0g bWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=