From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eads, Gage" <gage.eads@intel.com>
Subject: Re: [PATCH v7 0/8] Add stack library and new mempool
 handler
Date: Wed, 3 Apr 2019 20:49:08 +0000
Message-ID: <9184057F7FC11744A2107296B6B8EB1E542107EF@FMSMSX108.amr.corp.intel.com>
References: <20190401211429.20282-1-gage.eads@intel.com>
 <20190403200916.16349-1-gage.eads@intel.com> <4770051.yqIPWfFot0@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com"
 <olivier.matz@6wind.com>, "arybchenko@solarflare.com"
 <arybchenko@solarflare.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>,
 "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>, "nd@arm.com"
 <nd@arm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 5F2845920
 for <dev@dpdk.org>; Wed,  3 Apr 2019 22:49:12 +0200 (CEST)
In-Reply-To: <4770051.yqIPWfFot0@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, April 3, 2019 3:40 PM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; gavin.hu@arm.com;
> Honnappa.Nagarahalli@arm.com; nd@arm.com
> Subject: Re: [dpdk-dev] [PATCH v7 0/8] Add stack library and new mempool
> handler
>=20
> 03/04/2019 22:09, Gage Eads:
> > v7:
> > - Add rte_branch_prediction.h include to rte_stack_std.h for unlikely()
> > - Add rte_compat.h include to rte_stack.h for __rte_experimental
>=20
> There is another error when compiling for Arm:
>=20
> lib/librte_stack/rte_stack.h:76:2: error:
> 	implicit declaration of function 'RTE_ASSERT'

Fix incoming. Looking through the rest of that header, I don't see any othe=
r externally defined macros/data structures/functions/etc. that would need =
another include.

Also note that v7's ci/Performance-Testing build fail (http://mails.dpdk.or=
g/archives/test-report/2019-April/079261.html) is because dpdklab applied t=
he patch on commit 3c45889189924067, which is older than the 128-bit CAS pa=
tch.