From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eads, Gage" <gage.eads@intel.com>
Subject: Re: [PATCH v9 1/8] stack: introduce rte stack library
Date: Thu, 4 Apr 2019 14:14:18 +0000
Message-ID: <9184057F7FC11744A2107296B6B8EB1E54210E03@FMSMSX108.amr.corp.intel.com>
References: <20190403205041.4651-1-gage.eads@intel.com>
 <20190403232020.12784-1-gage.eads@intel.com>
 <20190403232020.12784-2-gage.eads@intel.com> <1742818.CN8ABES3X5@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com"
 <olivier.matz@6wind.com>, "arybchenko@solarflare.com"
 <arybchenko@solarflare.com>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>,
 "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>, "nd@arm.com"
 <nd@arm.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id E541D1B3D8
 for <dev@dpdk.org>; Thu,  4 Apr 2019 16:14:20 +0200 (CEST)
In-Reply-To: <1742818.CN8ABES3X5@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, April 4, 2019 8:30 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; gavin.hu@arm.com;
> Honnappa.Nagarahalli@arm.com; nd@arm.com
> Subject: Re: [dpdk-dev] [PATCH v9 1/8] stack: introduce rte stack library
>=20
> 04/04/2019 01:20, Gage Eads:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -87,6 +87,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY)       +=3D -
> lrte_security
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV)    +=3D -lrte_compressdev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV)       +=3D -lrte_eventdev
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_RAWDEV)         +=3D -lrte_rawdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_STACK)          +=3D -lrte_stack
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          +=3D -lrte_timer
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL)        +=3D -lrte_mempool
> >  _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   +=3D -
> lrte_mempool_ring
>=20
> Stack library is used by mempool, so it should appear after mempool in th=
e
> library list.
> It is the same as ring lib being after mempool_ring.
>=20
> If you agree, please just tell me without sending a new version, because =
I'm
> doing other minor changes (sorting stack near ring in many files).
>=20

Agreed. I suspect we haven't seen any linker problems because it's in a --w=
hole-archive section (line 72), but better to put these in the correct depe=
ndency order.